From 1da1f945e2988080add4923dc2021753e3b2f7c1 Mon Sep 17 00:00:00 2001 From: Michael Mann Date: Sun, 24 Jul 2016 08:53:39 -0400 Subject: Fix checkAPI.pl warnings about printf Many of the complaints from checkAPI.pl for use of printf are when its embedded in an #ifdef and checkAPI isn't smart enough to figure that out. The other (non-ifdef) use is dumping internal structures (which is a type of debug functionality) Add a "ws_debug_printf" macro for printf to pacify the warnings. Change-Id: I63610e1adbbaf2feffb4ec9d4f817247d833f7fd Reviewed-on: https://code.wireshark.org/review/16623 Reviewed-by: Michael Mann Petri-Dish: Michael Mann Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman --- wsutil/ws_printf.h | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'wsutil/ws_printf.h') diff --git a/wsutil/ws_printf.h b/wsutil/ws_printf.h index 1ee3bf69e6..d996d01c5e 100644 --- a/wsutil/ws_printf.h +++ b/wsutil/ws_printf.h @@ -93,6 +93,14 @@ ws_snprintf(char *buffer, size_t size_of_buffer, const char * format, ...) { va_end(argptr); } +/* This is intended to fool checkAPIs.pl for places that have "debugging" +(using printf) usually wrapped in an #ifdef, but checkAPIs.pl isn't smart +enough to figure that out. +Dissectors should still try to use proto_tree_add_debug_text when the +debugging context has a protocol tree. +*/ +#define ws_debug_printf printf + #ifdef __cplusplus } #endif /* __cplusplus */ -- cgit v1.2.3