From 31570163d14da6de4a1b7fde4fdde2ff9b9d20a9 Mon Sep 17 00:00:00 2001 From: Jim Young Date: Fri, 20 Dec 2019 08:16:18 -0500 Subject: Revert "Qt: Fix dangling delete for sequence diagramm" This reverts commit aa2145982f3aec7320f33d201a17d0fdbea2a6c0. Each of the three delete calls added to the deconstructor SequenceDialog::~SequenceDialog() results in Wireshark crashing when the Flow dialog is closed. Bug: 16260 Change-Id: Iecbd5dcc16be6eb451b8920b22ca2b9ccef7c7b0 Reviewed-on: https://code.wireshark.org/review/35521 Petri-Dish: Jim Young Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall --- ui/qt/sequence_dialog.cpp | 3 --- 1 file changed, 3 deletions(-) (limited to 'ui') diff --git a/ui/qt/sequence_dialog.cpp b/ui/qt/sequence_dialog.cpp index 3c60767a70..39c90b5193 100644 --- a/ui/qt/sequence_dialog.cpp +++ b/ui/qt/sequence_dialog.cpp @@ -191,9 +191,6 @@ SequenceDialog::SequenceDialog(QWidget &parent, CaptureFile &cf, SequenceInfo *i SequenceDialog::~SequenceDialog() { - delete key_text_; - delete comment_text_; - delete seq_diagram_; info_->unref(); delete ui; } -- cgit v1.2.3