From 141e2ffcf03640bf270b37a08d6a265685cf7563 Mon Sep 17 00:00:00 2001 From: Guy Harris Date: Tue, 19 Nov 2019 13:42:53 -0800 Subject: Note that Qt imposes a maximum frame number of 2^31-1. Nothing in libwireshark limits frame numbers to 2^31-1 - they're stored as unsigned ints and thus can go up to 2^32-1. That doesn't fit with the way QTreeView works, as the model is ultimately from a subclass of QAbstractItemModel, and that uses ints, not unsigned ints, for row numbers. Change-Id: I174c3ccdb5e86ea5897643560936c301fcc78c54 Reviewed-on: https://code.wireshark.org/review/35141 Reviewed-by: Guy Harris --- ui/qt/packet_list.h | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'ui/qt') diff --git a/ui/qt/packet_list.h b/ui/qt/packet_list.h index eaaabbab18..28033b5af1 100644 --- a/ui/qt/packet_list.h +++ b/ui/qt/packet_list.h @@ -28,6 +28,13 @@ class OverlayScrollBar; class QAction; class QTimerEvent; +// +// XXX - Wireshark supports up to 2^32-1 packets in a capture, but +// row numbers in a QAbstractItemModel are ints, not unsigned ints, +// so we can only have 2^31-1 rows on ILP32, LP64, and LLP64 platforms. +// Does that mean we're permanently stuck at a maximum of 2^31-1 packets +// per capture? +// class PacketList : public QTreeView { Q_OBJECT -- cgit v1.2.3