From a17bbc184170cf2faf4752f63f4dce0bba9e0dd5 Mon Sep 17 00:00:00 2001 From: Mikael Kanstrup Date: Sun, 17 Sep 2017 23:48:12 +0200 Subject: qt: Fix some leaked menu objects Calling QPushButton.setMenu and QMenu.addMenu does not transfer ownership of the menu. Fix some leaks by letting "receiving" object act parent for the menu object. Bug: 14071 Change-Id: Id4edaf895503ef5dd4597eac99c2cdd6ad09b2ff Reviewed-on: https://code.wireshark.org/review/23600 Petri-Dish: Anders Broman Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman --- ui/qt/resolved_addresses_dialog.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'ui/qt/resolved_addresses_dialog.cpp') diff --git a/ui/qt/resolved_addresses_dialog.cpp b/ui/qt/resolved_addresses_dialog.cpp index f8488bdce5..898bdcc7de 100644 --- a/ui/qt/resolved_addresses_dialog.cpp +++ b/ui/qt/resolved_addresses_dialog.cpp @@ -281,7 +281,7 @@ void ResolvedAddressesDialog::fillShowMenu() show_bt->setText(tr("Show")); if (!show_bt->menu()) { - show_bt->setMenu(new QMenu()); + show_bt->setMenu(new QMenu(show_bt)); } QMenu *show_menu = show_bt->menu(); -- cgit v1.2.3