From 16953695d734555a4472bada9d2dec799544d619 Mon Sep 17 00:00:00 2001 From: Peter Wu Date: Tue, 10 Jul 2018 00:33:24 +0200 Subject: Qt: make "Save As" in Follow Streams usable For formats other than "Raw" and "UTF-8", the written file does not match the actual stream data. It would be duplicated in strange ways. Executing the "Save As" action twice while the dialog is open would also write two different files (huh?). As a quick fix, just replace the strange save logic by writing the text field contents. A functional difference is that previously it would write data while parsing the "follow data" list, now it uses the text field contents. That data will now be truncated after 500 MB. Bug: 14933 Change-Id: I498676389d0da3ac070346d6903bd2e6b0fc7674 Fixes: v1.11.0-rc1-2538-g80f9326b2f ("Add TCP/UDP/SSL Follow feature to QtShark") Reviewed-on: https://code.wireshark.org/review/28663 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu --- ui/qt/follow_stream_dialog.h | 2 -- 1 file changed, 2 deletions(-) (limited to 'ui/qt/follow_stream_dialog.h') diff --git a/ui/qt/follow_stream_dialog.h b/ui/qt/follow_stream_dialog.h index f4b6dd25af..805f46c6ab 100644 --- a/ui/qt/follow_stream_dialog.h +++ b/ui/qt/follow_stream_dialog.h @@ -119,9 +119,7 @@ private: int turns_; QMap text_pos_to_packet_; - bool save_as_; bool use_regex_find_; - QFile file_; bool terminating_; }; -- cgit v1.2.3