From 859511db14feae071cc1e6e1889ae39bfd276faa Mon Sep 17 00:00:00 2001 From: Guy Harris Date: Tue, 17 Feb 2015 16:40:28 -0800 Subject: Make UAT record update callbacks return a success/failure indication. Have them return TRUE on success and FALSE on failure. Check the return value rather than whether the error string pointer is null or not. Change-Id: I800a03bcd70a6bbb7b217cf7c4800e9cdcf2189c Reviewed-on: https://code.wireshark.org/review/7222 Reviewed-by: Guy Harris --- ui/gtk/uat_gui.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'ui/gtk/uat_gui.c') diff --git a/ui/gtk/uat_gui.c b/ui/gtk/uat_gui.c index 1b30680b76..e4de9ffe7d 100644 --- a/ui/gtk/uat_gui.c +++ b/ui/gtk/uat_gui.c @@ -375,9 +375,7 @@ static gboolean uat_dlg_cb(GtkWidget *win _U_, gpointer user_data) { } if (dd->uat->update_cb) { - dd->uat->update_cb(dd->rec, &err); - - if (err) { + if (!dd->uat->update_cb(dd->rec, &err)) { tmp_err = err; err = g_strdup_printf("error updating record: %s", tmp_err); g_free(tmp_err); -- cgit v1.2.3