From 1a9eec385c86e5107066fe80908eb85ef75ca056 Mon Sep 17 00:00:00 2001 From: guy Date: Fri, 23 Mar 2001 20:11:46 +0000 Subject: Don't convert a WTP PDU type to a string by using as an index into a "value_string" array, do it the right way, by using "val_to_str()" - the PDU type is 4 bits, but there aren't 16 entries in the array, so a bogus PDU type (*don't* assume that can't happen...) can cause a core dump. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3169 f5534014-38df-0310-8fa8-9805f1628bb7 --- packet-wtp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'packet-wtp.c') diff --git a/packet-wtp.c b/packet-wtp.c index 5245f08754..73cfe76602 100644 --- a/packet-wtp.c +++ b/packet-wtp.c @@ -2,7 +2,7 @@ * * Routines to dissect WTP component of WAP traffic. * - * $Id: packet-wtp.c,v 1.11 2001/02/13 00:17:54 guy Exp $ + * $Id: packet-wtp.c,v 1.12 2001/03/23 20:11:46 guy Exp $ * * Ethereal - Network traffic analyzer * By Gerald Combs @@ -243,7 +243,8 @@ dissect_wtp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) pdut = pdu_type( b0 ); /* Develop the string to put in the Info column */ - cchInfo = snprintf( szInfo, sizeof( szInfo ), "WTP %s", vals_pdu_type[ ( int )pdut ].strptr ); + cchInfo = snprintf( szInfo, sizeof( szInfo ), "WTP %s", + val_to_str(pdut, vals_pdu_type, "Unknown PDU type 0x%x")); switch( pdut ) { case INVOKE: -- cgit v1.2.3