From d0b97c7d7f4ef5fd35c566a79f20afff08aabcd6 Mon Sep 17 00:00:00 2001 From: guy Date: Mon, 7 Aug 2000 03:21:25 +0000 Subject: Allow either old-style (pre-tvbuff) or new-style (tvbuffified) dissectors to be registered as dissectors for particular ports, registered as heuristic dissectors, and registered as dissectors for conversations, and have routines to be used both by old-style and new-style dissectors to call registered dissectors. Have the code that calls those dissectors translate the arguments as necessary. (For conversation dissectors, replace "find_conversation_dissector()", which just returns a pointer to the dissector, with "old_try_conversation_dissector()" and "try_conversation_dissector()", which actually call the dissector, so that there's a single place at which we can do that translation. Also make "dissector_lookup()" static and, instead of calling it and, if it returns a non-null pointer, calling that dissector, just use "old_dissector_try_port()" or "dissector_try_port()", for the same reason.) This allows some dissectors that took old-style arguments and immediately translated them to new-style arguments to just take new-style arguments; make them do so. It also allows some new-style dissectors not to have to translate arguments before calling routines to look up and call dissectors; make them not do so. Get rid of checks for too-short frames in new-style dissectors - the tvbuff code does those checks for you. Give the routines to register old-style dissectors, and to call dissectors from old-style dissectors, names beginning with "old_", with the routines for new-style dissectors not having the "old_". Update the dissectors that use those routines appropriately. Rename "dissect_data()" to "old_dissect_data()", and "dissect_data_tvb()" to "dissect_data()". git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2218 f5534014-38df-0310-8fa8-9805f1628bb7 --- packet-ncp.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) (limited to 'packet-ncp.c') diff --git a/packet-ncp.c b/packet-ncp.c index 83e6b0334c..15ce9c670b 100644 --- a/packet-ncp.c +++ b/packet-ncp.c @@ -3,7 +3,7 @@ * Gilbert Ramirez * Modified to allow NCP over TCP/IP decodes by James Coe * - * $Id: packet-ncp.c,v 1.38 2000/07/28 20:03:42 gram Exp $ + * $Id: packet-ncp.c,v 1.39 2000/08/07 03:20:54 guy Exp $ * * Ethereal - Network traffic analyzer * By Gerald Combs @@ -247,17 +247,9 @@ ncp_hash_lookup(conversation_t *conversation, guint8 nw_sequence, } } -#if 0 -void +static void dissect_ncp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) { -#else -void -dissect_ncp(const u_char *pd, int offset, frame_data *fd, proto_tree *tree) -{ - packet_info *pinfo = π - tvbuff_t *tvb = tvb_create_from_top(offset); -#endif proto_tree *ncp_tree = NULL; proto_item *ti; struct ncp_ip_header ncpiph; -- cgit v1.2.3