From cc36f0b9312fc36778bf227cbaaf02c89baf09b3 Mon Sep 17 00:00:00 2001 From: Laurent Deniel Date: Sun, 13 Aug 2000 14:09:15 +0000 Subject: Add the "Edit:Protocols..." feature which currently only implements the following: It is now possible to enable/disable a particular protocol decoding (i.e. the protocol dissector is void or not). When a protocol is disabled, it is displayed as Data and of course, all linked sub-protocols are disabled as well. Disabling a protocol could be interesting: - in case of buggy dissectors - in case of wrong heuristics - for performance reasons - to decode the data as another protocol (TODO) Currently (if I am not wrong), all dissectors but NFS can be disabled (and dissectors that do not register protocols :-) I do not like the way the RPC sub-dissectors are disabled (in the sub-dissectors) since this could be done in the RPC dissector itself, knowing the sub-protocol hfinfo entry (this is why, I've not modified the NFS one yet). Two functions are added in proto.c : gboolean proto_is_protocol_enabled(int n); void proto_set_decoding(int n, gboolean enabled); and two MACROs which can be used in dissectors: OLD_CHECK_DISPLAY_AS_DATA(index, pd, offset, fd, tree) CHECK_DISPLAY_AS_DATA(index, tvb, pinfo, tree) See also the XXX in proto_dlg.c and proto.c around the new functions. svn path=/trunk/; revision=2267 --- packet-ncp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'packet-ncp.c') diff --git a/packet-ncp.c b/packet-ncp.c index 15ce9c670b..830d9213bd 100644 --- a/packet-ncp.c +++ b/packet-ncp.c @@ -3,7 +3,7 @@ * Gilbert Ramirez * Modified to allow NCP over TCP/IP decodes by James Coe * - * $Id: packet-ncp.c,v 1.39 2000/08/07 03:20:54 guy Exp $ + * $Id: packet-ncp.c,v 1.40 2000/08/13 14:08:31 deniel Exp $ * * Ethereal - Network traffic analyzer * By Gerald Combs @@ -259,6 +259,8 @@ dissect_ncp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) int hdr_offset = 0; int commhdr; + CHECK_DISPLAY_AS_DATA(proto_ncp, tvb, pinfo, tree); + pinfo->current_proto = "NCP"; if (check_col(pinfo->fd, COL_PROTOCOL)) col_add_str(pinfo->fd, COL_PROTOCOL, "NCP"); -- cgit v1.2.3