From 1980fa5dbf6e3aa953d8bd09d69e0700b74a56ad Mon Sep 17 00:00:00 2001 From: Guy Harris Date: Sat, 31 Jan 2004 03:22:42 +0000 Subject: Pass ESD_BTN_OK rather than NULL as a second argument to "simple_dialog()"; NULL might be #defined to be a pointer expression on some platforms, causing compiler warnings (and, on platforms where a null pointer doesn't have all its bits 0, possibly causing misbehavior, although I don't think there are any such platforms on which Ethereal runs). Don't allow 0 as button mask argument to "simple_dialog()". Squelch a compiler warning. Report fatal problems as errors, not warnings. Report file I/O errors with "file_open_error_message()". Report file write errors (including those reported by "close()", e.g. some errors writing to an NFS server) when saving raw packet data to a file. svn path=/trunk/; revision=9915 --- gtk/service_response_time_table.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'gtk/service_response_time_table.c') diff --git a/gtk/service_response_time_table.c b/gtk/service_response_time_table.c index b0bb89f8fd..54b3051e49 100644 --- a/gtk/service_response_time_table.c +++ b/gtk/service_response_time_table.c @@ -3,7 +3,7 @@ * Helper routines common to all service response time statistics * tap. * - * $Id: service_response_time_table.c,v 1.12 2004/01/25 18:51:26 ulfl Exp $ + * $Id: service_response_time_table.c,v 1.13 2004/01/31 03:22:42 guy Exp $ * * Ethereal - Network traffic analyzer * By Gerald Combs @@ -171,7 +171,7 @@ srt_select_filter_cb(GtkWidget *widget _U_, gpointer callback_data, guint callba selection=GPOINTER_TO_INT(g_list_nth_data(GTK_CLIST(rst->table)->selection, 0)); if(selection>=(int)rst->num_procs){ - simple_dialog(ESD_TYPE_WARN, NULL, "No procedure selected"); + simple_dialog(ESD_TYPE_ERROR, ESD_BTN_OK, "No procedure selected"); return; } /* translate it back from row index to index in procedures array */ -- cgit v1.2.3