From 2226802826c4ba802696d5df274094cec3818af1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Valverde?= Date: Mon, 28 Mar 2016 17:59:30 +0100 Subject: make-taps.pl: Enable "use warnings" pragma Replace sprintf to fix newly generated warning. Change-Id: I85e8b0989c0caa4c9b079883b8653c9892df171c Reviewed-on: https://code.wireshark.org/review/14677 Reviewed-by: Peter Wu Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte --- epan/wslua/make-taps.pl | 37 +++++++++++++++++++------------------ 1 file changed, 19 insertions(+), 18 deletions(-) (limited to 'epan') diff --git a/epan/wslua/make-taps.pl b/epan/wslua/make-taps.pl index 8e4b26b4e8..5faaa925d9 100755 --- a/epan/wslua/make-taps.pl +++ b/epan/wslua/make-taps.pl @@ -26,24 +26,25 @@ # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +use warnings; my %types = %{{ - 'gchar[]' => 'lua_pushstring(L,(const char*)v->%s);', - 'gchar*' => 'lua_pushstring(L,(const char*)v->%s);', - 'guint' => 'lua_pushnumber(L,(lua_Number)v->%s);', - 'guint8' => 'lua_pushnumber(L,(lua_Number)v->%s);', - 'guint16' => 'lua_pushnumber(L,(lua_Number)v->%s);', - 'guint32' => 'lua_pushnumber(L,(lua_Number)v->%s);', - 'gint' => 'lua_pushnumber(L,(lua_Number)v->%s);', - 'gint8' => 'lua_pushnumber(L,(lua_Number)v->%s);', - 'gint16' => 'lua_pushnumber(L,(lua_Number)v->%s);', - 'gint32' => 'lua_pushnumber(L,(lua_Number)v->%s);', - 'gboolean' => 'lua_pushboolean(L,(int)v->%s);', - 'address' => '{ Address a = (Address)g_malloc(sizeof(address)); copy_address(a, &(v->%s)); pushAddress(L,a); }', - 'address*' => '{ Address a = (Address)g_malloc(sizeof(address)); copy_address(a, v->%s); pushAddress(L,a); }', - 'int' => 'lua_pushnumber(L,(lua_Number)v->%s);', - 'nstime_t' => '{ lua_Number t = (lua_Number) v->%s.secs; t += v->%s.nsecs * 1e-9; lua_pushnumber(L,t); }', - 'nstime_t*' => '{ lua_Number t = (lua_Number) v->%s->secs; t += v->%s->nsecs * 1e-9; lua_pushnumber(L,t); }', + 'gchar[]' => 'lua_pushstring(L,(const char*)v->STR);', + 'gchar*' => 'lua_pushstring(L,(const char*)v->STR);', + 'guint' => 'lua_pushnumber(L,(lua_Number)v->STR);', + 'guint8' => 'lua_pushnumber(L,(lua_Number)v->STR);', + 'guint16' => 'lua_pushnumber(L,(lua_Number)v->STR);', + 'guint32' => 'lua_pushnumber(L,(lua_Number)v->STR);', + 'gint' => 'lua_pushnumber(L,(lua_Number)v->STR);', + 'gint8' => 'lua_pushnumber(L,(lua_Number)v->STR);', + 'gint16' => 'lua_pushnumber(L,(lua_Number)v->STR);', + 'gint32' => 'lua_pushnumber(L,(lua_Number)v->STR);', + 'gboolean' => 'lua_pushboolean(L,(int)v->STR);', + 'address' => '{ Address a = (Address)g_malloc(sizeof(address)); copy_address(a, &(v->STR)); pushAddress(L,a); }', + 'address*' => '{ Address a = (Address)g_malloc(sizeof(address)); copy_address(a, v->STR); pushAddress(L,a); }', + 'int' => 'lua_pushnumber(L,(lua_Number)v->STR);', + 'nstime_t' => '{ lua_Number t = (lua_Number) v->STR.secs; t += v->STR.nsecs * 1e-9; lua_pushnumber(L,t); }', + 'nstime_t*' => '{ lua_Number t = (lua_Number) v->STR->secs; t += v->STR->nsecs * 1e-9; lua_pushnumber(L,t); }', }}; my %comments = %{{ @@ -88,7 +89,7 @@ sub dotap { my $enumre = "typedef\\s+enum[^{]*{([^}]*)}[\\s\\n]*" . ${ename} . "[\\s\\n]*;"; if ($buf =~ s/$enumre//ms ) { - $types{$ename} = "lua_pushnumber(L,(lua_Number)v->%s); /* $ename */"; + $types{$ename} = "lua_pushnumber(L,(lua_Number)v->STR); /* $ename */"; my $ebody = $1; $ebody =~ s/\s+//msg; $comments{$ename} = "$ename: { $ebody }"; @@ -132,7 +133,7 @@ sub dotap { if ($fmt) { $code .= "\tlua_pushstring(L,\"$n\");\n\t"; - $code .= sprintf($fmt,$n,$n) . "\n\tlua_settable(L,-3);\n"; + $code .= $fmt =~ s/\bSTR\b/$n/rg . "\n\tlua_settable(L,-3);\n"; $doc .= "\t$n: $comments{$elems{$n}}\n"; } -- cgit v1.2.3