From ac8fdfe5715a61c05a6248a46b9bda85339fc52c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stig=20Bj=C3=B8rlykke?= Date: Wed, 30 Dec 2009 14:24:10 +0000 Subject: From babi via bug 4352: * wslua doesnt null-terminate a char array properly after one strncpy call * packet-smb-sidsnooping (disabled now but someone might enable it again) has a potential overflow crash (i think?) svn path=/trunk/; revision=31392 --- epan/wslua/wslua_util.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'epan/wslua') diff --git a/epan/wslua/wslua_util.c b/epan/wslua/wslua_util.c index eb426feadf..bc661676be 100644 --- a/epan/wslua/wslua_util.c +++ b/epan/wslua/wslua_util.c @@ -151,7 +151,8 @@ static char* wslua_get_actual_filename(const char* fname) { char* f; char* filename; - strncpy(fname_clean,fname,256); + strncpy(fname_clean,fname,255); + fname_clean[255] = '\0'; for(f = fname_clean; *f; f++) { switch(*f) { -- cgit v1.2.3