From bac9b5b6fdfb9d3f306bb65f6509dce7144e82ad Mon Sep 17 00:00:00 2001 From: Hadriel Kaplan Date: Fri, 14 Mar 2014 21:05:25 -0400 Subject: Fix lrexlib.c clang static analyzer warning This fixes a "Argument with 'nonnull' attribute passed null" warning generated by the clang static analyzer. It's a false positive, but easy to remedy. Change-Id: Id737d1ac29765ed26a416c5cd13bedafee478fb6 Reviewed-on: https://code.wireshark.org/review/661 Reviewed-by: Anders Broman --- epan/wslua/lrexlib.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'epan/wslua/lrexlib.c') diff --git a/epan/wslua/lrexlib.c b/epan/wslua/lrexlib.c index 572aa60664..5d99522678 100644 --- a/epan/wslua/lrexlib.c +++ b/epan/wslua/lrexlib.c @@ -158,6 +158,7 @@ void buffer_init (TBuffer *buf, size_t sz, lua_State *L, TFreeList *fl) { if (!buf->arr) { freelist_free (fl); luaL_error (L, "malloc failed"); + return; } buf->size = sz; buf->top = 0; @@ -189,6 +190,7 @@ void buffer_addlstring (TBuffer *buf, const void *src, size_t sz) { if (!p) { freelist_free (buf->freelist); luaL_error (buf->L, "realloc failed"); + return; } buf->arr = p; buf->size = 2 * newtop; @@ -247,6 +249,7 @@ void bufferZ_putrepstring (TBuffer *BufRep, int reppos, int nsub) { else if (num > nsub) { freelist_free (BufRep->freelist); luaL_error (BufRep->L, "invalid capture index"); + return; } bufferZ_addnum (BufRep, num); } -- cgit v1.2.3