From 10306f9a32ee4ca65283110ac286bb1ba9ef2a01 Mon Sep 17 00:00:00 2001 From: Peter Wu Date: Wed, 9 May 2018 22:37:41 +0200 Subject: Free g_array_free-related memory leaks g_array_free(a, FALSE) returns "a->data". Callers that do not handle this will leak memory. Convert other users to use the return value instead of direct access to "a->data". Change-Id: I0a29864e8106c0bf09e9573ef29e4474179c4171 Reviewed-on: https://code.wireshark.org/review/27438 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu --- epan/oids.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'epan/oids.c') diff --git a/epan/oids.c b/epan/oids.c index b30ed2d084..400f7b8ac6 100644 --- a/epan/oids.c +++ b/epan/oids.c @@ -660,8 +660,7 @@ static void register_mibs(void) { } } - hf.hfinfo.strings = vals->data; - g_array_free(vals,FALSE); + hf.hfinfo.strings = g_array_free(vals, FALSE); } #if 0 /* packet-snmp does not handle bits yet */ } else if (smiType->basetype == SMI_BASETYPE_BITS && ( smiEnum = smiGetFirstNamedNumber(smiType) )) { -- cgit v1.2.3