From 89cfdc35590c515e19654cddde7a7c1018f9ccc2 Mon Sep 17 00:00:00 2001
From: Jeff Morriss <jeff.morriss@ulticom.com>
Date: Tue, 28 Feb 2012 03:19:49 +0000
Subject: Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3315 - make
 Save-As/Displayed/All-Packets save not only the displayed packets but also
 any other packets needed (e.g., for reassembly) to fully dissect the
 displayed packets.

This works only for the "All packets" case; choosing only the Selected packet,
the Marked packets, or a range of packets would require actually storing which
packets depend on which (too much memory) or going through the packet list many
times (too slow).  Also, this behavior is always the case: you can't save the
displayed packets without their dependencies (I don't see why this would be
desirable).

So far this is done for SCTP and things using the reassembly routines (TCP has
been tested).

The Win32 dialog was modified but hasn't been tested yet.

One confusing aspect of the UI is that the Displayed count in the Save-As
dialog does not match the number of displayed packets.  (I tried renaming the
button "Displayed + Dependencies" but it looked too big.)  The tooltip tries
to explain this and the fact that this works only in the All-Packets case;
suggestions for improvement are welcome.


Implementation details:

Dissectors (or the reassembly code) can list frames which were needed to
build the current frame's tree.  If the current frame passes the display
filter then each listed frame is marked as "depended upon" (this takes up the
last free frame_data flag).

When performing a Save-As/Displayed/All-Packets then choose packets which
passed the dfilter _or_ are depended upon.

svn path=/trunk/; revision=41216
---
 epan/libwireshark.def | 1 +
 1 file changed, 1 insertion(+)

(limited to 'epan/libwireshark.def')

diff --git a/epan/libwireshark.def b/epan/libwireshark.def
index 02a6e837a0..b250865846 100644
--- a/epan/libwireshark.def
+++ b/epan/libwireshark.def
@@ -646,6 +646,7 @@ list_stat_cmd_args
 llc_add_oui
 LocationRejectReason_vals       DATA
 make_printable_string
+mark_frame_as_depended_upon
 match_strrval
 match_strrval_idx
 match_strval
-- 
cgit v1.2.3

