From 7c15566fa1a92c2970cfd00331efad9b08c50241 Mon Sep 17 00:00:00 2001 From: Tigran Mkrtchyan Date: Wed, 24 Feb 2016 08:59:07 +0100 Subject: packet-nfs: do not call g_hash_table_remove before g_hash_table_insert The g_hash_table_insert will remove and deallocate existing entry, so we don't need to do it at all. Change-Id: I661cadd8beea9585885e48c03a8b52561d1df778 Signed-off-by: Tigran Mkrtchyan Reviewed-on: https://code.wireshark.org/review/14113 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu --- epan/dissectors/packet-nfs.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) (limited to 'epan/dissectors') diff --git a/epan/dissectors/packet-nfs.c b/epan/dissectors/packet-nfs.c index 384f6fd3ba..cdd337d390 100644 --- a/epan/dissectors/packet-nfs.c +++ b/epan/dissectors/packet-nfs.c @@ -1120,7 +1120,7 @@ static void nfs_name_snoop_add_fh(int xid, tvbuff_t *tvb, int fh_offset, int fh_length) { unsigned char *fh; - nfs_name_snoop_t *nns, *old_nns; + nfs_name_snoop_t *nns; nfs_name_snoop_key_t *key; /* find which request we correspond to */ @@ -1145,13 +1145,6 @@ nfs_name_snoop_add_fh(int xid, tvbuff_t *tvb, int fh_offset, int fh_length) key->fh_length = nns->fh_length; key->fh = nns->fh; - /* already have something matched for this fh, remove it from - the table */ - old_nns = (nfs_name_snoop_t *)g_hash_table_lookup(nfs_name_snoop_matched, key); - if (old_nns) { - g_hash_table_remove(nfs_name_snoop_matched, key); - } - g_hash_table_steal(nfs_name_snoop_unmatched, GINT_TO_POINTER(xid)); g_hash_table_insert(nfs_name_snoop_matched, key, nns); } -- cgit v1.2.3