From 99b76a5bc3db9579351c0fc7251086660f4f003f Mon Sep 17 00:00:00 2001 From: Michael Mann Date: Tue, 16 May 2017 14:48:34 -0400 Subject: Use proto_tree_add_item instead of proto_tree_add_xxx. It's a little more efficient to use proto_tree_add_item, than proto_tree_add_xxx, passing it the returned tvb_get_xxx value. Change-Id: I22ddd7ab36e1ee5aae78fc693d7dbac4b4f802f2 Reviewed-on: https://code.wireshark.org/review/21691 Petri-Dish: Anders Broman Reviewed-by: Anders Broman --- epan/dissectors/packet-x25.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'epan/dissectors/packet-x25.c') diff --git a/epan/dissectors/packet-x25.c b/epan/dissectors/packet-x25.c index 4baac06e74..b30ac71670 100644 --- a/epan/dissectors/packet-x25.c +++ b/epan/dissectors/packet-x25.c @@ -1831,12 +1831,10 @@ dissect_x25_common(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, localoffset, 1, pkt_type); proto_tree_add_uint(x25_tree, hf_x25_type_data, tvb, localoffset, 1, pkt_type); - proto_tree_add_uint(x25_tree, hf_x25_p_s_mod128, tvb, - localoffset+1, 1, - tvb_get_guint8(tvb, localoffset+1)); - proto_tree_add_boolean(x25_tree, hf_x25_mbit_mod128, tvb, - localoffset+1, 1, - tvb_get_guint8(tvb, localoffset+1)); + proto_tree_add_item(x25_tree, hf_x25_p_s_mod128, tvb, + localoffset+1, 1, ENC_NA); + proto_tree_add_item(x25_tree, hf_x25_mbit_mod128, tvb, + localoffset+1, 1, ENC_NA); } } if (modulo == 8) { -- cgit v1.2.3