From b68fb9b659b0debd7286195f9ad194be998cc3ff Mon Sep 17 00:00:00 2001 From: Bill Meier Date: Wed, 24 Dec 2014 10:44:03 -0500 Subject: Fix some dissectors doing termio (fprintf(stderr,..), g_warning()). - Use report_...failure() (in most cases). - Also: Do some misc fixes in certain disectors - re-arrange order of #includes - Fixup preferences help text Change-Id: I385f6f97257f365f53ce611df02f57f9257dc5f9 Reviewed-on: https://code.wireshark.org/review/6039 Petri-Dish: Bill Meier Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann --- epan/dissectors/packet-smb-sidsnooping.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'epan/dissectors/packet-smb-sidsnooping.c') diff --git a/epan/dissectors/packet-smb-sidsnooping.c b/epan/dissectors/packet-smb-sidsnooping.c index 33a573192d..fdcade96bc 100644 --- a/epan/dissectors/packet-smb-sidsnooping.c +++ b/epan/dissectors/packet-smb-sidsnooping.c @@ -28,6 +28,7 @@ #include #include #include +#include #include "packet-dcerpc.h" #include "packet-dcerpc-nt.h" #include "packet-smb.h" @@ -348,7 +349,7 @@ sid_snooping_init(void) disabling it now so that it won't cause wireshark to abort due to unknown hf fields */ -sid_name_snooping=0; +sid_name_snooping=FALSE; if(!sid_name_snooping){ return; @@ -380,7 +381,7 @@ sid_name_snooping=0; if(error_string){ /* error, we failed to attach to the tap. clean up */ - fprintf(stderr, "tshark: Couldn't register proto_reg_handoff_smb_sidsnooping()/lsa_policy_information tap: %s\n", + report_failure( "Couldn't register proto_reg_handoff_smb_sidsnooping()/lsa_policy_information tap: %s\n", error_string->str); g_string_free(error_string, TRUE); return; @@ -394,7 +395,7 @@ sid_name_snooping=0; if(error_string){ /* error, we failed to attach to the tap. clean up */ - fprintf(stderr, "tshark: Couldn't register proto_reg_handoff_smb_sidsnooping()/samr_query_dispinfo tap: %s\n", + report_failure( "Couldn't register proto_reg_handoff_smb_sidsnooping()/samr_query_dispinfo tap: %s\n", error_string->str); g_string_free(error_string, TRUE); return; -- cgit v1.2.3