From b38ee917b1953104c615056481d6df008ae94b53 Mon Sep 17 00:00:00 2001 From: Michael Mann Date: Sun, 15 Sep 2013 01:48:30 +0000 Subject: Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if hf_ field name is the first part of the formatted string. This was done with a perl script on the dissectors directory (packet-*.c), followed by manual inspection of the output. The manual inspection yielded a few cases that really should have been proto_tree_add_uint or proto_tree_add_item, so I updated them accordingly. The script didn't catch as many as I would have liked, but it's a start. The most common (ab)use of proto_tree_add_uint_format was for appending strings to CRC/checksum values to note good or bad CRC/checksum. svn path=/trunk/; revision=52045 --- epan/dissectors/packet-smb-logon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'epan/dissectors/packet-smb-logon.c') diff --git a/epan/dissectors/packet-smb-logon.c b/epan/dissectors/packet-smb-logon.c index 50c1df2982..9ef5441486 100644 --- a/epan/dissectors/packet-smb-logon.c +++ b/epan/dissectors/packet-smb-logon.c @@ -218,9 +218,9 @@ display_LMNT_token(tvbuff_t *tvb, int offset, proto_tree *tree) Token = tvb_get_letohs(tvb, offset); if (Token == 0xffff) { - proto_tree_add_uint_format(tree, hf_lmnt_token, tvb, offset, 2, + proto_tree_add_uint_format_value(tree, hf_lmnt_token, tvb, offset, 2, Token, - "LMNT Token: 0x%04x (Windows NT Networking)", Token); + "0x%04x (Windows NT Networking)", Token); } else { /* * XXX - what is it if it's not 0xffff? -- cgit v1.2.3