From 7e88a07e71abdbfd7299bec5be7a2f2b86c7391c Mon Sep 17 00:00:00 2001 From: Martin Mathieson Date: Wed, 22 Aug 2012 19:01:01 +0000 Subject: proto_item_append_string() doesn't work this case, so stop using it. I am tempted though to chage proto_item_append_string() just be like proto_item_append_text() without the call to g_vsnprintf(), which is the expensize part I was hoping to avoid. svn path=/trunk/; revision=44614 --- epan/dissectors/packet-rlc-lte.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'epan/dissectors/packet-rlc-lte.c') diff --git a/epan/dissectors/packet-rlc-lte.c b/epan/dissectors/packet-rlc-lte.c index ac98dcb3c0..4b7e9a2c08 100644 --- a/epan/dissectors/packet-rlc-lte.c +++ b/epan/dissectors/packet-rlc-lte.c @@ -613,9 +613,9 @@ static void write_pdu_label_and_info(proto_item *pdu_ti, proto_item *sub_ti, /* Add to indicated places */ col_append_str(pinfo->cinfo, COL_INFO, info_buffer); - proto_item_append_string(pdu_ti, info_buffer); + proto_item_append_text(pdu_ti, "%s", info_buffer); if (sub_ti != NULL) { - proto_item_append_string(sub_ti, info_buffer); + proto_item_append_text(sub_ti, "%s", info_buffer); } } @@ -931,7 +931,7 @@ static void addChannelSequenceInfo(sequence_analysis_report *p, ti = proto_tree_add_boolean(seqnum_tree, hf_rlc_lte_sequence_analysis_ok, tvb, 0, 0, TRUE); PROTO_ITEM_SET_GENERATED(ti); - proto_item_append_string(seqnum_ti, " - OK"); + proto_item_append_text(seqnum_ti, " - OK"); /* Link to next SN in channel (if known) */ if (p->nextFrameNum != 0) { @@ -1152,7 +1152,7 @@ static void addChannelSequenceInfo(sequence_analysis_report *p, ti = proto_tree_add_boolean(seqnum_tree, hf_rlc_lte_sequence_analysis_ok, tvb, 0, 0, TRUE); PROTO_ITEM_SET_GENERATED(ti); - proto_item_append_string(seqnum_ti, " - OK"); + proto_item_append_text(seqnum_ti, " - OK"); /* Link to next SN in channel (if known) */ if (p->nextFrameNum != 0) { @@ -2316,7 +2316,7 @@ static void dissect_rlc_lte_am(tvbuff_t *tvb, packet_info *pinfo, write_pdu_label_and_info(top_ti, NULL, pinfo, (polling) ? " (P) " : " "); if (polling) { - proto_item_append_string(am_header_ti, " (P) "); + proto_item_append_text(am_header_ti, " (P) "); } /* Framing Info */ -- cgit v1.2.3