From 689e8bd8559fec00503b4563af219c2c842101e3 Mon Sep 17 00:00:00 2001 From: Jeff Morriss Date: Sat, 15 Mar 2008 22:41:57 +0000 Subject: From http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1539 : Hexadecimal and octal are unsigned. Don't let dissectors register signed fields (FT_INT*) to be displayed in hexadecimal (including HEX_DEC and DEC_HEX) or octal. Fix dissectors that do that mostly by changing the fields to unsigned though in PANA it appears the fields are meant to be signed so change those fields to be displayed in decimal. This fixes an assertion crash in hfinfo_numeric_format() if/when someone tries to create a filter using one of these mixed signed/unsigned fields (because that routine does not know how to present the user with a signed value in hex). Also add FT_*INT64 to the "make sure it's not BASE_NONE" check. svn path=/trunk/; revision=24643 --- epan/dissectors/packet-pcnfsd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'epan/dissectors/packet-pcnfsd.c') diff --git a/epan/dissectors/packet-pcnfsd.c b/epan/dissectors/packet-pcnfsd.c index 5dc24022a9..d1962ec9b6 100644 --- a/epan/dissectors/packet-pcnfsd.c +++ b/epan/dissectors/packet-pcnfsd.c @@ -402,7 +402,7 @@ proto_register_pcnfsd(void) "Home Directory", "pcnfsd.homedir", FT_STRING, BASE_DEC, NULL, 0, "Home Directory", HFILL }}, { &hf_pcnfsd_def_umask, { - "def_umask", "pcnfsd.def_umask", FT_INT32, BASE_OCT, + "def_umask", "pcnfsd.def_umask", FT_UINT32, BASE_OCT, NULL, 0, "def_umask", HFILL }}, { &hf_pcnfsd_username, { "User name", "pcnfsd.username", FT_STRING, BASE_DEC, -- cgit v1.2.3