From 6a3762576b88e5ecbd1ce1019d40b96c6dd1da1d Mon Sep 17 00:00:00 2001 From: Guy Harris Date: Sun, 12 Feb 2017 01:50:28 -0800 Subject: Add a comment about wired-to-little-endian fields. Other fields in the Prism header are in the same byte order as the magic number; if the host generating those fields is big-endian, are these fields little-endian or big-endian? Change-Id: Ieb857db3ea63a673d9224cb2a7be3ff2bfb5861c Reviewed-on: https://code.wireshark.org/review/20065 Reviewed-by: Guy Harris --- epan/dissectors/packet-ieee80211-prism.c | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'epan/dissectors/packet-ieee80211-prism.c') diff --git a/epan/dissectors/packet-ieee80211-prism.c b/epan/dissectors/packet-ieee80211-prism.c index c32840bffb..e442a5f5fe 100644 --- a/epan/dissectors/packet-ieee80211-prism.c +++ b/epan/dissectors/packet-ieee80211-prism.c @@ -837,6 +837,10 @@ dissect_prism(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void* data _U case PRISM_TYPE1_RATE_SIG_A1: case PRISM_TYPE2_RATE_SIG_A1: + /* + * XXX - always little-endian, or same byte order as the + * rest of the Prism header? + */ rate_phy1 = tvb_get_letohl(tvb, offset); if (tree) { proto_tree_add_item(prism_did_tree, hf_ieee80211_prism_did_sig_a1, tvb, offset, 4, byte_order); @@ -846,6 +850,10 @@ dissect_prism(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void* data _U case PRISM_TYPE1_RATE_SIG_A2: case PRISM_TYPE2_RATE_SIG_A2: + /* + * XXX - always little-endian, or same byte order as the + * rest of the Prism header? + */ rate_phy2 = tvb_get_letohl(tvb, offset); if (tree) { proto_tree_add_item(prism_did_tree, hf_ieee80211_prism_did_sig_a2, tvb, offset, 4, byte_order); -- cgit v1.2.3