From 36ce5e1b900f9474f0de5218bae86a742521c8db Mon Sep 17 00:00:00 2001 From: Bill Meier Date: Thu, 18 Sep 2014 10:35:48 -0400 Subject: Fix encoding-arg mostly for FT_UINT_STRING; Also: Do misc as needed. Misc: (as needed) - Add editor modelines; - Adjust whitespace. Change-Id: I0e5d877a2a6273842ad8e771ac0c0acbfcb83200 Reviewed-on: https://code.wireshark.org/review/4173 Reviewed-by: Bill Meier --- epan/dissectors/packet-elcom.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'epan/dissectors/packet-elcom.c') diff --git a/epan/dissectors/packet-elcom.c b/epan/dissectors/packet-elcom.c index 7375a4a331..80aea12700 100644 --- a/epan/dissectors/packet-elcom.c +++ b/epan/dissectors/packet-elcom.c @@ -50,9 +50,11 @@ #define SUFFIX_LEN 2 #define TOTAL_LEN (LOWADR_LEN + SUFFIX_LEN + 2) +#if 0 /* ??? */ #define ELCOM_UNKNOWN_ENDIAN 0 #define ELCOM_LITTLE_ENDIAN 1 #define ELCOM_BIG_ENDIAN 2 +#endif void proto_register_elcom(void); void proto_reg_handoff_elcom(void); @@ -217,7 +219,8 @@ dissect_lower_address(proto_item *ti_arg, gint ett_arg, /* SUFFIX */ suffix = tvb_get_string_enc(wmem_packet_scope(), tvb, offset+1, len2, ENC_ASCII); - ti = proto_tree_add_item(tree, hf_suff, tvb, offset, 1, ENC_ASCII|ENC_LITTLE_ENDIAN); + /* hf_suff FIELDTYPE must be FT_UINT_STRING */ + ti = proto_tree_add_item(tree, hf_suff, tvb, offset, 1, ENC_ASCII|ENC_BIG_ENDIAN); offset += len2+1; if (!(suffix[0] == 'A' || suffix[0] == 'B')) { @@ -384,7 +387,7 @@ dissect_datarequest(proto_item *ti_arg, gint ett_arg, tvbuff_t *tvb, gint arg_of break; if (tvb_length_remaining(tvb, offset+oidlen+1) <= 0) return offset; - proto_tree_add_item(tree, hf_elcom_datarequest_oid, tvb, offset, 1, ENC_ASCII|ENC_NA); + proto_tree_add_item(tree, hf_elcom_datarequest_oid, tvb, offset, 1, ENC_ASCII|ENC_BIG_ENDIAN); offset += oidlen+1; } offset += 1; /* the loop exited at the 0 length byte */ -- cgit v1.2.3