From ddcb79687870a9fc25a4ba15a604966d5b9fe35f Mon Sep 17 00:00:00 2001 From: Alexis La Goutte Date: Thu, 1 Mar 2012 09:11:08 +0000 Subject: From Don Westman via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6889 CIP Motion parsing of set axis attribute list request is messing up attr data parsing a CIP Motion 'Set Axis Attribute List' Request returns correct data for attribute ID, dimension and element size but 'attribute data' field retrieves the same data for each attribute in the list rather than the real data sent in the request. From me : Fix the typo error (use the wrong offset variable, need to use local_offset variable) svn path=/trunk/; revision=41257 --- epan/dissectors/packet-cipmotion.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'epan/dissectors/packet-cipmotion.c') diff --git a/epan/dissectors/packet-cipmotion.c b/epan/dissectors/packet-cipmotion.c index 0f75b81780..ee547a4b81 100644 --- a/epan/dissectors/packet-cipmotion.c +++ b/epan/dissectors/packet-cipmotion.c @@ -1229,7 +1229,7 @@ dissect_set_axis_attr_list_request (tvbuff_t* tvb, proto_tree* tree, guint32 off } /* Display the value of this attribute */ - proto_tree_add_item(attr_tree, hf_cip_attribute_data, tvb, offset + attribute_start, attribute_size, ENC_NA); + proto_tree_add_item(attr_tree, hf_cip_attribute_data, tvb, local_offset + attribute_start, attribute_size, ENC_NA); /* Round the attribute size up so the next attribute lines up on a 32-bit boundary */ if (attribute_size % 4 != 0) -- cgit v1.2.3