From 68ba60774f8e055da60352cb710e02817546ca52 Mon Sep 17 00:00:00 2001 From: John Thacker Date: Tue, 30 Mar 2021 21:39:49 -0400 Subject: Prettify and standardize LAC, RAC, SAC, TAC in several ASN.1 dissectors The LAC, RAC, SAC, and TAC tend to be defined in ASN.1 as OCTET STRINGS of lengths 1, 2, or 3. It generally makes sense to dissect them as FT_UINT[8,16,24], as appropriate, with BASE_DEC_HEX instead of as FT_BYTES, so standardize on that. See commit d6f91a7ca421caa7787c1539bca61f943923fa9c for similar work for S1AP. --- epan/dissectors/asn1/gsm_map/gsm_map.cnf | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'epan/dissectors/asn1/gsm_map/gsm_map.cnf') diff --git a/epan/dissectors/asn1/gsm_map/gsm_map.cnf b/epan/dissectors/asn1/gsm_map/gsm_map.cnf index 654e229aa5..2064549460 100644 --- a/epan/dissectors/asn1/gsm_map/gsm_map.cnf +++ b/epan/dissectors/asn1/gsm_map/gsm_map.cnf @@ -1192,6 +1192,15 @@ MAP interfaces subtree = proto_item_add_subtree(actx->created_item, ett_gsm_map_GeodeticInformation); dissect_isup_calling_geodetic_location_parameter(parameter_tvb, actx->pinfo, subtree, NULL); +#.TYPE_ATTR +LAC TYPE = FT_UINT16 DISPLAY = BASE_DEC_HEX +#.FN_BODY LAC VAL_PTR = ¶meter_tvb HF_INDEX = -1 + tvbuff_t *parameter_tvb = NULL; +%(DEFAULT_BODY)s + if (parameter_tvb) { + actx->created_item = proto_tree_add_item(tree, hf_index, parameter_tvb, 0, 2, ENC_BIG_ENDIAN); + } + # Make dissector table for V3 messages #.REGISTER -- cgit v1.2.3