From d0a91b27f26762e9c998cc5e6fe71767de5d32c7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Valverde?= Date: Tue, 5 Sep 2017 17:18:00 +0100 Subject: plugins: config.h must not be included by public headers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit For a sane plugin build environment. Include config.h as the first header in the .c file instead. Fix by moving required compiler attribute macros to a new "ws_attributes.h" API header. Change-Id: I34f58a927f68c1a0e59686c14d214825149749e1 Reviewed-on: https://code.wireshark.org/review/23400 Petri-Dish: João Valverde Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde --- configure.ac | 16 ---------------- 1 file changed, 16 deletions(-) (limited to 'configure.ac') diff --git a/configure.ac b/configure.ac index a8a28ba7e5..738396899c 100644 --- a/configure.ac +++ b/configure.ac @@ -939,22 +939,6 @@ dnl build libwsutil_sse42 only if there is SSE4.2 AM_CONDITIONAL(SSE42_SUPPORTED, test "x$have_sse42" = "xyes") AC_SUBST(CFLAGS_SSE42) -# -# If we're running GCC or clang define _U_ to be "__attribute__((unused))" -# so we can use _U_ to flag unused function parameters and not get warnings -# about them. Otherwise, define _U_ to be an empty string so that _U_ used -# to flag an unused function parameters will compile with other compilers. -# -# XXX - similar hints for other compilers? -# -if test "x$GCC" = "xyes" -o "x$CC" = "xclang" ; then - AC_DEFINE(_U_, __attribute__((unused)), [Hint to the compiler that a function parameters is not used]) - AC_DEFINE(WS_NORETURN, __attribute((noreturn)), [Hint to the compiler that a function never returns]) -else - AC_DEFINE(_U_, , [Hint to the compiler that a function parameters is not used]) - AC_DEFINE(WS_NORETURN, , [Hint to the compiler that a function never returns]) -fi - # If we're running GCC or CLang, use FORTIFY_SOURCE=2 # (only if the GCC 'optimization level' > 0). # -- cgit v1.2.3