From 634c12c34c6a7f0700c8af26be3afe62801739b2 Mon Sep 17 00:00:00 2001 From: guy Date: Wed, 16 Dec 1998 09:05:51 +0000 Subject: Note that wiring the current longest string in a column into "get_column_width()" is somewhat fragile, and suggest a possible alternative. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@126 f5534014-38df-0310-8fa8-9805f1628bb7 --- column.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'column.c') diff --git a/column.c b/column.c index 1a67e1ec09..42f667e4fe 100644 --- a/column.c +++ b/column.c @@ -1,7 +1,7 @@ /* column.c * Routines for handling column preferences * - * $Id: column.c,v 1.3 1998/11/18 03:01:26 gerald Exp $ + * $Id: column.c,v 1.4 1998/12/16 09:05:51 guy Exp $ * * Ethereal - Network traffic analyzer * By Gerald Combs @@ -163,6 +163,10 @@ get_column_format_matches(gboolean *fmt_list, gint format) { } /* Returns the longest possible width for a particular column type */ +/* XXX - this is somewhat fragile; we should probably generate */ +/* the summary lines for all the packets first, and compute the */ +/* maximum column width as the maximum string width of all the */ +/* values in that column. */ gint get_column_width(gint format, GdkFont *font) { switch (format) { -- cgit v1.2.3