From eda357a25607d27fc27b7f9ee3f5d4ef546ce0ba Mon Sep 17 00:00:00 2001 From: cmaynard Date: Tue, 2 Aug 2011 01:54:03 +0000 Subject: From Paul Stath via bug 5731: The check for engineID length should only occur if the engineID has a non-zero length. Reference: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5731 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38303 f5534014-38df-0310-8fa8-9805f1628bb7 --- asn1/snmp/packet-snmp-template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'asn1') diff --git a/asn1/snmp/packet-snmp-template.c b/asn1/snmp/packet-snmp-template.c index 17b3fcffde..69d68df621 100644 --- a/asn1/snmp/packet-snmp-template.c +++ b/asn1/snmp/packet-snmp-template.c @@ -1962,7 +1962,7 @@ snmp_users_update_cb(void* p _U_, const char** err) snmp_ue_assoc_t* u = &(ueas[i]); /* RFC 3411 section 5 */ - if (u->engine.len < 5 || u->engine.len > 32) { + if ((u->engine.len > 0) && (u->engine.len < 5 || u->engine.len > 32)) { g_string_append_printf(es, "Invalid engineId length (%u). Must be between 5 and 32 (10 and 64 hex digits)\n", u->engine.len); } -- cgit v1.2.3