From f5e22a14877922aa7b907d2e434958c86efd6875 Mon Sep 17 00:00:00 2001 From: Peter Wu Date: Thu, 24 Nov 2016 00:27:14 +0100 Subject: codecs: Add support for G.722 and G.726 Integrate the Spandsp library for G.722 and G.726 support. Adds support for G.722 and all eight variants of G.726. Note: this also fixes a crash in Qt (buffer overrun, reading too much data) caused by confusion of the larger output buffer (resample_buff) with the smaller input buffer (decode_buff). It was not triggered before because the sample rate was always 8k, but with the addition of the new codecs, a different sample rate became possible (16k). Fix also a crash which occurs when the RTP_STREAM_DEBUG macro is enabled and the VOIP Calls dialog is opened (the begin frame, start_fd, is not yet known and therfore a NULL dereference could occur). Passes testing (plays normally without bad RTP timing errors) with SampleCaptures files: sip-rtp-g722.pcap and sip-rtp-g726.pcap. Tested with cmake (Qt), autotools (Qt and GTK+) with ASAN enabled. Bug: 5619 Change-Id: I5661908d193927bba50901079119eeff0c04991f Reviewed-on: https://code.wireshark.org/review/18939 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte Reviewed-by: Peter Wu --- CMakeOptions.txt | 1 + 1 file changed, 1 insertion(+) (limited to 'CMakeOptions.txt') diff --git a/CMakeOptions.txt b/CMakeOptions.txt index 41a8ab69cd..7c39b2884f 100644 --- a/CMakeOptions.txt +++ b/CMakeOptions.txt @@ -87,6 +87,7 @@ endif() # todo Mostly hardcoded option(ENABLE_KERBEROS "Build with Kerberos support" ON) option(ENABLE_SBC "Build with SBC Codec support in RTP Player" ON) +option(ENABLE_SPANDSP "Build with G.722/G.726 codecs support in RTP Player" ON) # How to install set(DUMPCAP_INSTALL_OPTION "normal" CACHE STRING "Permissions to install") set(DUMPCAP_INST_VALS "normal" "suid" "capabilities") -- cgit v1.2.3