From b665a515a8fd5c4e1773334086e23c083052be89 Mon Sep 17 00:00:00 2001 From: Stephen Fisher Date: Thu, 10 Dec 2009 22:35:09 +0000 Subject: Generated fields should not highlight any bytes in the packet bytes pane. This is especially true in this case because the indication that an arp packet is gratuitous is determined with the following code, which checks multiple fields: if (((ar_op == ARPOP_REQUEST) || (ar_op == ARPOP_REPLY)) && (memcmp(spa_val, tpa_val, ar_pln) == 0)) is_gratuitous = TRUE; else is_gratuitous = FALSE; svn path=/trunk/; revision=31229 --- epan/dissectors/packet-arp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/epan/dissectors/packet-arp.c b/epan/dissectors/packet-arp.c index 5723c1a51e..ea6579054e 100644 --- a/epan/dissectors/packet-arp.c +++ b/epan/dissectors/packet-arp.c @@ -1062,7 +1062,7 @@ dissect_arp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) proto_tree_add_uint(arp_tree, hf_arp_hard_size, tvb, AR_HLN, 1, ar_hln); proto_tree_add_uint(arp_tree, hf_arp_proto_size, tvb, AR_PLN, 1, ar_pln); proto_tree_add_uint(arp_tree, hf_arp_opcode, tvb, AR_OP, 2, ar_op); - item = proto_tree_add_boolean(arp_tree, hf_arp_isgratuitous, tvb, AR_OP, 2, is_gratuitous); + item = proto_tree_add_boolean(arp_tree, hf_arp_isgratuitous, tvb, 0, 0, is_gratuitous); PROTO_ITEM_SET_GENERATED(item); if (ar_hln != 0) { proto_tree_add_item(arp_tree, -- cgit v1.2.3