From 92a2c184b09ce41a1ab717963750bb5543099742 Mon Sep 17 00:00:00 2001 From: Guy Harris Date: Wed, 7 Dec 2016 22:50:49 +0000 Subject: Revert "Don't use a local variable's address in set_address()." This reverts commit e2c26ff90c6aee381c3af0c33253dcfa5631bb43. *That* address isn't attached to a pinfo structure, it's used to create a conversation, and a copy is made of it, using file scope. So that's not the cause of this problem. Change-Id: I07ce091e678c42c30080cd00fd17cd1584f473ad Reviewed-on: https://code.wireshark.org/review/19138 Reviewed-by: Guy Harris --- epan/dissectors/packet-infiniband.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/epan/dissectors/packet-infiniband.c b/epan/dissectors/packet-infiniband.c index ad501244f3..424b196b16 100644 --- a/epan/dissectors/packet-infiniband.c +++ b/epan/dissectors/packet-infiniband.c @@ -3005,7 +3005,7 @@ create_conv_and_add_proto_data(packet_info *pinfo, guint64 service_id, conversation_add_proto_data(conv, proto_infiniband, proto_data); /* next, register the conversation using the LIDs */ - set_address(addr, AT_IB, sizeof(guint16), wmem_memdup(pinfo->pool, &lid, sizeof lid)); + set_address(addr, AT_IB, sizeof(guint16), &lid); conv = conversation_new(pinfo->num, addr, addr, PT_IBQP, port, port, options); conversation_add_proto_data(conv, proto_infiniband, proto_data); -- cgit v1.2.3