From 260ef14e095f5120dabd93a2118d6b125ef10f05 Mon Sep 17 00:00:00 2001 From: Martin Kaiser Date: Tue, 17 May 2016 22:48:38 +0200 Subject: lbmc (CID 1201452): result of shift operation is always 0 apply a mask to get the lower 32 bit of a guint64 (there's no need for a right shift) Change-Id: Ia8c963dc0dd88f56c4ccaf0c37a1bd3d51d65d27 Reviewed-on: https://code.wireshark.org/review/15490 Reviewed-by: Michael Mann --- epan/dissectors/packet-lbmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/epan/dissectors/packet-lbmc.c b/epan/dissectors/packet-lbmc.c index b6db8ac1b2..e76fe2e7e7 100644 --- a/epan/dissectors/packet-lbmc.c +++ b/epan/dissectors/packet-lbmc.c @@ -6115,7 +6115,7 @@ static void lbmc_message_build_key(guint32 * key_value, wmem_tree_key_t * key, c guint32 val; key_value[LBMC_MESSAGE_KEY_ELEMENT_CHANNEL_HIGH] = (guint32) ((message->channel >> 32) & 0xffffffff); - key_value[LBMC_MESSAGE_KEY_ELEMENT_CHANNEL_LOW] = (guint32) ((message->channel & 0xffffffff) >> 32); + key_value[LBMC_MESSAGE_KEY_ELEMENT_CHANNEL_LOW] = (guint32) (message->channel & 0xffffffff); memcpy((void *) &val, (const void *) message->addr.data, sizeof(guint32)); key_value[LBMC_MESSAGE_KEY_ELEMENT_ADDR] = val; key_value[LBMC_MESSAGE_KEY_ELEMENT_PORT] = (guint32) message->port; -- cgit v1.2.3