aboutsummaryrefslogtreecommitdiffstats
path: root/wiretap
AgeCommit message (Collapse)AuthorFilesLines
2011-03-22Use the same style in netscreen_seek_read() that we use inGuy Harris1-1/+5
netscreen_read(), checking the return value of parse_netscreen_hex_dump() against -1 and explicitly returning FALSE if it's -1, otherwise driving on. svn path=/trunk/; revision=36237
2011-03-21Fix for bug 5762, wireshark asserts on reading juniper snoop output when no ↵Sake Blok1-1/+1
hex data is present (snoop detail off). svn path=/trunk/; revision=36232
2011-03-16Avoid having large buffers on the stack (as noted in VS Code Analyzer warnings).Martin Mathieson1-3/+3
svn path=/trunk/; revision=36202
2011-03-07From Martin Kaiser: dissector for DVB-CI (Common Interface)Bill Meier3-1/+7
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5654 From me: - Entry for DVBCI added to wtap.c encap_table_base[]; - Some code simplification with respect to the use of col_...() for COL_INFO; - Certain tests for "enough bytes available" not really needed; - (Other minor tweaks); - #include<stdio.h> not req'd; - Minor reformatting and whitespace cleanup; svn path=/trunk/; revision=36149
2011-02-25From Robert Bullen: ... code is not incrementing wtap_dumper.bytes_dumped.Bill Meier1-0/+6
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5666 Fro me: use 4 -space indentation (not tab) to match surrounding code lines. svn path=/trunk/; revision=36074
2011-02-25From Robert Bullen: Fix "Potential access violation when writing to ↵Bill Meier1-1/+13
LANalyzer files" https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5698 (Note from me: Before the fix "File ! Save As" in Lanalyzer format crashed quite consistently on my Windows 7) svn path=/trunk/; revision=36061
2011-02-25Revert SVN #36059; patch from Bug #5698 to be used insteadBill Meier1-2/+1
svn path=/trunk/; revision=36060
2011-02-25Fix Bug #5698: "Potential access violation when writing to LANalyzer files"Bill Meier1-1/+2
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5698 Note: before fix File ! SaveAs in Lanalyzer format crashed quite consistently on Windows. svn path=/trunk/; revision=36059
2011-02-16Return an error value for the new error return; it "can't happen" (butGuy Harris1-1/+7
either the VC++ analyzer can't determine that or it *can*, in fact, happen). Pick an error code that's not too far off. svn path=/trunk/; revision=35957
2011-02-16Check the index before storing into the array.Guy Harris1-1/+1
svn path=/trunk/; revision=35956
2011-02-16Fix checkapi.Gerald Combs1-64/+64
svn path=/trunk/; revision=35955
2011-02-16Fix errors found by the Visual C++ analyzer.Gerald Combs9-10/+13
svn path=/trunk/; revision=35954
2011-02-16Fix a buffer overflow found by the Visual C++ analyzer.Gerald Combs1-0/+7
svn path=/trunk/; revision=35953
2011-02-12The lack of _WITH_PHDR in WTAP_ENCAP_BLUETOOTH_H4 means there's noGuy Harris2-4/+4
pseudo-header, and hence there's no direction indication. Don't set pinfo->p2p_dir for it. Use WTAP_ENCAP_BLUETOOTH_H4_WITH_PHDR, not WTAP_ENCAP_BLUETOOTH_H4, for capture files where we have the direction. Don't assume pinfo->p2p_dir is either P2P_DIR_SENT or P2P_DIR_RECV when setting the info column in various Bluetooth dissectors; it might be unknown. In the HCI H4 dissector, put the direction into the info column regardless of whether we have a type match or not; the dissectors for HCI packet types appear to assume it's been set (as they put a blank at the beginning of the stuff they append to the direction). svn path=/trunk/; revision=35933
2011-02-10Add some information based on a Tektronix manual whose name popped up inGuy Harris1-2/+57
an email I found when looking for some other stuff and which I then found with a Google search. svn path=/trunk/; revision=35898
2011-02-07Check for a large packet_len. Fixes a bug reported by HuzaifaGerald Combs1-0/+12
Sidhpurwala of the Red Hat Security Response Team. See also: bug 5661. svn path=/trunk/; revision=35855
2011-02-04Set the error code and additional information string in more cases.Guy Harris1-27/+70
svn path=/trunk/; revision=35809
2011-02-04Set *err before *err_info - that's how it's done in most other modules.Guy Harris1-4/+4
svn path=/trunk/; revision=35807
2011-02-04Set *err before *err_info - that's how it's done in most other modules.Guy Harris1-1/+1
svn path=/trunk/; revision=35806
2011-02-04Set *err before *err_info - that's how it's done in most other modules.Guy Harris1-1/+1
svn path=/trunk/; revision=35805
2011-02-04Fix indentation.Guy Harris1-1/+1
svn path=/trunk/; revision=35804
2011-02-04Put more data into the "additional error information" messages.Guy Harris1-11/+8
Get rid of debugging printouts that are equivalent to the "additional error information" messages. Return additional error info for all WTAP_ERR_BAD_RECORD errors. svn path=/trunk/; revision=35800
2011-02-04(As in the Windows builds) don't have checkapi check the 'abort' group in ↵Jeff Morriss1-1/+3
wiretap. svn path=/trunk/; revision=35797
2011-02-04Use g_strdup() instead of strdup()Jeff Morriss1-37/+37
svn path=/trunk/; revision=35796
2011-02-03From Huzaifa Sidhpurwala of the Red Hat Security Response Team: Don'tGerald Combs1-0/+2
free uninitialized memory. See also: bug 5652. svn path=/trunk/; revision=35791
2011-02-02From njohnkev:Jaap Keuter3-1/+8
Add support for LAPD data link type. svn path=/trunk/; revision=35771
2011-02-02A bit of Windows makefiles rework and cleanup:Bill Meier1-5/+6
- Define macros for certain CFLAGS in config.nmake iso of having defs in each makefile; a. -DHAVE_CONFIG_H and -D_U_="" are now part of a macro named STANDARD_CFLAGS; b. -WX has been replaced by WARNINGS_ARE_ERRORS (defined as -WX in config.nmake) (This allows disabling "Warnings as Errors" by just changing config.nmake) c. CVARSDLL definitions (not usage) have been removed from the various makefiles. XXX: It appears the usage of CVARSDLL can also be removed (not yet done) since: -DWIN32 and -DNULL=0 do not appear to be needed (any more); -D_MT and _D_DLL are not needed since /MP causes these definitions. d. Define a macro WARNINGS_CFLAGS with additional specific compiler (level4) warnings to be enabled. E.G., 4295: array is too small to include a terminating null character - config.nmake: reformat some long lines for readability; - plugins\Makefile.nmake: clean-deps does nothing: remove it (and usage in top-level makefile); - dissectors/Makefile.nmake: test to enable packet-rrc.obj target needs to include MSVC2010 ... svn path=/trunk/; revision=35747
2011-01-31Return a string (even though abort is called first) to pacify gcc.Martin Mathieson1-0/+1
svn path=/trunk/; revision=35724
2011-01-30Fix various instances of "unreachable code".Bill Meier2-2/+2
svn path=/trunk/; revision=35713
2011-01-20Fix the dead initialization warnings found by clang's static analysisStephen Fisher1-1/+1
("Value stored to 'xxx' during its initialization is never read") svn path=/trunk/; revision=35598
2011-01-05Support FP_R8 over ATM, plus a couple of other tidying-ups.Martin Mathieson1-8/+7
svn path=/trunk/; revision=35373
2011-01-03We must always return an error code on an error; otherwise, our callerGuy Harris1-3/+16
will see random crap as the error code. However, if we're skipping a "TCPIPTRACE-W-BUFFERSFUL" error, if the "error" we get is an end-of-file indication, that's *not* an error. It is, however, ultimately a "we dropped some packets" indication; add a comment noting that we should eventually treat it as such. svn path=/trunk/; revision=35337
2010-12-28It is not guaranteed that the records in numerical (frame table) orderGuy Harris1-7/+5
will be in sequential (byte offset) order in the file; don't treat the record offset going backwards as an error. svn path=/trunk/; revision=35291
2010-12-20Fix bug #5509: CommView file format now uses reserved bytes and adds a Stephen Fisher1-14/+16
new use for the direction field per: http://www.tamos.com/htmlhelp/commview/logformat.htm Add basic support for new fields and don't reject files that fit the new format. svn path=/trunk/; revision=35234
2010-12-19Prepare for handling DLT_IPV4 and DLT_IPV6.Jaap Keuter3-2/+14
svn path=/trunk/; revision=35223
2010-12-07Fill out libwiretap's DEPENDENCIES line with the rest of the dependencies ↵Jeff Morriss1-2/+1
(from LIBADD). svn path=/trunk/; revision=35146
2010-12-07Make libtool export only symbols listed in *.def filesBalint Reczey1-1/+4
svn path=/trunk/; revision=35145
2010-11-29Fix typos.Chris Maynard1-2/+2
svn path=/trunk/; revision=35063
2010-11-24Add support for USB isochronous. From Marton Nemeth via bug #5370.Chris Maynard1-11/+73
svn path=/trunk/; revision=35025
2010-11-13Try to fix the build for text_import_scanner.Anders Broman1-0/+1
Please check if the compile flags are OK... 3:d time lucky ? svn path=/trunk/; revision=34862
2010-11-05From Robert Bullen:Anders Broman1-39/+60
Network Instruments' trace files sometimes cannot be read with an error message of "Observer: bad record: Invalid magic number" https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5330 svn path=/trunk/; revision=34783
2010-11-04From Alexis La Goutte:Jaap Keuter2-9/+2
Replace all *_min()/*_max() by MIN() and MAX(). svn path=/trunk/; revision=34770
2010-10-28From Stephen Donnelly:Anders Broman1-7/+11
Wireshark tools do not detect and read some ERF files correctly https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5344 svn path=/trunk/; revision=34665
2010-10-21Fix a cut-n-pasteo in a comment.Jeff Morriss1-1/+1
svn path=/trunk/; revision=34603
2010-10-20From Jeff Morriss: Fix crash: WTAP_ERR_BAD_RECORD error return needs to fill ↵Bill Meier2-8/+15
in *err_info. From me: For ipfix_open() don't actually return with *err=WTAP_ERR_BAD_RECORD. Also: Move #define RECORDS_FOR_IPFIX_CHECK to ipfix.c from ipfix.h since the definition is only used in ipfix.c. svn path=/trunk/; revision=34589
2010-10-20Fix bug which caused ascend_open() to return "I/O error" (instead of "not me").Bill Meier1-0/+1
(This happened if ascend_open was called with *err != 0). svn path=/trunk/; revision=34588
2010-10-20Fix a typo in a commentBill Meier1-1/+1
svn path=/trunk/; revision=34586
2010-10-20From Hadriel Kaplan: Update wiretap/README.developerBill Meier1-1/+7
svn path=/trunk/; revision=34578
2010-10-20From Hadriel Kaplan: IPFIX file format support.Bill Meier8-9/+378
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5242 svn path=/trunk/; revision=34576
2010-10-02Make it a bit clearer what's going on - ASCII '0' has the decimal valueGuy Harris1-1/+1
48, and that's converting '0'-'9' to 0-9. svn path=/trunk/; revision=34326