aboutsummaryrefslogtreecommitdiffstats
path: root/ui
AgeCommit message (Collapse)AuthorFilesLines
2019-11-09CID: Fix 1455321 null-referencePascal Quantin1-1/+1
Fix a null dereference in DisplayFilterEdit Change-Id: I407e3d667ec8684312ba8fbcb0cc49130b9417df Reviewed-on: https://code.wireshark.org/review/35025 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org> Reviewed-on: https://code.wireshark.org/review/35033 Petri-Dish: Roland Knall <rknall@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-07Qt: Fix loading of FilterExpression DialogRoland Knall1-1/+3
Fix the loading of the FilterExpression Dialog Change-Id: I553707df01932f06c50a3326e422fa0a3787de01 Reviewed-on: https://code.wireshark.org/review/35023 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-07Qt: Move Signal/Slots to DisplayFilterEditRoland Knall3-11/+9
Move the handling of Signal/Slots for the display filters to the LineEdit class, instead of having it being handled in the mainwindow Change-Id: Ibddea7d31b6d0abec91baa46ffb6965f64db94d6 Reviewed-on: https://code.wireshark.org/review/35012 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-07Qt: Move Signals/Slots to subclassRoland Knall3-7/+20
Signals/Slots should be initialized by the utilizing class not the parent class. That way the utilizing class can be changed without interfering with the parent Change-Id: I5d538b4c487d3092f0f76bc2b54bc63fbc3ba547 Reviewed-on: https://code.wireshark.org/review/35015 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-07Qt: Fix order of contextmenu for DisplayFilterRoland Knall1-3/+4
Put the DisplayFilter Context Menu in the correct order and fix a null-assignement issue Change-Id: If39c7a7ebe9bab0c6cfb790cc255d369a0055cb3 Reviewed-on: https://code.wireshark.org/review/35014 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-07Qt: Keep extcap control channels when capturing to multiple filesStig Bjørlykke4-12/+19
When using the "Create a new file automatically" feature the capture in Wireshark will stop and start, but the extcap utility will continue run as normal. Ensure the control channels are kept when doing this. Rename the unused capture_session.session_started to session_will_restart to detect this. Bug: 16178 Change-Id: I6797c982760a1013fca2a24699befff1dc82f28c Reviewed-on: https://code.wireshark.org/review/35013 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-06Qt: Ensure only valid input for DisplayFilterRoland Knall3-16/+32
Allow only valid inputs to be given for the name of a DisplayFilter. Specifically adding a quotation mark is not allowed Change-Id: I10454a2d23db1e0ef08148571d2762a3285e5ab8 Reviewed-on: https://code.wireshark.org/review/35006 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-06Qt: fix compilation with older versions.Dario Lombardo1-2/+2
Fix travis linux builds. ../ui/qt/widgets/display_filter_edit.cpp:130:56: error: no matching function for call to ‘QAction::QAction(QString)’ QAction * na = new QAction(tr("Left align buttons")); ^ In file included from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qactiongroup.h:37, from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/QActionGroup:1, from ../ui/qt/widgets/display_filter_edit.h:14, from ../ui/qt/widgets/display_filter_edit.cpp:20: /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qaction.h:174:5: note: candidate: ‘QAction::QAction(QActionPrivate&, QObject*)’ QAction(QActionPrivate &dd, QObject *parent); ^~~~~~~ Change-Id: I03be478bc17296cc6adca6df82cdd41bcc0504b4 Reviewed-on: https://code.wireshark.org/review/34995 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-06Qt: Better align DisplayFilterEdit buttonsRoland Knall4-54/+95
Better aling buttons in the DisplayFilterEdit and make loading less artifact-prone Change-Id: Ic5a5b0214185ed193e4b2290295225f54842c632 Reviewed-on: https://code.wireshark.org/review/35000 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-06Document long command line options.Dario Lombardo1-6/+13
Bug: 16168 Change-Id: Ifdfa9092b632171c461430bc3e9de32ec1ed46f4 Reviewed-on: https://code.wireshark.org/review/34996 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-11-05QT/CLI: Remove limit for object export filesUli Heilmeier2-4/+6
Removes the limit to export more than 1000 files with the same name when exporting objects. For this a preference name gui.max_export_objects is used. Bug: 16010 Change-Id: Iefc138ac2617491aad3b6ad5827c9058aed112c7 Reviewed-on: https://code.wireshark.org/review/34339 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-05Qt: Fix CPU usage for DisplayFilterEditRoland Knall1-2/+0
Fix CPU usage by removing unused function, which lead to a loop of paintEvents for the DisplayFilterEdit Change-Id: Ib325a16fa2d90d668e21917bc07e806d11d1fbf9 Reviewed-on: https://code.wireshark.org/review/34993 Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-05extcap: Allow loading of extcap files from personal directoryRoland Knall1-4/+2
Allow the storage of extcap plugins in the personal directory and enable loading from there. It will also take precedence of any system-wide extcaps with an identical name Change-Id: Ib88e09a26c4f99cf5e793327f2808c7445c6b1b5 Reviewed-on: https://code.wireshark.org/review/34988 Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-05Qt: Allow action buttons to be left-alignedRoland Knall4-84/+139
Buttons can be left-aligned in the display filter edit bar, by selecting the corresponding option from the context menu Bug: 14123 Change-Id: I18b48bb0ea43a598b2e309dcad9210463be06414 Reviewed-on: https://code.wireshark.org/review/34980 Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-05Qt: IOGraph display filter graph addedRoland Knall3-3/+17
Add a graph for the currently display filter if none exists, upon opening IOGraph Change-Id: Ic25b014484898dd1917b13f2616fd519e2e8183b Reviewed-on: https://code.wireshark.org/review/34984 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-05funnel: Free callback dataStig Bjørlykke3-9/+28
Free allocated callback data in FunnelStringDialog, TextWindow and registered menu items. Also free strings used in FunnelStringDialog. Bug: 16177 Change-Id: I9a129b8975a55d1dc89fe851116feebe82763bca Reviewed-on: https://code.wireshark.org/review/34945 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-11-05Qt: Use g_new0 to allocate fmt_dataStig Bjørlykke1-1/+1
The column fmt_data will be g_free()'d later so ensure this is allocated using g_new0(). Change-Id: I31abe4ea16004e7972a59b4fff965460fa930800 Reviewed-on: https://code.wireshark.org/review/34981 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-11-05RTP: rtp_audio_stream.cpp: fixed excess silence in visualisation on waveformJirka Novak2-3/+5
When silence is inserted to waveform (VaD, no RTP, ...), waveform is shifted to correct time in visualisation. Code was inserting silence to audio waveform too therefore following audio was shifted twice. This patch fixes it. Change-Id: I4f3e02328662f92b1dabec80ce9da31d0a839046 Reviewed-on: https://code.wireshark.org/review/34917 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-11-05Qt: Load filenames properlyRoland Knall1-10/+11
Use a more stable approach for checking the file and avoid having QFile reset with the filename. It is ok due to the fact, that it is not opened, but is frowned upon in the documentation. This only sets the filename once. Change-Id: Ibe13eaf5938e060d7c39655591af34ac44340f49 Reviewed-on: https://code.wireshark.org/review/34965 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-05Qt: Fix memory leaks in FilterListModel::reload()Stig Bjørlykke1-3/+3
This fixes up to 6 string leaks in FilterListModel::reload(). 1. The char pointer returned from get_persconffile_path() and get_datafile_path() is allocated and must be free'd by the caller. 2. QFile.setFileName() takes a QString() so don't strdup() the name given because that will leak as well. Change-Id: I580020a5ff37a9b2b8ae16179ac6d7ba4a0f16da Reviewed-on: https://code.wireshark.org/review/34964 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-04Qt: Remove some extraneous qDebug()s.Gerald Combs1-3/+0
Change-Id: Id9c7786304c24048422a0855cca3a8bca5b9918b Reviewed-on: https://code.wireshark.org/review/34963 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-11-04Show correct format of --display command line parameterJaap Keuter1-1/+1
The --display command line parameter must not have an equal sign between it and the value in order to work. Otherwise it is interpreted as a abbreviation of the display-filter long option. Bug: 16167 Change-Id: Ifcdd4cb8c41b24faccf01936a019a318fb1c3e0c Reviewed-on: https://code.wireshark.org/review/34961 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-11-04Qt: Move CaptureEdit to FilterListModelRoland Knall3-43/+53
Move CaptureFilterEdit to FilterListModel and do cleanup Change-Id: I9fdd37fda5698a3389f9bc4e550f2e56077675ec Reviewed-on: https://code.wireshark.org/review/34959 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-04Qt: Fix various issues with the bookmark menuRoland Knall3-44/+55
Odering differed from the manage filter expression. Also, managing filter expressions is called "Filter Button Preferences.." throughout other functions. And finally it did not properly update the information about the selected filter, if a new filter was saved or an existing filter removed. Change-Id: I005028cd0b741587f4c5f2f39612e36d5d7d6c25 Reviewed-on: https://code.wireshark.org/review/34958 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-04Qt: Hide Searchbar if the icon is activated againRoland Knall1-0/+2
Change-Id: Ic478cc29ac1e0685737580da7110ec9f5d06d313 Reviewed-on: https://code.wireshark.org/review/34950 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-04Qt: Coloringrules Mime is encoded as JSONRoland Knall1-25/+43
Encode coloring rules as json objects to avoid encoding issues Change-Id: I4b5369fef3c0f9e73cbb08edf14de6535ff35026 Reviewed-on: https://code.wireshark.org/review/34947 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-04Qt: Remove DisplayFilterMimeDataRoland Knall7-103/+90
Make the mimetype for the display filter more generic, so that external programs can attach to Wireshark and users can drag and drop display filters to the program Change-Id: Id78b4dff7883e3dab879a31aad07f577d8cc4ee3 Reviewed-on: https://code.wireshark.org/review/34936 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-11-04epan: Rename dissector_filters.c to conversation_filter.cStig Bjørlykke3-3/+3
For the same reason as in g89c9d909. Change-Id: I5e344ebdf8ba05d169484aa32b409d84edc6124f Reviewed-on: https://code.wireshark.org/review/34943 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-11-03Qt: Print qDebug messages by default.Gerald Combs1-3/+4
We handle Qt and GLib logging in the same handler, which means that if we map qDebug messages to G_LOG_LEVEL_DEBUG they won't be printed by default. This can make debugging the UI more confusing, since sprinkling in qDebug()s is a common Qt debugging method. If you're focused on fixing a bug it's easy to forget that you need to use qWarning() or change the logging level preference instead. Set the log level for qDebug messages to G_LOG_LEVEL_WARNING so that they show up. Change-Id: I4336b001cb667a31bf8b25306cd34e758cc8967e Reviewed-on: https://code.wireshark.org/review/34937 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-03Qt: Fix Filter drag and dropRoland Knall1-1/+0
Fix dragging and dropping of filter texts Change-Id: I14a36051846b5cd8eb5ac466aed4e93710c5b5f8 Reviewed-on: https://code.wireshark.org/review/34935 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-03Qt: Consolidate mimedata usageRoland Knall6-23/+30
Ensure, that all mimedata uses similar mimetypes and document the mimetypes being used throughout wireshark Change-Id: I7c02d0a5e12a823153640e600051abb95d58cdeb Reviewed-on: https://code.wireshark.org/review/34923 Petri-Dish: Roland Knall <rknall@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-03rtp_analysis_dialog.cpp: Correct src/dst info for two independent streamsJirka Novak1-2/+8
Display the source and destination for the second reverse stream in case it differs from the first forward stream. Change-Id: I117899acca47713a42efcfef28f893d9be26c337 Reviewed-on: https://code.wireshark.org/review/34915 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-11-03Qt: Filter list model filter selection (CID 1455165)Jaap Keuter1-3/+3
The code as it stands seems to work for a single type of filter type only. When making choice on filter type, reference the type set in the object. Change-Id: I5f4181372db6045e17ba1519828346f098dce8d3 Reviewed-on: https://code.wireshark.org/review/34916 Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-03rtp_analysis_dialog: save as au: fix for streams with multiple codecsJirka Novak3-4/+35
When the stream contains a mix of G.711A/U and silence, the RTP Analysis dialog prevented it from being saved. Add an exception for silence to fix this. Change-Id: I46bb1392244ff0ba300c371fb5ccd110fbd59a7e Reviewed-on: https://code.wireshark.org/review/34901 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-11-03[Automatic update for 2019-11-03]Gerald Combs10-318/+296
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I9f952c8328afc2ebe99ffd56741667da7ef3a707 Reviewed-on: https://code.wireshark.org/review/34918 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-11-02filter_list_model (Qt): Fix Dead StoreAlexis La Goutte1-2/+0
Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: If2050d2e0137afcadc382b12c0756bd49dfc0f7c Reviewed-on: https://code.wireshark.org/review/34904 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-10-31Correct JPEG file saving for french languageEugene Adell1-1/+1
Bug: 16165 Change-Id: I555cd7fc4265ad8f8766f5e3b0d99b9e2e5b93b9 Reviewed-on: https://code.wireshark.org/review/34897 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-10-29Qt: Fix override for FilterModelRoland Knall1-3/+3
Change-Id: I73428fe09c36dd53bc24f99d893404a7cac10175 Reviewed-on: https://code.wireshark.org/review/34886 Reviewed-by: Roland Knall <rknall@gmail.com>
2019-10-29Qt: Allow drag/drop of filter buttons in dialogRoland Knall5-13/+79
Allow the drag/drop of filter buttons in the dialog Change-Id: Ie2d5987ecdb626a8f12e8f17e6967f937bdf4648 Reviewed-on: https://code.wireshark.org/review/34885 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-10-28Qt: Filter enabled/disabled protocolsRoland Knall3-15/+12
Allow for filtering of enabled/disabled protocols in the EnabledProtocols dialog Change-Id: Ib9a8bbe2a23fdcd3ecd2b9ca08de17f77e85049c Reviewed-on: https://code.wireshark.org/review/34878 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-10-28Qt: Fix macos buildbotRoland Knall1-1/+1
Change-Id: I5b6f11b3a5736b50c6928081df16f6bdb5125ea8 Reviewed-on: https://code.wireshark.org/review/34881 Petri-Dish: Roland Knall <rknall@gmail.com> Reviewed-by: Vasil Velichkov <vvvelichkov@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com>
2019-10-28Qt: Speed up filtering in VoIP dialogRoland Knall1-4/+10
Speed up the filtering, by only taking rows once Change-Id: I6123b2974fd58480463e4a0bd02524f6b5c0a353 Reviewed-on: https://code.wireshark.org/review/34879 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-10-28Qt: Implement FilterListModelRoland Knall6-129/+431
Change-Id: I365281a709ded644fc8d6ccfce5870a000221a3b Reviewed-on: https://code.wireshark.org/review/34856 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-10-28Qt: Add Shortcut methods for active profileRoland Knall2-0/+16
Change-Id: Ied32cf386074b97cfea38ffe6b8be6b916164712 Reviewed-on: https://code.wireshark.org/review/34873 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-10-27Qt: Respect saved extcap multiselect configurationTomasz Moń1-5/+7
Do not reset multiselect configuration to defaults on every extcap configuration window open. Change-Id: I04036ad6723f66c2ac036aae5bf70ded5029a66b Reviewed-on: https://code.wireshark.org/review/34864 Petri-Dish: Tomasz Moń <desowin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-10-27[Automatic update for 2019-10-27]Gerald Combs10-61/+459
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ic8bc6882d217da5f04e7e3ef1e58c3f16ca23fd3 Reviewed-on: https://code.wireshark.org/review/34861 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-10-25Qt: Move Filterbuttons to display filterRoland Knall7-11/+65
Allow filterbuttons to be dragged to the display filter bar Change-Id: I25e87d0ca86fc7437a20994800bec164ccffef27 Reviewed-on: https://code.wireshark.org/review/34838 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-25Qt: Simplify displayfilter handlingRoland Knall1-6/+3
Change-Id: Ide96262668ad99608feddfbcc854664d729d09d0 Reviewed-on: https://code.wireshark.org/review/34854 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-25FilterFiles: Remove GTK+-only filter listsRoland Knall2-75/+1
Those are no longer needed by the GUI Change-Id: I5eb12c2ebe84885ddba510b9d2b49679a292e7f0 Reviewed-on: https://code.wireshark.org/review/34855 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-22Qt: Move reset to contextmenuRoland Knall3-13/+15
Forego of the button and move the reset functionality to a context menu Change-Id: Ib23029586c69c8f3cd7c989c8b7c1f09be219bb1 Reviewed-on: https://code.wireshark.org/review/34827 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Roland Knall <rknall@gmail.com>