aboutsummaryrefslogtreecommitdiffstats
path: root/ui
AgeCommit message (Collapse)AuthorFilesLines
2018-11-25[Automatic update for 2018-11-25]Gerald Combs6-104/+0
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I4dbb483a58c10480b30da38ba234707344671222 Reviewed-on: https://code.wireshark.org/review/30785 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-11-22addr_resolv: avoid unnecessary memory allocation for hash tablesPeter Wu1-5/+5
The key for the manuf table is 24 bits of the ether addr while the key for services table needs is a 16 bit port. Store this value directly, saving some memory and improving startup time by a tiny bit. Likewise for ipxnet_hash_table and vlan_hash_table. These tables seem unused though, perhaps it should be removed. Change-Id: Ide9ffad8e2c9af24afa82adb2e009f32a5f43d38 Reviewed-on: https://code.wireshark.org/review/30756 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-11-20Remove more hardcoding of ".gz" as the suffix for compressed files.Guy Harris1-9/+45
Use the libwiretap APIs to get lists of all compressed file suffixes or to get the compressed file suffix for a given compression type. (The net effect is the same, as the only compression type supported is gzip, but if any compression types are added in the future, that code won't need to be changed.) Change-Id: I7de3b764604d50c4c60b6f20dd16ee87fc00e5b2 Reviewed-on: https://code.wireshark.org/review/30734 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-11-20Add an API to get a list of compressed-file extensions, and use it.Guy Harris1-4/+4
Move all the compressed-file type stuff to wiretap/file_wrappers.c. Rename wtap_compressed_file_extension() to wtap_compression_type_extension() for consistency with the other compression-type-extension routine names. Move the declarations of the compression-type-extension routines in the header file. wtap_compression_type_extension() now returns NULL for WTAP_UNCOMPRESSED; there's no need to special-case it. Get rid of the now-unused wtap_compression_type_supported() and WTAP_NUM_COMPRESSION_TYPES. Change-Id: Ib93874079bea669a0c87104513dba0d21390455a Reviewed-on: https://code.wireshark.org/review/30729 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-11-19Fix a comment to reflect reality.Guy Harris1-1/+2
Change-Id: I789b3993dbf07805bed2f8cde70b3ded4b5bc9f9 Reviewed-on: https://code.wireshark.org/review/30727 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-11-19Ensure that fixFilenameExtension() is used only when writing a file.Guy Harris1-6/+16
It *should* never happen, but just make sure of that by calling it only for "open for writing" ("save") dialogs. Change-Id: I1813f31537c0aa4efdf08c1622db9cb9e7f5ae83 Reviewed-on: https://code.wireshark.org/review/30726 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-11-18Add an API to get the file extension for a compression type, and use it.Guy Harris1-1/+1
Add wtap_compressed_file_extension(), which returns NULL for WTAP_UNCOMPRESSED and the appropriate file extension for other compression types. Add wtap_compression_type_supported(), which returns TRUE for WTAP_UNCOMPRESSED and all supported compression types and FALSE otherwise. ("Supported" means "the code can decompmress files in that compression format and can write files in that compression format", so WTAP_GAIP_COMPRESSED is supported iff libwiretap is built with zlib.) In MainWindow::fileAddExtension, instead of checking for WTAP_GZIP_COMPRESSED and using ".gz" as the extension, use the extension returned by wtap_compressed_file_extension() for the compression type. Change-Id: I47cb0eca8c887ada3562df30b54e76509008180f Reviewed-on: https://code.wireshark.org/review/30707 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-11-18[Automatic update for 2018-11-18]Gerald Combs7-56/+90
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I896204ae8c6e8ca23e75ff9202ff4bc344d023f8 Reviewed-on: https://code.wireshark.org/review/30686 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-11-18Clean up previous change.Guy Harris1-2/+2
compressed_file_extension shouldn't include the ".", as we insert the "." before it. Use it when appending the extension, rather than hardwiring "gz" in two places. Change-Id: I89e3ed1df9a8457fdbb6e6386686176816f4671b Reviewed-on: https://code.wireshark.org/review/30682 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-11-18Fix addition of extensions to file names.Guy Harris1-24/+71
If the file is to be compressed, then: if the type in which the file is to be written has a set of extensions it uses, leave the file name alone if it ends with one of those extensions followed by the extension for the compression type, otherwise append the default extension for that file type followed by the extension for the compression type; if it doesn't, leave the file name alone if it ends with the extension for the compression type, otherwise append the extension for the compression type; otherwise: if the type in which the file is to be written has a set of extensions it uses, leave the file name alone if it ends with one of those extensions, otherwise append the default extension for that file type followed by the extension for the compression type; if it doesn't, leave the file name alone if it ends with the extension for the compression type, otherwise append the extension for the compression type. Change-Id: I7c4093af28cc30d579a2ae9faa8f4164b4764001 Reviewed-on: https://code.wireshark.org/review/30681 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-11-17Qt: fix build failure due to adding two incompatible pointersPeter Wu1-2/+2
Change-Id: I08d45c87c9232edcabfc69d25a773552fe9e0871 Fixes: v2.9.0rc0-2567-g43872a3a0e (""." in version numbers and file names isn't translated into other languages.") Reviewed-on: https://code.wireshark.org/review/30680 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-11-17"." in version numbers and file names isn't translated into other languages.Guy Harris2-3/+3
"xxx.pcap.gz" is "xxx.pcap.gz" in any language. "3.0.1" is "3.0.1" in any language. Change-Id: I231a3f9bd21a3ea5d56a8e410d20b1bc3927540f Reviewed-on: https://code.wireshark.org/review/30676 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-11-16Qt: fix build with Qt 5.4 and olderPeter Wu3-3/+3
Change-Id: Iabdd87128a2af8c668c0602ea677f71984e64723 Fixes: v2.9.0rc0-2556-gb894c53d5e ("Add an API to get a description of a compression type, and use it.") Reviewed-on: https://code.wireshark.org/review/30670 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-11-16Add an API to get a description of a compression type, and use it.Guy Harris10-90/+9
Add wtap_compression_type_description(), which returns NULL for WTAP_UNCOMPRESSED and a descriptive string for other compression types. Instead of checking for WTAP_GZIP_COMPRESSED and appending "(gzip compressed)", just pass the compression type to wtap_compression_type_description() and, if the result is non-null, append its result, wrapped in parentheses, with a space before the left parenthesis. Change-Id: I79a999c7838a883953795d5cbab009966e14b65e Reviewed-on: https://code.wireshark.org/review/30666 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-11-16Use an enum for compression types in various interfaces.Guy Harris13-75/+77
This: 1) means that we don't have to flag the compression argument with a comment to indicate what it means (FALSE doesn't obviously say "not compressed", WTAP_UNCOMPRESSED does); 2) leaves space in the interfaces in question for additional compression types. (No, this is not part 1 of an implementation of additional compression types, it's just an API cleanup. Implementing additional compression types involves significant work in libwiretap, as well as UI changes to replace "compress the file" checkboxes with something to indicate *how* to compress the file, or to always use some other form of compression). Change-Id: I1d23dc720be10158e6b34f97baa247ba8a537abf Reviewed-on: https://code.wireshark.org/review/30660 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-11-16Use the dump parameters structure for non-pcapng-specific stuff.Guy Harris2-7/+9
Use it for all the per-file information, including the per-file link-layer type and the per-file snapshot length. Change-Id: Id75687c7faa6418a2bfcf7f8198206a9f95db629 Reviewed-on: https://code.wireshark.org/review/30616 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-11-14ui: add missing break.Dario Lombardo1-0/+1
Error: ../ui/alert_box.c: In function ‘cfile_write_failure_alert_box’: ../ui/alert_box.c:359:13: error: this statement may fall through [-Werror=implicit-fallthrough=] simple_error_message_box( ^~~~~~~~~~~~~~~~~~~~~~~~~ "Frame %u%s has a network type that differs from the network type of earlier packets, which isn't supported in a \"%s\" file.", ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ framenum, in_file_string, ~~~~~~~~~~~~~~~~~~~~~~~~~ wtap_file_type_subtype_string(file_type_subtype)); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../ui/alert_box.c:364:9: note: here case WTAP_ERR_PACKET_TOO_LARGE: ^~~~ Change-Id: I55464afff5625ae8c587470e417234560c7e606c Reviewed-on: https://code.wireshark.org/review/30623 Reviewed-by: Dario Lombardo <lomato@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-11-14Catch attempts to write multiple encapsulation types if unsupported.Guy Harris2-0/+22
If, in the process of opening the input file, we determine that it has packets of more than one link-layer type, we can catch attempts to write that file to a file of a format that doesn't support more than one link-layer type at the time we try to open the output file. If, however, we don't discover that the file has more than one link-layer type until we've already created the output file - for example, if we have a pcapng file with a new IDB, with a different link-layer type from previous IDBs, after packet blocks for the earlier interfces - we can't catch that until we try to write the packet. Currently, that causes the packet's data to be written out as is, so the output file claims it's of the file's link-layer type, causing programs reading the file to misdissect the packet. Report WTAP_ERR_ENCAP_PER_PACKET_UNSUPPORTED on the write attempt instead, and have a nicer error message for WTAP_ERR_ENCAP_PER_PACKET_UNSUPPORTED on a write. Change-Id: Ic41f2e4367cfe5667eb30c88cc6d3bfe422462f6 Reviewed-on: https://code.wireshark.org/review/30617 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-11-13tshark: Print the packets' comments in the expert infoVasil Velichkov1-2/+10
Previously 'tshark -z expert' was failing with abort when a packet contains a comment - Add a new comment parameter and update the tshark's manual page - Add a new comment_level severity and change the default lavel to it. - Add various 'tshark -z expert' tests Change-Id: I188317da5e00019b8f2b725f0fe84942f774520f Reviewed-on: https://code.wireshark.org/review/30610 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-11-13Don't have _ng versions of the dumper open routines.Guy Harris2-3/+5
Have the routines always take a parameters pointer; pass either null or a pointer to an initialized-to-nothing structure in cases where we were calling the non-_ng versions. Change-Id: I23b779d87f3fbd29306ebe1df568852be113d3b2 Reviewed-on: https://code.wireshark.org/review/30590 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-11-12wiretap: refactor common parameters for pcapng dump routinesPeter Wu1-2/+6
Four variants of wtap_dump_open_ng exists, each of them take the same three parameters for the SHB, IDB and NRB blocks that has to be written before packets are even written. Similarly, a lot of tools always create these arguments based on an existing capture file session (wth). Address the former duplication by creating a new data structure to hold the arguments. Address the second issue by creating new helper functions to initialize the parameters based on a wth. This refactoring should make it easier to add the new Decryption Secrets Block (DSB). No functional change intended. Change-Id: I42c019dc1d48a476773459212ca213de91a55684 Reviewed-on: https://code.wireshark.org/review/30578 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-11-11[Automatic update for 2018-11-11]Gerald Combs7-30/+135
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I49c9b5a86e33811c59c7e70d5f548d103f7bc35c Reviewed-on: https://code.wireshark.org/review/30573 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-11-10UI: Remove Win32 file dialog stuff specific to GTKPeter Wu4-378/+0
Remove "Export SSL Session Keys", "Import/Export Color Filters" and "Export Raw Bytes" dialogs. These were only used by GTK+ as Qt has its own implementation. Change-Id: I0520a0f6e35d0f8a55c58e77f89c5229393c2b23 Reviewed-on: https://code.wireshark.org/review/30559 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-09Dumpcap+Qt: Add support for `-a packets:NUM` and `-b packets:NUM`.Gerald Combs2-47/+88
Add the ability to rotate files after a specified number of packets (`-b packets:NUM`). Move some condition checks to capture_loop_write_packet_cb. Add `-a packets:NUM` in order to be consistent. It is functionally equivalent to the `-c` flag. Add a corresponding "packets" option to the Capture Interfaces dialog Output tab. Add initial tests for autostop and ringbuffer conditions. Change-Id: I66eb968927ed287deb8edb96db96d7c73526c257 Reviewed-on: https://code.wireshark.org/review/30534 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-07Qt: Add file hashes to capture file properties dialogJaap Keuter3-1/+69
Like capinfos provide file hashes in the capture file properties dialog. Change-Id: Ia9f1b05f61abd239d81b7061bbba1e53c01f28be Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-on: https://code.wireshark.org/review/30524 Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-04[Automatic update for 2018-11-04]Gerald Combs7-4/+116
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Iee0e09f81a210056a76987713b09d95c390f5876 Reviewed-on: https://code.wireshark.org/review/30499 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-11-01Fix "Follow TLS Stream" after ssl -> tls renamePascal Quantin1-3/+3
Change-Id: I53be2ae6fae135b2da98ae95deac535bcd37af74 Reviewed-on: https://code.wireshark.org/review/30473 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-11-01macOs: Fix build fix for tab viewRoland Knall2-2/+39
Fix the build for displaying the tabs wrongly on mac Change-Id: I58265b7cf9a4758885ef1add13417c42a467be9d Reviewed-on: https://code.wireshark.org/review/30462 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-11-01Qt: Remove wireless toolbar if not supportedRoland Knall3-2/+24
To mimic the behaviour we have with remote controls, we hide the wireless toolbar if it cannot be used, instead of displaying an empty toolbar with the information that it is not supported Change-Id: Iccb0bf78a29a2547adf2290198df8a1bf3450d82 Reviewed-on: https://code.wireshark.org/review/30455 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-11-01tshark: Fix small memory leak in tap-expertVasil Velichkov1-2/+12
Change-Id: I9d81bda8a33c7a07118e8aff2917215c92e870f4 Reviewed-on: https://code.wireshark.org/review/30436 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-10-31text_import: fix wrong int type.Dario Lombardo1-2/+2
Regressed in ge655b9a. Change-Id: I5aeb9e1935bc1064797db8ac6acaa852d9a07c98 Reviewed-on: https://code.wireshark.org/review/30445 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-31import: add export_pdu dummy header feature.Dario Lombardo5-13/+110
When importing a file from hex dump, this change adds a way to add a custom dummy header. It's an export_pdu header which uses one single tag: the protocol name. This allows to call directly a dissector without more dummy headers. Example: it can be used to call the DNS dissector without fake eth/ip/udp headers. Change-Id: I12fd6d09a131acd9bd1f0d7c4c8aefcd0d718b26 Reviewed-on: https://code.wireshark.org/review/30403 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-30Qt: omit initial empty line in About Dialog / AcknowledgementsPeter Wu1-2/+2
Follow the logic in tools/generate_authors.pl for matching the Acknowledgements section (which looks for a substring match instead of a literal string. Change-Id: I42e1553b6820af3fb2d5b9cda0fa0e6e6ca7e729 Reviewed-on: https://code.wireshark.org/review/30432 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-30Fix About->AcknowledgementsMichał Łabędzki1-1/+1
Add prefix and postfix "=" to satisfy text splitter to avoid empty text area. Change-Id: I3c8e4fd4711ea8fcc7bba9583ff3fe5cb06ce4a1 Reviewed-on: https://code.wireshark.org/review/30428 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-10-29QT: Enable filtering entries in 'Export Objects'Moshe Kaplan2-0/+25
Change-Id: I5e9025545f9127d1c5c6200844f9b917af975998 Reviewed-on: https://code.wireshark.org/review/28844 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-10-28[Automatic update for 2018-10-28]Gerald Combs7-0/+28
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Idf3c0396827899991306fd8929519ba138bd4f54 Reviewed-on: https://code.wireshark.org/review/30398 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-10-26Qt: fix saving exported objects after sorting columnsMoshe Kaplan1-1/+5
Avoid assuming an export object's row number is consistent throughout, because the row number can change if the display is filtered or sorted. Instead, look up the index in the model with mapToSource(). Bug: 14545 Change-Id: I61099dfb4f3abc056417eb7d6ffbc7a988553dd8 Reviewed-on: https://code.wireshark.org/review/30388 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-10-22Add ability to disable autocomplete suggestions for filter controls.Michael Mann4-1/+17
Add a preference (enabled by default) that can enable/disable the ability for Wireshark to autocomplete display and capture filter controls. Bug: 14368 Change-Id: Ib2b688bb75c4465dab14a6a635a870d7e5c4fe80 Reviewed-on: https://code.wireshark.org/review/30320 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-21Qt: fix assertion failure when redissecting with a debug build of QtPeter Wu1-4/+4
Opening the Follow TCP Stream dialog triggers redissection and ended up triggering a "first <= rowCount(parent)" assertion failure. Fix the first and end arguments to reflect the actual number of displayed rows. Bug: 15014 Change-Id: Ic07834948a133bea752e45751ebe8be2da98a35e Reviewed-on: https://code.wireshark.org/review/30302 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-10-21tap-follow: fix memory leakVasil Velichkov1-1/+1
Register the follow_free as a finish callback. Call the tap's finish callback in free_tap_listener which is called from both remove_tap_listener and tap_cleanup. Describe the finish callback in README.tapping Change-Id: Ie79ce8f39b0ca6d84810d2e3307dcff38b18d3ac Reviewed-on: https://code.wireshark.org/review/29309 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-10-21[Automatic update for 2018-10-21]Gerald Combs2-46/+24
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Idd6532c6a268e1a0ab9e171f55549155c26a43dc Reviewed-on: https://code.wireshark.org/review/30294 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-10-14[Automatic update for 2018-10-14]Gerald Combs7-63/+344
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I3dc92d31a377dafc7c333139a580dbb140ec47e2 Reviewed-on: https://code.wireshark.org/review/30201 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-10-11wsutil: Add config_file_exists_with_entries()Stig Bjørlykke1-1/+1
The purpose of this function is to check if a configuration file exists and has at least one entry which is not a comment. Use this when building the list of profiles where the user can copy configuration from, to avoid listing profiles with empty files or files with only comments. Change-Id: If45f52025959818fb1213ffac488cd59441e9fce Reviewed-on: https://code.wireshark.org/review/30113 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-10-10Qt: Add back pathLabel in some dialogsStig Bjørlykke8-19/+138
Add the pathLabel for Coloring Rules, Decode As, Display Filters and Capture Filter. Put the absolute file path into the pathLabel if the file exists. This aligns with UAT dialogs and frames. Change-Id: I72bd06e31bab220de0a0ef8df99df9a4daed667c Reviewed-on: https://code.wireshark.org/review/30089 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-10Qt: Use regular size buttons on macOSStig Bjørlykke2-1/+4
Use regular size buttons in dialogs on macOS. Change-Id: Iad769190b7f62297343eea4299e3f03ea6be4b1e Reviewed-on: https://code.wireshark.org/review/30099 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-08Qt: Add copy from another profile for UAT framesStig Bjørlykke3-2/+49
Add a new button to UAT frames to copy entries from another profile. Change-Id: I9decb5ed5d67e97388ee7b22a15cacae4d5a3621 Reviewed-on: https://code.wireshark.org/review/30084 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-10-08Qt: Refactor copy from profile widgetStig Bjørlykke11-95/+107
Refactor CopyFromProfile class from Button to Menu to make it usable for existing buttons, both QPushButton and QToolButton. Change-Id: I7d23b4225dbe45f961fb05e73dbb4dd51e6f8ea1 Reviewed-on: https://code.wireshark.org/review/30083 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-10-08Qt: Fix a typo in a tooltipStig Bjørlykke1-1/+1
Change-Id: I71c8193d5352f9ac58541dc56b58cf3e85275f6e Reviewed-on: https://code.wireshark.org/review/30068 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-10-08Qt: Add clear all button to Decode AsStig Bjørlykke5-0/+46
Add a clear all button to easily remove all existing entries. Change-Id: I76e7ee2b7b85a9b4e5f9f5a788a89f38f70ee8ce Reviewed-on: https://code.wireshark.org/review/30052 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-08Qt: Remove unused pathLabelStig Bjørlykke2-40/+2
Change-Id: Id1c40f231f49f75210af43fa2a5cfbe3937d9ca1 Reviewed-on: https://code.wireshark.org/review/30055 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-14 12:18:53 +0000