aboutsummaryrefslogtreecommitdiffstats
path: root/ui
AgeCommit message (Collapse)AuthorFilesLines
2015-02-07Qt: Add the Coloring Rules dialog.Gerald Combs17-133/+815
Merge in the old ColorDialog which was a placeholder for color_filter_add_cb. Change-Id: I48d188509f480b8514122b4011ac9d8790fcca10 Reviewed-on: https://code.wireshark.org/review/6996 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-06Qt: Fix preference change behavior.Gerald Combs5-41/+58
Main window: Keep track of our current layout and only change it if the preferences change. This keeps the panes from resizing. Re-select the current packet if the layout changes so that the proto tree and byte view aren't left in an invalid state. This fixes a crash similar to bug 10896. Search frame: Get rid of an invalid error message. Update coding style. I don't think any of these fix bug 10921 since Xiaochuan seems to get a crash immediately upon opening the dialog. Change-Id: I0e880a50d3c9ac1c6ae6a01034b05fd2249444f4 Reviewed-on: https://code.wireshark.org/review/6989 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-06Multicast Stream (GTK): fix crash when try to select a streamAlexis La Goutte1-1/+1
Change-Id: Iaaa9445ae99b37cfb1865251d50f38375f3eb272 Reviewed-on: https://code.wireshark.org/review/6985 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-02-04Qt: Add "Copy As..." to the Protocol Hierarchy stats.Gerald Combs3-10/+144
This implementation is slightly different compared to other dialogs since we have nested items. Tweak the bar highlight color look better on Windows while we're here. Change-Id: If0607c4624f304042fe3d6c8a941756b342e703d Reviewed-on: https://code.wireshark.org/review/6953 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-04HTTP2: Add tap for HTTP2 dissectorAlexis La Goutte4-0/+18
Change-Id: Ib13d9391b64dad19321a4399c95b95d7fb791284 Reviewed-on: https://code.wireshark.org/review/6421 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-02-04Convert val_to_str -> val_to_str_wmem.Michael Mann20-104/+241
This is mostly for GUI usage, but a few dissectors needed some "non-packet scope" conversions. val_to_str officially now uses wmem_packet_scope() Change-Id: Ic9413eeb3406d7a7683222b86709f3675d628d81 Reviewed-on: https://code.wireshark.org/review/6933 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-04Qt: Add the Protocol Hierarchy statistics dialog.Gerald Combs19-32/+654
Change-Id: I6872e323daca4798c638d764873f54c4c0dc0006 Reviewed-on: https://code.wireshark.org/review/6934 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-04Decorate declarations with G_GNUC_PRINTF() as appropriate.Guy Harris1-2/+4
Decorate val_to_qstring() and val_ext_to_qstring() similarly to val_to_str_wmem(); this squelches some compiler warnings. Change-Id: I86e102e7c0a1a135be9492b7d605001c5d922031 Reviewed-on: https://code.wireshark.org/review/6940 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-02-03Updates in it translation.Dario Lombardo2-675/+934
This fixes also the "duplicate messages" error. Change-Id: Iec93d82d4776c4f9805c5bfa2b2453c22b0e24e8 Reviewed-on: https://code.wireshark.org/review/6929 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-02-03Convert val_to_str_ext -> val_to_str_ext_wmem for calls that don't have ↵Michael Mann13-56/+121
valid packet scope (GUI). val_to_str_ext now officially uses wmem_packet_scope(). Removed const from val_to_str[_ext]_wmem return value since it's not really constant. Created utility functions in qt_ui_utils.h to help with the new memory management for its GUI. Change-Id: Idf2ce4a4ce78d628b2269ad23a3a48fbfc9c077c Reviewed-on: https://code.wireshark.org/review/6926 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-02-03Qt: Fix IO Graph capture file closing.Gerald Combs2-5/+8
Make sure our IOGraphs remove their respective tap listeners before the capture file closes, otherwise the graph data ends up getting cleared via reset_tap_listeners. Bug: 10871 Change-Id: I0ef2af2dc84be1921a930df8bb68f63626aa874a Reviewed-on: https://code.wireshark.org/review/6925 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-02Fix some indent typo (after g2bf7878e)Alexis La Goutte2-10/+10
Change-Id: I44769f127f32ffd8a97b1579f371501f4aa9832a Reviewed-on: https://code.wireshark.org/review/6913 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-01Fix a typo.Guy Harris1-1/+1
Change-Id: I2724340e41572fdaa56ebf75478297090563c522 Reviewed-on: https://code.wireshark.org/review/6895 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-31No main window *to* update in the early argument list parsing.Guy Harris1-1/+1
We haven't yet popped the main window up, so, when we call capture_interface_list(), we shouldn't pass a pointer to the "update the main window" routine. Change-Id: Id3e02199479e66bb9e9aff99b435bd03af45a1af Reviewed-on: https://code.wireshark.org/review/6868 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-30Qt: Fix library path reset.Gerald Combs1-25/+0
g9a3676a reset the Qt library path *after* wsApp was instantiated, which is too late. Do so before QCoreApplication has a chance to do anything we might regret. Change-Id: Ibbdb69d1b7c0ea4bf1042e98a5bb5deba13e954e Reviewed-on: https://code.wireshark.org/review/6864 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-01-30Qt: Clear our library path at startup on Windows.Gerald Combs1-0/+25
I recently rebuilt my Windows development VM and discovered that I could no longer run Wireshark executables from wireshark.org. Trying to do so failed with the following error: ---- This application failed to start because it could not find or load the Qt platform plugin "windows". Available platform plugins are: minimal, offscreen, windows, windows. Reinstalling the application may fix this problem. ---- As it turns out there are two issues. According to http://doc.qt.io/qt-5/windows-deployment.html The search path for Qt plugins is hard-coded into the QtCore library. Dependency Walker confirmed this, showing that Qt5Core.dll tried to load C:\Qt\5.3\msvc2013_64_opengl\plugins\platforms\qwindows.dll instead of C:\Program Files\Wireshark\platforms\qwindows.dll. The second issue is that the Qt online installer only uses the major and minor version, e.g. C:\Qt\5.3. This means that you can end up with Qt 5.3.0, .1, .2, or .3 depending on *when* you run the installer. The Windows builders have 5.3.1 installed while my development VM has 5.3.2. Apparently qwindows.dll is not compatible between these two versions, hence the startup error. (...so what happens if you can create a malicious qwindows.dll which *is* compatible on someone's machine?) This change removes any entries from QCoreApplication::libraryPaths that don't match our executable path. This shouldn't be an issue in our case because both the NMake+QMake and CMake environments run windeployqt to copy in any required DLLs. If it *is* an issue or if clearing the library path list causes other problems I can reinstall Qt on the Windows builders into a unique and obvious path, e.g. C:\Qt-check-your-path-before-you-wreck-your-path\5.3 Change-Id: I1918bc4e520aba32cfcf9f4ccd37bf9255058cbe Reviewed-on: https://code.wireshark.org/review/6863 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-01-30Qt: Add the RTP Streams dialog.Gerald Combs30-137/+1236
Add keyboard shortcuts. Note that not all of the buttons made it from GTK+. Add a "Go to setup frame" option. Move rtp_streams.c from ui/gtk to ui. Add a help URL for RTP analysis (which needs to be split into streams + analysis). Fix RTP stream packet marking. Change-Id: Ifb8192ff701a933422509233d76461a46e459f4f Reviewed-on: https://code.wireshark.org/review/6852 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-01-29Qt: Add address conversion convenience routinesGerald Combs9-39/+73
Add address_to_qstring and address_to_display_qstring, which wrap address_to_string and address_to_display respectively and return QStrings. Convert most of the instances in ui/qt to the new routines. Fix a some memory leaks in the process. Change-Id: Icda80bbfe0b2df723d54c8da84355255f819af89 Reviewed-on: https://code.wireshark.org/review/6848 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-01-28Proto dialog (GTK) : fix indent (use 2 spaces) and add modelinesAlexis La Goutte2-55/+76
Change-Id: I36945843b8d544188a3ffe89f397e669f3944593 Reviewed-on: https://code.wireshark.org/review/6831 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-27Qt: Update packet list freeze/thaw behavior.Gerald Combs1-4/+5
Move the clear() calls in gee320ef a bit earlier in the code to PacketList::freeze. No model means no packets. Bug: 10896 Change-Id: Ie440e3da4c5fb601048f4e94c8712ecf2d864d4f Reviewed-on: https://code.wireshark.org/review/6823 Reviewed-by: Sean Stalley <seanstalley@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-01-27Added HPFEEDS stats_tree.Dario Lombardo4-0/+17
Change-Id: I256fd5395b062fa954ebd60598721323ea1d7ff1 Bug: 10875 Reviewed-on: https://code.wireshark.org/review/6713 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-27Qt: Add checkable for Find Packet iconAlexis La Goutte1-12/+6
Change-Id: Idd3c0b1893a9e0f8bc329e9157baaccd10de7378 Reviewed-on: https://code.wireshark.org/review/6814 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-27Packet List (Qt): fix extra ‘;’ [-Wpedantic]Alexis La Goutte1-1/+1
Change-Id: I3ac80a13da91452de4c857abfd6f2661b00e2f5d Reviewed-on: https://code.wireshark.org/review/6815 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-27GTK: Fix multispace on main title barAlexis La Goutte1-2/+2
Change-Id: I275a586c16621fdfabede23f6a1d03c8d8556b3f Reviewed-on: https://code.wireshark.org/review/6813 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-27GTK: fix no previous prototype for ... [-Wmissing-prototypes]Alexis La Goutte3-0/+3
Add by commit g43f09e67b (Remove unneeded includes from ui folder) Change-Id: I66eb113430bde97e18bb3d2b00f6bac46a01797e Reviewed-on: https://code.wireshark.org/review/6809 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-27GTK: fix no previous prototype for ... [-Wmissing-prototypes]Alexis La Goutte16-1/+17
Add by commit g43f09e67b (Remove unneeded includes from ui folder) Change-Id: I7c9d9e2bbd76d062f96422c74ee8eb8c6ecd328b Reviewed-on: https://code.wireshark.org/review/6808 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-27qt: clear tree and bytes when no packet selectedEvan Huus1-0/+4
Otherwise trying to interact with them will cause all sorts of funny crashes. There's probably a better way to trigger these (having the widgets register for a signal, and sending that signal, or something something something) but this works and I don't feel like reading 20 pages of Qt documentation right this instant. Change-Id: Ic52806ae5ba8d7776f835695590559b8c705d083 Ping-Bug: 10896 Reviewed-on: https://code.wireshark.org/review/6803 Reviewed-by: Evan Huus <eapache@gmail.com>
2015-01-23Qt: Remove windowIcon property from our .ui files.Gerald Combs5-29/+6
Setting the windowIcon property in foo.ui means we end up with a setWindowIcon call in ui_foo.h. Along with setting the window title bar icon, it also sets the taskbar icon on Windows. A 16x16 PNG gives us a jaggy taskbar icon. (Windows ICO format is supported via a plugin which might not be available everywhere, otherwise we could try using a .ico resource.) Move the setWindowIcon call from ge990d1b to the top of the MainWindow constructor and enable it everywhere. Change-Id: I4e9765200bb3676c4faa8e0ab1505ce02fb64870 Reviewed-on: https://code.wireshark.org/review/6762 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-01-23Try to fix the jaggy taskbar icon.Gerald Combs1-0/+4
Possibly related to https://bugreports.qt.io/browse/QTBUG-19441. Change-Id: Idf7ff8a247f459ce465907760ca0ebeaff2cffa8 Reviewed-on: https://code.wireshark.org/review/6746 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-18[Qt] Run windeployqt for Qt versions greater than 5.2AndersBroman1-1/+1
Change-Id: I3c7e7ed35ffead280c1ac394a4ef8172a89fe3a6 Reviewed-on: https://code.wireshark.org/review/6622 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-18Update some comments to reflect reality.Guy Harris1-1/+0
Get rid of references to ep_ and se_ allocation in code that now uses wmem allocation instead. Fix API documentation of conversation_table.h routines to reflect that as well - some APIs changed to pass wmem scopes. Also, zbee_sec_key_hash() now takes the output buffer as an argument and just returns it, and nobody actually uses the return value, so change it to return void. Change-Id: Ife1ec675a9322fd0f0be306a9d639ec17aad1c7a Reviewed-on: https://code.wireshark.org/review/6636 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-18Remove some apparently-unnecessary includes of emem.h.Guy Harris4-5/+2
Also update a comment to no longer speak of ep_ allocation, and add an include of <glib.h> to ui/profile.c, which was formerly relying on the include of emem.h to drag it in. Change-Id: I08926699ee96cf66672836b6ee3bbb405b507ce8 Reviewed-on: https://code.wireshark.org/review/6633 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-18Fix another dfilter_compile() call.Guy Harris1-1/+1
Change-Id: I8b035a09b1bc1981a78a80e0a2547dce65a2ac9c Reviewed-on: https://code.wireshark.org/review/6609 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-18Clean up ftype-conversion and dfilter error message string handling.Guy Harris24-104/+127
Have dfilter_compile() take an additional gchar ** argument, pointing to a gchar * item that, on error, gets set to point to a g_malloc()ed error string. That removes one bit of global state from the display filter parser, and doesn't impose a fixed limit on the error message strings. Have fvalue_from_string() and fvalue_from_unparsed() take a gchar ** argument, pointer to a gchar * item, rather than an error-reporting function, and set the gchar * item to point to a g_malloc()ed error string on an error. Allow either gchar ** argument to be null; if the argument is null, no error message is allocated or provided. Change-Id: Ibd36b8aaa9bf4234aa6efa1e7fb95f7037493b4c Reviewed-on: https://code.wireshark.org/review/6608 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-18Miscellaneous ep_strdup_printf replacement.Michael Mann2-2/+8
Change-Id: I973c672e9d573ad67e9b9fd82a5610aaf8a74efa Reviewed-on: https://code.wireshark.org/review/6605 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-18Remove emem from GeoIPMichael Mann3-5/+13
Change-Id: Ifa96dc38a277b86c28f762489251dcc595afae67 Reviewed-on: https://code.wireshark.org/review/6603 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-17A few more emem replacements with wmem.Michael Mann1-4/+3
Change-Id: Icfb319fba937642db637a7f26b5e7627461df3b0 Reviewed-on: https://code.wireshark.org/review/6590 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-17Convert proto_construct_match_selected_string to use wmem.Michael Mann4-1/+10
Change-Id: I7a40c0996517aa71b4ddb764ce3a6e92a55260ad Reviewed-on: https://code.wireshark.org/review/6589 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-16Remove se_ alloced memory from packet_list_storeMichael Mann1-3/+3
Change-Id: I7aa2f5f8b433468ad2c2cd73cfce986d128a9ae0 Reviewed-on: https://code.wireshark.org/review/6565 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-16SE_COPY_ADDRESS -> WMEM_COPY_ADDRESSMichael Mann1-3/+6
Copy addresses with wmem-scope instead of (forced) seasonal scope. All existing instances were converted to wmem_file_scope, but the flexibility is there for other scopes. Change-Id: I8e58837b9ef574ec7dd87e278470d7063ae8c1c2 Reviewed-on: https://code.wireshark.org/review/6564 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-16Replace se alloced memory in compare stat tap.Michael Mann2-6/+25
Also replaced comments mentioning se_alloc memory with wmem_file_scope, since it's more accurate. It seems that many of the TShark stat taps may be leaking memory, because the hash tables created by the taps don't get a chance to be freed. Somewhat academic since TShark exits shortly after displaying any stats, but a leak none the less. Change-Id: I8ceecbd00d65b3442dc02d720b39c2e15aa0c8a6 Reviewed-on: https://code.wireshark.org/review/6557 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-16QT: stats_tree plug-ins not added to statistics menuDeon van der Westhuysen3-0/+61
Wireshark Qt does not add plug-ins that register with stats_tree_register_plugin() to the statistics menu in the ui (like the gtk version does). This patch dynamically adds all registered stats_tree plug-ins to the statistics menu. Bug: 9528 Change-Id: I99f9415502ca9f7121d494c856861edc1a762079 Signed-off-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-on: https://code.wireshark.org/review/6336 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-01-15Replace C++ style comment with C style.Michael Mann1-1/+1
Change-Id: Ibee0dccdb5a330866dcd0047216cd5a4da45fc8b Reviewed-on: https://code.wireshark.org/review/6559 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-15Packet List (Qt): Missing break in switch (CID 1262418)Alexis La Goutte1-0/+1
Change-Id: Id46f2be5b5206dfcb0ce7e7ea2d31398eff54917 Reviewed-on: https://code.wireshark.org/review/6552 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-01-15Fix the compile: Use the new (double) variable.Jeff Morriss1-1/+1
Change-Id: I38a9b0f55e9f19fe7f4f09f5eec2817dd822c6d0 Reviewed-on: https://code.wireshark.org/review/6542 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2015-01-15Fix a crash in the GTK+ RTP Streams dialog.Gerald Combs1-2/+9
Make sure we copy guint, gdouble, and gchar * data to variables of the correct type. Fixes a crash when trying to copy CSV data (we were trying to stuff a gdouble into a char *). Change-Id: I3cbcc48216a078f85f13860d14707f309b9820d7 Reviewed-on: https://code.wireshark.org/review/6541 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-01-15Fix indentation.Gerald Combs1-35/+35
Change-Id: I089d18d6dde56c04d75f7c991511728a0a66f699 Reviewed-on: https://code.wireshark.org/review/6540 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-01-13Consistently use the "g_string_free returns a C string pointer" idiom.Guy Harris9-44/+37
g_string_free(str, FALSE) frees the GString container but not the underlying g_malloc()ed string; instead, it returns a pointer to the g_malloc()ed string. Fix those places that didn't already get the string pointer from g_string_free() to do so rather than manually extracting the string themselves. And fix one place that didn't even need to use a string - it was just scanning a C string without even modifying it. Change-Id: Ibbf4872bf5b9935b9907f539b6edb1013f3053a5 Reviewed-on: https://code.wireshark.org/review/6532 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-13uat_load() and uat_save() return a success indication; use it.Guy Harris4-23/+19
Instead of always ignoring the return value, always check it, and only report an error if it returns FALSE. (Alternative: have it return NULL on success and a pointer to a g_malloc()ed string on failure.) Fix a comment while we're at it. Change-Id: Icb72c9f47775b6552e3eb4fe5ddcc85482bfb5fb Reviewed-on: https://code.wireshark.org/review/6528 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-13UAT error string pointers should not be const pointers.Guy Harris2-6/+8
UAT error strings are usually allocated by g_strdup() or g_strdup_printf(), and must ultimately be freed by the caller. Make the pointer-to-error-string-pointer arguments to various functions be "char **", not "const char **". Fix cases that finds where a raw string was being used, as that won't work if you try to free it; g_strdup() it instead. Add a missing free of an error string. Remove some no-longer-necessary casts. Remove some unnecessary g_strdup()s (the string being handed to it was already g_malloc()ated). Change some variable declarations to match. Put in XXX comments for some cases where the error string is just freed, without being shown to the user. Change-Id: I40297746a2ef729c56763baeddbb0842386fa0d0 Reviewed-on: https://code.wireshark.org/review/6525 Reviewed-by: Guy Harris <guy@alum.mit.edu>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-21 01:48:20 +0000