aboutsummaryrefslogtreecommitdiffstats
path: root/ui
AgeCommit message (Collapse)AuthorFilesLines
2019-09-22Qt, http2: Add Follow HTTP/2 Stream functionalityAlexander Gryanko10-49/+180
The HTTP/2 protocol multiplexes a single TCP connection into multiple independent streams. The Follow TCP output can interleave multiple HTTP/2 streams, making it harder to analyze a single HTTP/2 stream. Add the ability to select HTTP/2 Streams within a TCP stream. Internally, the HTTP/2 dissector now stores the known Stream IDs in a set for every TCP session which allows an amortized O(n) lookup time for the previous/next/max Stream ID. [Peter: make the dissector responsible for clamping the HTTP/2 Stream ID instead of the Qt code, that should permit future optimizations.] Change-Id: I5d78f29904ae8f227ae36e1a883155c0ed719200 Reviewed-on: https://code.wireshark.org/review/32221 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexander Gryanko <xpahos@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-09-21MSVC: Warn about unused formal parametersTomasz Moń1-1/+1
Provide _U_ macro definition for Visual Studio. Change the way _U_ macro is ifdefed for some targets to allow Visual Studio to recognize it. Ping-Bug: 15832 Change-Id: Ic7ce145cbe9e8aa751d64c9c09ce8ba6c1bbbd30 Reviewed-on: https://code.wireshark.org/review/34530 Tested-by: Petri Dish Buildbot Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-09-21Qt, docs, ieee1905: fix some spelling errorsPeter Wu8-10/+10
The spelling error for "Desription" in the context menu was very obvious. The others were found by scanning the output of: grep -Po '<source>\K.*(?=</source>)' wireshark_en.ts Change-Id: I4b95236c82f76828a115d59d7c8e0b853eae1d26 Reviewed-on: https://code.wireshark.org/review/34582 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-09-19Qt: QCustomplot fix warningsRoland Knall2-36/+36
Fix compile warnings due to incorrect conversions. Change-Id: Ia24e9cb6ef5ed9ca1391dd005ed1eb95db1b0d30 Reviewed-on: https://code.wireshark.org/review/34553 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-09-17Qt: Fix issues found by clang.Alexis La Goutte3-2/+3
Fix the following issues: ../ui/qt/rtp_player_dialog.cpp:88:21: error: unused variable 'wf_graph_selected_width_' [-Werror,-Wunused-const-variable] static const double wf_graph_selected_width_ = 2.0; ^ In file included from /home/vasko/sources/wireshark/ui/qt/sequence_diagram.cpp:10: /home/vasko/sources/wireshark/ui/qt/sequence_diagram.h:59:20: error: 'selectTest' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override] virtual double selectTest(const QPointF &pos, bool onlySelectable, QVariant *details=0) const; ^ /home/vasko/sources/wireshark/ui/qt/widgets/qcustomplot.h:3330:18: note: overridden virtual function is here /home/vasko/sources/wireshark/ui/qt/tcp_stream_dialog.cpp:60:12: error: unused variable 'graph_color_4' [-Werror,-Wunused-const-variable] const QRgb graph_color_4 = tango_scarlet_red_4; ^ /home/vasko/sources/wireshark/ui/qt/tcp_stream_dialog.cpp:61:12: error: unused variable 'graph_color_5' [-Werror,-Wunused-const-variable] const QRgb graph_color_5 = tango_scarlet_red_6; ^ Change-Id: Ic0d96939cc13fc550aa6857ddc75fe498e7104ea Reviewed-on: https://code.wireshark.org/review/34555 Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Vasil Velichkov <vvvelichkov@gmail.com> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-09-17Update to qcustomplot 2.0.1Alexis La Goutte14-6581/+16097
Upgrade the internal version of QCustomPlot to 2.0.1 Change-Id: I1eb372d8e6a2f6c1bbdde4c74596785bf2d405c2 Reviewed-on: https://code.wireshark.org/review/17980 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-15Give more complete path name of the header file in question.Guy Harris1-1/+1
Change-Id: I0e81ae36ef74e89631a722229d170844a4d3b950 Reviewed-on: https://code.wireshark.org/review/34539 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-09-15Match style of other routines in the file.Guy Harris1-1/+2
Change-Id: I2aabe735316e05495370b5bceb8ca56a1c9b3558 Reviewed-on: https://code.wireshark.org/review/34538 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-09-15Qt: Add a comment to Apply+Prepare submenusRoland Knall1-0/+6
Add a comment to the Apply as Filter and Prepare as Filter menus, which displays the filter string selected for the menu Change-Id: I1bc3ecb849c51b3ffcbcc8ff18635a4df73ca27e Reviewed-on: https://code.wireshark.org/review/34534 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-09-15Move the last of the routines from capture_info.c into ui/capture.c.Guy Harris3-2/+127
That means the packet-count-during-capture stuff is scattered amongst fewer locations. Move capture_info.h into ui; it's now a header that declares routines whose implementations are GUI-platform-dependent. Change-Id: I475815724a4766f6bc2511e67ebae14865e1a9d1 Reviewed-on: https://code.wireshark.org/review/26249 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-09-15[Automatic update for 2019-09-15]Gerald Combs9-812/+200
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I175cef2c3e0e43854d99f9741f47f07441fcce2c Reviewed-on: https://code.wireshark.org/review/34529 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-09-14Qt: Prevent crash in main window layout.Evan Welsh1-1/+1
Add length check for extra_sizes array in geometry calculations when using recent sizes, prevents crash in case where user creates a new user profile with a layout of 1) filled pane 2) empty pane 3) empty pane. Bug: 16048 Change-Id: I5f30d6e4148703504029efab75a77f2cdb6619ff Reviewed-on: https://code.wireshark.org/review/34524 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-09-13Qt: Store recently used find packet settingsStig Bjørlykke4-5/+188
Store the last used find packet settings in the global recent file, and load this settings on startup. Change-Id: I38081311cb06b4f398f4dfb66b659ae7d26ccac2 Reviewed-on: https://code.wireshark.org/review/34512 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-09-10Qt: Fix PacketTree copy ValueStig Bjørlykke1-2/+2
Use edt from cap_file_ in case this is valid. This is a regression from 806bef47a2. Change-Id: I60150f50056b63346a1510505ffca22347ad4ba0 Reviewed-on: https://code.wireshark.org/review/34491 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-09-08[Automatic update for 2019-09-08]Gerald Combs10-798/+1486
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ifff2c6116b57d189f564986caa40e0a25de5233c Reviewed-on: https://code.wireshark.org/review/34472 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-09-08Qt UI: Warn about not saving non-PCM encoded audioJaap Keuter1-3/+13
When saving audio data from RTP stream(s) in Sun AU format we (still) do not harness the build-in codec framework. This results in empty Audio files for all but PCM encoded RTP streams. At least warn the user about the codec not being supported for saving in Audio file. Change-Id: Ia76caf71d0d5319a66dbf1cee517c0922bf7a561 Reviewed-on: https://code.wireshark.org/review/34466 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-08Qt UI: remove empty jitter buffer label tooltipJaap Keuter1-3/+0
The jitter buffer label in the RTP player dialog has an effectively empty tooltip. Since on the label itself there's little to tell this tooltip can be removed. Change-Id: I9429e4f02991734b800280e2cae73a27f71c3663 Reviewed-on: https://code.wireshark.org/review/34467 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-04Qt: fix compilation for enabled_protocols_model.Dario Lombardo1-2/+2
clang complains, gcc doesn't. Error: In file included from ../ui/qt/enabled_protocols_dialog.cpp:10: In file included from ../ui/qt/enabled_protocols_dialog.h:15: ../ui/qt/models/enabled_protocols_model.h:121:18: error: 'filterAcceptsRow' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override] virtual bool filterAcceptsRow(int sourceRow, const QModelIndex &sourceParent) const; Change-Id: Ifbba736158a841752da27349925a3b55556728ca Reviewed-on: https://code.wireshark.org/review/34447 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-09-04Qt: Fix override declarations for PacketListRoland Knall1-11/+12
Fix missing override declarations for packetlist header information Change-Id: If9d1cbcae20b5d098ff7b74cd263a6a21a296598 Reviewed-on: https://code.wireshark.org/review/34446 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-09-04Update tooltip text for applying display filterMoshe Kaplan1-1/+1
Change-Id: Iba1eb865eac1d22d1490769ae9509b1389594a09 Reviewed-on: https://code.wireshark.org/review/34418 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-09-04Qt: in EnabledProtocolsDialog handle protocol typeRoland Knall5-44/+156
Allow a selection of the list based on the protocol type. That way one can easily enable/disable for instance just heuristic protocols Change-Id: I1ee8df5d9887c764272ec55b33703855c0c91f5a Reviewed-on: https://code.wireshark.org/review/34442 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-03Qt: Make first column moveableRoland Knall1-0/+4
Due to changes in Qt 5.11, the first section is no longer moveable by default. This is due to internal storage mechanism. For strictly flat tables it is not an issue to make the first column moveable again. (see https://codereview.qt-project.org/c/qt/qtbase/+/207947) Bug: 15879 Change-Id: If4f1371404cd252ec9f65a27c25b1c68781a0c33 Reviewed-on: https://code.wireshark.org/review/34445 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-09-02Qt: PacketList call DecodeAsDialog directlyRoland Knall2-30/+43
Calling the directly from the context menu and setting data just before the execute of the menu can lead to information not present. Furthermore for future changes, the move to have QMenu only as a local variable is being reverted Change-Id: I470da26e658ae81ca416b3864889a4317b865755 Reviewed-on: https://code.wireshark.org/review/34428 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-09-02tshark: Add "ip" as alias for "ipv4" in -z hosts option.Michael Mann1-2/+3
Make it consistent with -z conv,ip and -z endpoints,ip Bug: 15660 Change-Id: I9a3d2e95fed47231c0bab20e6cf069987eed142f Reviewed-on: https://code.wireshark.org/review/34426 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-02Add number of comments in capture file to status barMichael Mann1-0/+5
Ping-Bug: 15799 Change-Id: Icad9c4de620c0ffc9c4aa1a0b1b0d1ea444f481f Reviewed-on: https://code.wireshark.org/review/34425 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-01Qt: Rework Resolved Addresses dialogRoland Knall8-390/+609
This is a refactoring/redesign of the "Resolved Addresses" dialog, allowing for sorting/filtering and searching within the addresses and ports. Change-Id: I5071e92ff699323b6c93fc533eeaf92e0db334de Reviewed-on: https://code.wireshark.org/review/34398 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-01[Automatic update for 2019-09-01]Gerald Combs10-303/+546
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I4a345c6e326c653b8e121126f1afe1005293725a Reviewed-on: https://code.wireshark.org/review/34415 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-30Qt: ProtoTree combine menusRoland Knall2-162/+94
The menu for a prototree when opened from a packetdialog was different than the one opened underneath packetlist. Those two are now the same. Change-Id: I57572287daa5a3b1de1f5bc8e95b382d5869af6e Reviewed-on: https://code.wireshark.org/review/34395 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-30Qt: Add macro for g_list_next for C++Roland Knall28-185/+196
Using a simple (type *) cast on g_list_next results in a warning with modern compilers "old-style cast" Adding a warning for g_list_next and data access to avoid the warning A good overview why reinterpret_cast has been used can be found here: https://stackoverflow.com/questions/332030/when-should-static-cast-dynamic-cast-const-cast-and-reinterpret-cast-be-used It is a 1:1 replacement in this case, but does not use any of the new cast styles and therefore should be used with caution. Change-Id: I989f237afc39aaf40133a788b1c0bbd7a51bf974 Reviewed-on: https://code.wireshark.org/review/34284 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-29Qt: Extend filterbutton context menuRoland Knall5-65/+43
The filterbutton context menu allows for appending the filter button expression to an already existing display filter and copying the filterbutton filter expression to the clipboard Bug: 15980 Change-Id: I7b24007e597b9a9800729339926378d0ff264c73 Reviewed-on: https://code.wireshark.org/review/34394 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-29Qt: Apply Invert/Enable/Disable only to selected listRoland Knall5-88/+120
Also, put the search field on top, as this is the default for search fields and apply the change of enable/disable and invert-all only to the selected items, instead of all items. Bug: 16013 Change-Id: If4ef1c5ce63eef6fa72db679cdcbf52dcb0e8fb6 Reviewed-on: https://code.wireshark.org/review/34393 Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-29Qt: Move Apply/Prepare to general QMenu handlerRoland Knall8-233/+49
Also clarify the method by which the filter can be selected. From the main menu only selected filters from a ProtoTree can be selected, therefore the code for PacketList handling has been removed. Change-Id: I5e5827d763ab3b25db14a384581f283238f96d28 Reviewed-on: https://code.wireshark.org/review/34384 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-27Add tooltip for clearing display filterMoshe Kaplan2-1/+5
Change-Id: I11f8c7ba00ffdc3028c85b1f0957bd6f95092dce Reviewed-on: https://code.wireshark.org/review/34357 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-26Qt: Create Apply/Prepare in PacketlistRoland Knall2-20/+32
Create the menu for apply/prepare inside Packetlist. At the same time disabled the "..." methods if no filter has been set yet Move the action list to FilterAction as well Change-Id: Ia18a4021cc95562702ff516a24fb029063096f94 Reviewed-on: https://code.wireshark.org/review/34377 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-26Qt: Add Apply/Prepare to Packet DialogRoland Knall1-1/+20
Add the possibility to apply/prepare a field entry to the packet dialog. This works also if the corresponding source file had already been closed. Bug: 3537 Change-Id: I448ad6d5cb37f2cbb2c2f649512b1f3e5acde2de Reviewed-on: https://code.wireshark.org/review/34372 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-26Qt: Remove unnecessary code for context menusRoland Knall5-68/+59
This code is no longer required, as context menus should be bound to local events. As for "Reloading LUA plugins" - the keyboard shortcut would be able to trigger while the menu is open, except Qt explicitely prevents that Change-Id: Id18a3a17d62bae1ff547a6ef96772e12a2535219 Reviewed-on: https://code.wireshark.org/review/34371 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-26Qt: Make Apply/Prepare filter independentRoland Knall5-22/+84
The context menu should only use information readily available at the point of creation. Copying actions from the mainwindow introduces a bunch of synchronization and consistency issues. This is a first step to move away from a centralized approach of managing actions, towards a distributed approach. As a side effect, this also solves the old issue of having the apply items greyed out in context menu Bug: 16001 Bug: 15323 Change-Id: I10c6df11cbab0a89386f5bf1d27759103df2a012 Reviewed-on: https://code.wireshark.org/review/34370 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-26Qt: Fix memory leak in ProfileModel constructorTomasz Moń1-0/+1
Change-Id: I4a0ccaebe7ab821a22b86ce1155328fd714caf50 Reviewed-on: https://code.wireshark.org/review/34376 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-08-26Qt: Fix copy from default profileRoland Knall1-1/+1
The default profile was available to be selected, even if it was the active profile. Bug: 16021 Change-Id: If08a563f243f18f32e17cb2169180ec0b1274a9a Reviewed-on: https://code.wireshark.org/review/34366 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-26Qt (zip_helper): Fix Dead StoreAlexis La Goutte1-1/+2
Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: Ib16fc6c0783adda8485056d5e20973cf078e7d7e Reviewed-on: https://code.wireshark.org/review/34321 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-08-26Qt: Move CopyFrom from menu to buttonRoland Knall13-97/+126
Move the CopyFromProfile implementation from a menu to a button to ease integration in existing code Change-Id: I4fb4e952e89665eda99d162e891ac6d3516a6f02 Reviewed-on: https://code.wireshark.org/review/34266 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-25[Automatic update for 2019-08-25]Gerald Combs9-353/+266
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I4ed4ada929881a78beefc34012a9898caa92d649 Reviewed-on: https://code.wireshark.org/review/34353 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-20Qt: Allow deletion of personal system-profileRoland Knall1-1/+1
If a profile is being deleted, but a system profile with the same name exists, the dialog cannot be closed Change-Id: I2fbaa999617203816e21a8e4486abaf368b69919 Reviewed-on: https://code.wireshark.org/review/34331 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-20Qt: Fix null pointer dereferenceRoland Knall1-45/+17
Rework existing code to avoid unsafe localtime Change-Id: I266ae7e006c6aeed42af39fea07c888874d0f588 Reviewed-on: https://code.wireshark.org/review/34329 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-19Qt: Initialize PacketListHeader member variablesTomasz Moń1-1/+3
Coverity CID 1446258 Change-Id: Iffadb8be97dd6dbd75a97869cea54398eec16554 Reviewed-on: https://code.wireshark.org/review/34324 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-19Qt: Fix PacketListHeader dereferences before null checkTomasz Moń1-4/+19
Coverity CID 1446250, 14462554, 1446255, 1446256 Change-Id: I38ec9473dbee92a5bb3bc9635e2f6968db27b99e Reviewed-on: https://code.wireshark.org/review/34325 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-19Qt: Fix CredentialsModel::clear()Tomasz Moń1-7/+9
The last parameter to beginRemoveRows() is the last row index, not the number of rows. The QAbstractItemModel::beginRemoveRows() source code expliticly checks if the value is smaller than row count. Do not emit beginRemoveRows() if the model is empty as it does not make sense and it is impossible to pass the QAbstractItemModel assertions in such case. Emit endRemoveRows() when finished instead of endInsertRows(). Change-Id: I93be4820b1ea0fbb5c0f3cd28edca329b4017814 Reviewed-on: https://code.wireshark.org/review/34318 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-18[Automatic update for 2019-08-18]Gerald Combs10-287/+446
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I085b9184725ceef499e1cfc71913c1f363ac246f Reviewed-on: https://code.wireshark.org/review/34315 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-14Wiretap: Fix temporary filename memory corruptionTomasz Moń2-3/+3
The pointer returned by create_tempfile() must not be freed. As the wtap_dump_open_tempfile() callers are freeing the returned filename, duplicate the string so it can be freed. Bug: 15377 Change-Id: Ib0b23aaee748ef67600ef3f7d40610ebbbec721c Reviewed-on: https://code.wireshark.org/review/34272 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-08-13Qt: Fix importProfilesFromDir() semanticsTomasz Moń1-2/+3
The default value for skippedCnt is Q_NULLPTR. Do not dereference skippedCnt unconditionally. Change-Id: Ice33a7f9034507f39f16406cc365f39f4e543da5 Reviewed-on: https://code.wireshark.org/review/34271 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-22 23:56:52 +0000