aboutsummaryrefslogtreecommitdiffstats
path: root/ui
AgeCommit message (Collapse)AuthorFilesLines
2017-02-10Clean columns on exit.Dario Lombardo1-0/+1
Change-Id: I950295c35fc67193d9825ebc741da151ad99e077 Reviewed-on: https://code.wireshark.org/review/19941 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-10Convert conversation hash tables to use wmem.Michael Mann3-28/+42
Simplifies cleanup because wmem can handle the memory cleanup. Change-Id: Idc6a9bfe5f23c83b59a5278a64b9fb706862342d Reviewed-on: https://code.wireshark.org/review/20042 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-10service_response_time_table (GTK) fix parameter 'data' not found in the ↵Alexis La Goutte1-1/+1
function declaration [-Wdocumentation] Change-Id: I6079399be6a94d3b718b31c6a21076d092adf580 Reviewed-on: https://code.wireshark.org/review/20049 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2017-02-10response_time_delay_dialog (Qt): Fix warning: parameter 'user_data/data' not ↵Alexis La Goutte1-3/+4
found in the function declaration [-Wdocumentation] Change-Id: I592b35a3ceec477a8269f5cda0c5c363681a36aa Reviewed-on: https://code.wireshark.org/review/20048 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2017-02-08Switch stat tap to use wmem_tree_t instead of (sorted) GSList.Michael Mann6-16/+21
Change-Id: I172167eb20793113562b69d1e0e93a4882200404 Reviewed-on: https://code.wireshark.org/review/20019 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-08Switch follow (tables) to use wmem_tree_t instead of (sorted) GSList.Michael Mann1-3/+4
Change-Id: Iabf354d2533ae429c002b115c5de33b592019997 Reviewed-on: https://code.wireshark.org/review/20018 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-08Switch rtd and srt tables to use wmem_tree_t instead of (sorted) GSList.Michael Mann11-27/+36
Change-Id: I54fec10801eb8f359414f34bf705767964c9725e Reviewed-on: https://code.wireshark.org/review/20017 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-08Switch export objects to use wmem_tree_t instead of (sorted) GSList.Michael Mann4-13/+14
Change-Id: Iaaa7b44954337c7857dbb541b727924e2de57c9d Reviewed-on: https://code.wireshark.org/review/20016 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-08Qt: Add check for valid profile nameStig Bjørlykke2-2/+14
Add check for a valid profile name in the Profile dialog and disable the Ok button and mark the invalid profile if error. The GTK dialog does not close on errors but the Qt dialog does, so ensure the user is informed beforehand. Change-Id: If31ffe75183066cf49e2b5a082112bfe62d6c06e Reviewed-on: https://code.wireshark.org/review/19995 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-02-07ui: Write recent file when applying profile changesStig Bjørlykke1-1/+6
Write the recent file for the current profile before copying or renaming the profile to ensure the latest changes are not lost. Change-Id: Ib07881925b398314da0a9b2ec875da7650b84712 Reviewed-on: https://code.wireshark.org/review/19984 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-02-07Adjust startup count for extcap.Gerald Combs2-2/+2
The number of extcap splash items is the number of extcap binaries plus RA_EXTCAP. Change-Id: I9702da5a94e244ddd95a845a67da9302ee41c826 Reviewed-on: https://code.wireshark.org/review/19981 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-02-07GTK: Wrap static preference labels.Gerald Combs1-2/+5
In the GTK+ prefrences dialog, enable wrapping and set a maximum width. This should keep labels from making the dialog unusably wide. Make a couple of enum preferences drop-downs instead of radio buttons. Note that we might want to make the drop-down vs radio button behavior automatic. Change-Id: Ib72a2c8d5cfb99324be86f2218b6d57a395fa22c Reviewed-on: https://code.wireshark.org/review/19980 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-02-05GTK: Add 'in' operator in display filter expression dialogJaap Keuter1-94/+162
Add the 'in' operator to the list of available operators, where 'eq' operator would be present also. Setup the curly bracket expression in the filter and allow for multiple enums to be selected. Bug: 12808 Change-Id: I42b328bcb3328521d193d9cdae56577eb66f8e15 Reviewed-on: https://code.wireshark.org/review/19913 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-02-05[Automatic update for 2017-02-05]Gerald Combs7-147/+147
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: Ic3553d0e987fc7c0eafbe42a517f46212d137edc Reviewed-on: https://code.wireshark.org/review/19959 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-02-04tap-stats_tree: use wmem allocator.Dario Lombardo1-2/+2
Change-Id: I17e652bf9c6e8a17c57afa0bc7bb909636152d15 Reviewed-on: https://code.wireshark.org/review/19945 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-03Fix builds without libpcap.Guy Harris1-0/+2
capture_opts_cleanup() doesn't exist if we're building without libpcap, so don't call it if we're building without libpcap. Change-Id: I9ae33b0c13af2785b5adb380a5b03e89116f67df Reviewed-on: https://code.wireshark.org/review/19925 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-02-02capture_opts: free memory on exit to avoid leak.Dario Lombardo1-11/+21
This required a restyle of the way the different apps exit. Change-Id: Iedf728488954cc415b620ff0284d2e60f38f87d2 Reviewed-on: https://code.wireshark.org/review/19780 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2017-02-02Qt: Add extcap placeholder parameterStig Bjørlykke1-0/+3
Added a parameter to set placeholder text in textBox. Change-Id: Iccf92fe60abc78be8f0fa112c0c9eb78890674b5 Reviewed-on: https://code.wireshark.org/review/12463 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2017-01-31Add wmem allocator parameter to format_uriMichael Mann1-6/+13
Change-Id: Ic6de84a37b501e9c62a7d37071b2b081a1a1dd50 Reviewed-on: https://code.wireshark.org/review/19885 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-31format_text_wmem -> format_textMichael Mann3-7/+7
All cases of the "original" format_text have been handled to add the proper wmem allocator scope. Remove the "original" format_text and replace it with one that has a wmem allocator as a parameter. Change-Id: I278b93bcb4a17ff396413b75cd332f5fc2666719 Reviewed-on: https://code.wireshark.org/review/19884 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-31format_text -> format_text_wmem for wlan dialogsMichael Mann3-8/+25
format_text_wmem uses NULL scope in GUI dialogs Change-Id: Ifaa342e034de9f99b59169cdf0c7ddc52ff67597 Reviewed-on: https://code.wireshark.org/review/19882 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-30Qt: Use system DateTimeFormat in QDateTimeEditStig Bjørlykke1-0/+1
In extcap argument ExtArgTimestamp set DisplayFormat to system DateTimeFormat. Change-Id: I281d6cc1aa59e785a75d6f1c8ff9780ba5ad9eba Reviewed-on: https://code.wireshark.org/review/19863 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2017-01-29[Automatic update for 2017-01-29]Gerald Combs7-481/+548
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I4a55af48f03ec5940c2a5fd902a57c7b06ac0e37 Reviewed-on: https://code.wireshark.org/review/19839 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-01-27Qt: Add exported packet files to the recent filesStig Bjørlykke1-0/+2
Update the recent files list when exporting specified packets to file. Change-Id: I4e7dd7f943aa99ab9d5f3fd88444d730434970e9 Reviewed-on: https://code.wireshark.org/review/19818 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-01-27Qt: Hide "Go to Packet" frame when closing capture file.Stig Bjørlykke1-0/+1
The "Go to Packet" frame cannot be used without a capture file so ensure we hide this when closing a capture file. Change-Id: I339bc90b87181a8361e9f0bf27dfdf26d2f05333 Reviewed-on: https://code.wireshark.org/review/19783 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-27Qt: Preference editor improvements.Stig Bjørlykke1-9/+4
Use correct disconnect() signature to ensure everything is disconnected before connecting new signals. Without this all previous connects() are still active. This leads to gradually more and more syntax checks being called for each change, and possibility of a wrong syntax check (especially for strings which has no syntax check). Use the textEdited() signal to trigger a syntax check at startup. This gives consistency. Do not clear preferenceLineEdit when done because it looks weird when the preference text disappears while the widget is hiding. The entry is cleared before next show anyway. Change-Id: I21c6fd8ec6bb0ecff1b2c0b66fe97dc3eaecf9b3 Reviewed-on: https://code.wireshark.org/review/19788 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-26Qt: Signal number of active capturesRoland Knall2-2/+17
Adds a signal, which emits the number of active captures Change-Id: I637106294e331e7fc7607f6fd7704492e22fa7ac Reviewed-on: https://code.wireshark.org/review/19799 Reviewed-by: Roland Knall <rknall@gmail.com>
2017-01-26Add 'in' operator in display filter expression dialogJaap Keuter2-15/+29
Add the 'in' operator to the list of available operators, where 'eq' operator would be present also. Setup the curly bracket expression in the filter and allow for multiple enums to be selected. Ping-Bug: 12808 Change-Id: Ibeef52ba9d41549d0684b0069270ff09f5a93e81 Reviewed-on: https://code.wireshark.org/review/19767 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2017-01-25Qt: Use preference editor for port number entriesStig Bjørlykke2-0/+6
After converting port preferences to use Decode As entries the preference editor was no longer used when changing port number pereferences from the Packet Details popup menu. Change-Id: Ifeff3b88bfd96a122b6a58d8917304eb69cf0c38 Reviewed-on: https://code.wireshark.org/review/19781 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-01-24Fix segfault, when only one TSN is capturedruengeler1-6/+24
Change-Id: Ibb6494e1f180ec8187d260245731d33ac16085eb Reviewed-on: https://code.wireshark.org/review/19745 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-23GTK+: Yell at the user less.Gerald Combs3-6/+6
Change some exclamation points in error and warning messages to periods. Change-Id: Ie084c40cf54362b43462bf4f6a29134caa101387 Reviewed-on: https://code.wireshark.org/review/19744 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-01-23tcp_graph (Gtk) Fix Dereference of null pointerAlexis La Goutte1-2/+2
Change-Id: Ie07ed9f2bcf719340ea607d679620916aa93ba72 Reviewed-on: https://code.wireshark.org/review/19736 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-23Qt: Reject drag and drop if we're capturing.Gerald Combs2-5/+18
Ignore drag enter events in the main window and warn the user if we can't open files (which presumably means we're in the middle of a capture). Don't yell at the user in the corresponding GTK+ code. Change-Id: Iffb5df5969c7ff76a854247b4b8d10d0e4b02e70 Reviewed-on: https://code.wireshark.org/review/19734 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-22[Automatic update for 2017-01-22]Gerald Combs7-1415/+1795
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I75ec9ed3b0ef02d18dee79f629291e7bc1c81467 Reviewed-on: https://code.wireshark.org/review/19726 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-01-22Qt: Add Goodput graph (ACK rate), and minor bug fixesKevin Hogan4-58/+592
Add Goodput graph: - measures rate of ACKed bytes (including SACKed bytes) - useful to compare to throughput during slow-start to estimate bottleneck rate Add graph selection checkboxes to multi-plot graphs: - most important for Throughput, since there are good cases for showing a subset of graphs at once - also added for Window Scale, since the addition is similar to that for Throughput Minor bug fixes: - allow zoom rect to work when growing in any direction (not just right and up) - keep stray mouse clicks from re-doing a previous zoom - hide rubber band if active when keypress changes mouse mode to drag - allow mouse clicks on open space or grpah to return to default focus (i.e. focus on graph) Change-Id: Id29356ceec810ebdbed9c3c0d8415416401fe643 Reviewed-on: https://code.wireshark.org/review/19718 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-01-22Internalize struct preferenceMichael Mann16-532/+373
Move "struct preference" into prefs.c, essentially creating a "private" structure to handle preferences. The 2 motivating factors were: 1. Better memory management so that clients/users of API don't have to worry about it. 2. Hide the ugliness of the union stuff and make it transparent to the API. A few bugs related to preference <-> Decode As integration were fixed while in the neighborhood. Change-Id: I509b9a236235d066b139c98222b701475e0ed365 Reviewed-on: https://code.wireshark.org/review/19578 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-22Qt: Implement Custom CMakeRoland Knall2-0/+40
Implement the custom cmake calls analog to the gtk version Change-Id: I426d2a2df5a4bfb6fc385b970e3944415d3c8afd Reviewed-on: https://code.wireshark.org/review/19563 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-21One more cf_merge_files_to_tempfile() call needed to be changed.Guy Harris1-2/+3
Change-Id: Id109e316714fd1c4843f9ffe1b866ec0e5f5c126 Reviewed-on: https://code.wireshark.org/review/19719 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-01-21Qt: Fixup drag and drop merging.Gerald Combs3-8/+41
Make the behavior of MainWindow::dropEvent match the documentation and dnd_open_file_cmd. If we've been passed a single file, open it. If we've been passed multiple files, merge them first. Add an is_tempfile parameter to openCaptureFile. Add a note about setting the drop description on Windows. Bug: 12129 Change-Id: I325a4da5a29e940b4efa7654627d8bcafba15b57 Reviewed-on: https://code.wireshark.org/review/19717 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-21Qt: Show merge progress.Gerald Combs8-7/+40
Add "file merge" callback plumbing. Use it to display "Merging files" in the main statusbar. Make sure we have a usable window pointer when we merge files. Change-Id: I236b6edb30685f0b06703ab8304bc88ae592f83c Reviewed-on: https://code.wireshark.org/review/19716 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-20tap-tcp-stream.h: fix double declaration introduced in g73b5e3dPascal Quantin1-16/+0
Change-Id: I2656e323b9ea6d41566ab0cef1e4a94e3591b08c Reviewed-on: https://code.wireshark.org/review/19687 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-01-20Qt: Fix a sequence dialog crash.Gerald Combs1-1/+2
If gui.geom.SequenceDialog.maximized is TRUE, loadGeometry will trigger a resize event, which will in turn call resetAxes. Call loadGeometry after we've initialized our various QCustomPlot bits so that resetAxes doesn't crash. Bug: 13329 Change-Id: I4d27683fb3eee0a7c897800401bfa3869e97662b Reviewed-on: https://code.wireshark.org/review/19683 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-20Qt: modify RTT graph (handle GSO, SACK, etc), plus bug fixesKevin Hogan5-57/+224
Modifications to RTT graph: - change x-axis to time (s) rather than sequence number [ avoids sequence number wraparound ambiguity, plus easier to correlate RTT changes to tcptrace graph ] - change RTT computation to properly handle acks to GSO packets - change RTT computation to take SACK blocks into account Bug fixes: - eliminate potential memory leak if some packets are unacked - ensure RTT graph is shown if TCPGraph window is opened to it directly Change-Id: I2bdcab97399ebde0f15c78fa19c882529a814580 Reviewed-on: https://code.wireshark.org/review/19662 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-19Qt: add graph of unacked (outstanding) bytes to window scale graphKevin Hogan2-10/+52
This metric is commonly used as an estimate of the sender's congestion window. [ when examining a capture taken from the sender ] Change-Id: I812d5556cef477c08ef1e5d396fbdddda9a6751e Reviewed-on: https://code.wireshark.org/review/19661 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2017-01-18Fix Access Violation in plugin_if_mainwindow_get_ws_info(...)Paul Offord2-2/+2
Call to plugin_if_get_ws_info when no packets are being displayed causes an Access Violation in plugin_if_mainwindow_get_ws_info as the pointer in cf->current_frame is NULL. Bug: 12973 Change-Id: I33e8fe6f3894963a6f1f1ec9aa9169f85e1e3b18 Reviewed-on: https://code.wireshark.org/review/19659 Reviewed-by: Roland Knall <rknall@gmail.com>
2017-01-15[Automatic update for 2017-01-15]Gerald Combs7-1008/+1008
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: Ia487718c34913b5bb8297184fedb6c7ecaf604e6 Reviewed-on: https://code.wireshark.org/review/19637 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-01-13Qt: fix memory leaks in UatDialogPeter Wu1-1/+9
Avoid leaking memory for the stringified UAT field values (tostr) and for copies of rows. Change-Id: I1bf20035fabe92da8216c820bc47ebce7dd73951 Reviewed-on: https://code.wireshark.org/review/19604 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2017-01-12Make sure ui/qt/variant_pointer.h gets distributed.Guy Harris1-1/+2
Change-Id: I3bbfaf392da346e937b5a1914c140d1114e3091e Reviewed-on: https://code.wireshark.org/review/19618 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-01-12Qt: Remove unneccessary Q_DECLARE_METATYPERoland Knall29-186/+223
Remove unnecessary Q_DECLARE_METATYPE macros and replace calls to QVariant conversions with VariantPointer where necessary Change-Id: Ia4690590095f930bf94644197de7fa30b00ee7ec Reviewed-on: https://code.wireshark.org/review/19611 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2017-01-12Qt: fix memleak of PointList in interface statisticsPeter Wu4-27/+18
The list of points (for interface traffic statistics) is part of the interface tree model/view. Remove the pointer indirection to simplify cleanup and avoid leaking a PointList. Note that the SparkLineDelegate is used in two different places (CaptureInterfacesDialog and InterfaceTreeModel). Change-Id: I5fef7dadd44fdf58c07844fee269f509c712a36f Reviewed-on: https://code.wireshark.org/review/19606 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-02 01:46:36 +0000