aboutsummaryrefslogtreecommitdiffstats
path: root/ui
AgeCommit message (Collapse)AuthorFilesLines
2018-03-18Qt: allow keyboard navigation in Unsaved packets dialogPeter Wu2-0/+4
Currently the "Continue without Saving" button is visually highlighted in the "Unsaved packets..." dialog, but pressing Enter triggers "Save" instead. Even after changing button focus with arrow or tab keys, pressing Enter will not confirm the action (but Spacebar does). Restore the expected behavior for Linux and Windows, but preserve the fix for macOS since (for which this was originally added). Bug: 14531 Change-Id: Ic20fc5809b55949f6fd960bcb32618a4fa7fd1e9 Fixes: v2.3.0rc0-2672-gb0335359e5 ("Qt: Give discard button focus (but not as default)") Reviewed-on: https://code.wireshark.org/review/26511 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-03-18[Automatic update for 2018-03-18]Gerald Combs7-60/+28
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I9424882cb781156d38c634b91defcd45cd3f4743 Reviewed-on: https://code.wireshark.org/review/26528 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-18Qt: ensure field is visible on selection from bytes viewPeter Wu4-73/+5
Ensure that a selected field (via selectedFieldChanged) becomes visible in the packet details view when selected from the bytes view (or when found via a search). As making a field always visible seems a desirable feature (and in the interest of simplifying preferences), enable this by default using the smarter EnsureVisible hint. Remove the associated preferences and mark them GTK+ only. Change-Id: I05a918c1e09135c0b4e10f04024bff092756e55c Fixes: v2.5.0rc0-2383-g6b2764a41e ("ProtoTree behavior fixes.") Reviewed-on: https://code.wireshark.org/review/26509 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-17tap-tcp-stream: fix indentation.Dario Lombardo1-17/+22
Change-Id: I9ec60866dc674d9ec682afc6d644d78255182cac Reviewed-on: https://code.wireshark.org/review/26526 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-17tap-tcp-stream: replace some g_malloc with g_new.Dario Lombardo1-3/+3
Change-Id: I25414be8ea73b986ea84294686a1d97159e1e2c7 Reviewed-on: https://code.wireshark.org/review/26525 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-17tap-iax2-analysis: fix minor indentation issues.Dario Lombardo1-5/+9
Change-Id: I778fb32450e43a28b15e78e1e90ed7b69d4f341a Reviewed-on: https://code.wireshark.org/review/26524 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-17tap-sctp: replace g_malloc with g_new.Dario Lombardo1-15/+15
When allocating structs this increases a lot the code readability. Change-Id: I86b26ea3debb400d6e1e8012206008740e528b23 Reviewed-on: https://code.wireshark.org/review/26523 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-17tap-sctp: remove guint32 unneeded allocations.Dario Lombardo1-9/+6
They've been replaced by direct cast. Change-Id: I99fbc0463af724dc2592fbfe24a63c645902c703 Reviewed-on: https://code.wireshark.org/review/26522 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-15Qt 4.8 compatibility for escaping HTMLPeter Wu1-4/+4
Change-Id: I63fb59190b510b08db588ee8fe828f5df345d83a Fixes: v2.5.0rc0-2548-gf5a8711ef1 ("Qt: About dialog updates.") Reviewed-on: https://code.wireshark.org/review/26486 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-15Epan+Qt: Invalidate cached column strings.Gerald Combs7-12/+32
Add col_data_changed, which checks to see if we have updated column info. Add col_append_frame_number, which adds a frame number and sets col_data_changed. Call col_append_frame_number instead of col_append_fstr from some dissectors. Add PacketListRecord::invalidateAllRecords, which invalidates any cached record data. Add PacketListModel::invalidateAllColumnStrings which calls invalidateAllRecords and signals that our data has changed. Call invalidateAllColumnStrings when we have new name resolution or column information. Bug: 11414 Bug: 11468 Change-Id: I2671594a722f4f9436fe1df84d43489a148e0cee Reviewed-on: https://code.wireshark.org/review/26373 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-03-15tap-sctp: remove leak of sack and tsn (found by clang).Dario Lombardo1-1/+8
Change-Id: I829f117f8e19f60d34104730fbb0bc4504f231dd Reviewed-on: https://code.wireshark.org/review/26434 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-15tap-sctp: remove leak of tmp_info (found by clang).Dario Lombardo1-1/+7
Change-Id: If2eff49d5cf2ec4c0df5e9cafc1c69383502d8ae Reviewed-on: https://code.wireshark.org/review/26433 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-15tap-sctp: rework the memory allocations.Dario Lombardo1-121/+35
Change-Id: Iafab07cd5f83e94e92ef31d0183c42c6ec0c797c Reviewed-on: https://code.wireshark.org/review/26419 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-12Remove some unused or hard-coded header checks.Gerald Combs1-2/+0
Remove some unused checks and code found using grep -o 'HAVE_[A-Z0-9_]*' ConfigureChecks.cmake | sort -u \ | while read have_h ; do echo = $have_h ; git --no-pager grep -cl $have_h ; done Change-Id: I86bfcfdc4f60d9d7de87017a7bb00f833a79bd2c Reviewed-on: https://code.wireshark.org/review/26451 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-12Qt: Implement MulticastStatisticsDialog::treeItemDataGerald Combs2-0/+12
Implement MulticastStatisticsDialog::treeItemData so that the "Copy" button works. Bug: 14477 Change-Id: I8e7ff2a41b0f14e600b0781c3a01e03270c26ae7 Reviewed-on: https://code.wireshark.org/review/26430 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-11[Automatic update for 2018-03-11]Gerald Combs7-109/+35
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Iac7e2b50ed60639dde90946632811753288110d6 Reviewed-on: https://code.wireshark.org/review/26421 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-10Don't put a comma after the last item in an enum list.Guy Harris1-1/+1
C prior to C99 and C++ prior to C++11 don't allow a comma there; we require C99, at least on UN*X, but don't require C++11. Change-Id: Ia652de44315d4d87e75f583317b7b1069c8804e7 Reviewed-on: https://code.wireshark.org/review/26411 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-03-09spdx: use consistent formatting for GPL-2.0-or-laterPeter Wu4-4/+4
Change-Id: If8ffe67f6b624d7f1bcaa278a146e41247720226 Reviewed-on: https://code.wireshark.org/review/26393 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-03-09Plug a leak.Guy Harris1-1/+1
"field" might be allocated even if the calculation type is CALC_TYPE_BYTES, CALC_TYPE_FRAMES, or CALC_TYPE_FRAMES_AND_BYTES. Change-Id: I0c70397a89e32172769c277bebfd950f1d21c679 Reviewed-on: https://code.wireshark.org/review/26378 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-03-09When looking up response codes, just keep the key on the stack.Guy Harris1-10/+10
We don't need to dynamically allocate a guint variable to hold the response code value - and then not bother to free it! - if we're just doing a lookup; we can use an automatic variable and pass a pointer to it. Change-Id: I6edbb352f0aa33c91ede0f4e1bbb962fa921bea2 Reviewed-on: https://code.wireshark.org/review/26375 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-03-07Qt: remove leak in simple_statistics_dialog (found by clang).Dario Lombardo1-4/+6
Change-Id: Ie1b6d6e8039eeaeb08f2d59c21a88298d55ea797 Reviewed-on: https://code.wireshark.org/review/26145 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-07Qt: remove leak from protocol_preferences_menu (found by clang).Dario Lombardo1-7/+11
Change-Id: I8ea4f550cbce934335e8d8e7d7c6b5fba7bcacfe Reviewed-on: https://code.wireshark.org/review/26141 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-03-07spdx: more licenses converted.Dario Lombardo4-52/+4
Change-Id: I3861061ec261e63b23621799e020e811ed78a343 Reviewed-on: https://code.wireshark.org/review/26333 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-07Qt: rework routine in module_preferences_scroll_area.Dario Lombardo1-2/+5
This removes a check that confuses clang and generates a false poritive. Change-Id: Ib28b88b40e16ad300ba6d3df8334bd752a4fa7f1 Reviewed-on: https://code.wireshark.org/review/26171 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato@gmail.com>
2018-03-07Qt: Handle UAT editor dialogs explicitly.Michael Mann6-82/+181
QAbstractItemView assumes that editors are widgets, not windows. QAbstractItemView::edit calls QAbstractItemViewPrivate::openEditor, which simply calls show() and setFocus() on the editor widget. If that widget happens to be a native dialog, its event loop might not be processed. This is the case on macOS at least. Create widgets derived from QLineEdit that edit the value directly along with a button that can open the associated modal dialog. Install event filters so that we keep the correct tab behavior between fields of the UAT. Bug: 13958 Ping-Bug: 14031 Bug: 7761 Change-Id: Ie5f0a5cbde33bb9add8217029c2063a0bbfd804a Reviewed-on: https://code.wireshark.org/review/23015 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-03-07Plug another leak for Wiretap errors.Guy Harris1-8/+10
Clean up comments while we're at it. Change-Id: I7e218ba3f998804045e3d7fab08d85d09a293d69 Reviewed-on: https://code.wireshark.org/review/26320 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-03-07failure_message.c: fix a memory leak if err is not negativePascal Quantin1-5/+3
Bug: 14489 Change-Id: I958cfae824c50263913ba9df8128e34e9466cb67 Reviewed-on: https://code.wireshark.org/review/26294 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: ronnie sahlberg <ronniesahlberg@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-07NSIS, WiX: Handle the presence or absence of mmdbresolve.Gerald Combs1-9/+7
Only install mmdbresolve if MAXMINDDB_FOUND is true. Fixup the Qt about box and WiX GTK defines while we're here. Change-Id: I7ac3c21ddb4aebc1dae1c3d8cfd2bcafc4139d2e Reviewed-on: https://code.wireshark.org/review/26299 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-06Transition from GeoIP Legacy to MaxMindDB.Gerald Combs4-134/+77
MaxMind is discontinuing its legacy databases in April in favor of GeoIP2, which use a newer database format (MaxMind DB). The reference C library (libmaxminddb) is available under the Apache 2.0 license which isn't quite compatible with ours. Add mmdbresolve, a utility that reads IPv4 and IPv6 addresses on stdin and prints resolved information on stdout. Place it under a liberal license (MIT) so that we can keep libmaxminddb at arm's length. Add epan/maxmind_db.[ch], which spawns mmdbresolve and communicates with it via stdio. Migrate the preferences and documentation to MaxMindDB. Change the IPv4 and IPv6 asnum fields to FT_UINT32s. Change the geographic coordinate fields to FT_DOUBLEs. Bug: 10658 Change-Id: I24aeed637bea1b41d173270bda413af230f4425f Reviewed-on: https://code.wireshark.org/review/26214 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-04coloring rules dialogue: remove unused signalMartin Kaiser1-2/+0
View / Coloring Rules... shows this warning 12:02:26.401 Main Warn QObject::connect: No such signal ColoringRulesModel::dragDropComplete() in ../ui/qt/coloring_rules_dialog.cpp:61 12:02:26.401 Main Warn QObject::connect: (receiver name: 'ColoringRulesDialog') Remove the unused signal. Change-Id: Id42c249ac9252269eb31e4971e62e927a28c88ed Reviewed-on: https://code.wireshark.org/review/26239 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2018-03-04[Automatic update for 2018-03-04]Gerald Combs7-36/+21
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I95feebf818e68804d287e011f4c6ee2cd244b2f3 Reviewed-on: https://code.wireshark.org/review/26254 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-03Move what capture_info_close() does into its only caller.Guy Harris1-2/+5
Change-Id: If9539142100fb2079cbbe247d8975778b183ece8 Reviewed-on: https://code.wireshark.org/review/26235 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-03-03More indentation cleanups.Guy Harris1-13/+13
Change-Id: If24cf44a1ba9772d8fe2e026d19e6838cf8e0949 Reviewed-on: https://code.wireshark.org/review/26234 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-03-03Clean up indentation.Guy Harris1-2/+2
Change-Id: Id3d84d33590b12a91f15e7c2d8af350fb630b7b2 Reviewed-on: https://code.wireshark.org/review/26233 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-03-03Fix a warning message.Guy Harris1-1/+1
Change-Id: Ice2ed63bb3785323949c466a67b287fd4f80fd12 Reviewed-on: https://code.wireshark.org/review/26232 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-03-03Remove declaration of routine that no longer exists.Guy Harris1-3/+0
The routine was removed in Id302e88bed4da8b9b457049fb78b0bc7d7ffabe3. Change-Id: I1874be1cb666d42011cc9b4ab9360dc885d3622c Reviewed-on: https://code.wireshark.org/review/26231 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-03-02Remove the endpoint "Map" feature.Gerald Combs5-395/+0
Remove the endpoint map and its button from the Qt and GTK+ UIs. It depends on GeoIP Legacy for coordinate information and those databases are being deprecated in favor of MaxMind DB. We *could* upgrade the code to use mmdbresolve, but according to https://dev.maxmind.com/geoip/geoip2/geolite2/ they're also going to remove coordinate information from GeoLite2: "In addition, in 2019, latitude and longitude coordinates in the GeoLite2 databases will be removed.* Latitude and longitude coordinates will continue to be provided in GeoIP2 databases. Please check back for updates." Change-Id: I43e1593d282a0f1aae897b1f4724117d1496b21e Reviewed-on: https://code.wireshark.org/review/26229 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-03-02extcap: Make settings dialog modalRoland Knall1-0/+1
Otherwise dialogs could be opened multiple times Change-Id: I19f9c11395b5f5ba41c00ff78ab9794064562d29 Reviewed-on: https://code.wireshark.org/review/26221 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-03-01Windows: Remove cruft for unsupported versonsGraham Bloice2-12/+7
Remove all the existing LoadDLL\GetProcAddress combinations that allowed conditional Win32 API usage if supported on the running OS version. All the required functions are present in the versions we support. Change-Id: Ibc43e51cefcd1c7562d4e251784362509f224ed6 Reviewed-on: https://code.wireshark.org/review/26215 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2018-03-01Qt: Make we shut down cleanly when exiting early.Gerald Combs5-14/+25
Add an exit_application() routine that calls wsApp->quit() + exit() in the Qt UI and exit() in the GTK+ UI. Make sure we call it instead of exit() when needed. Bug: 14395 Change-Id: I171b5fd19ce4664db4a2ebb4b8c33e278dcec427 Reviewed-on: https://code.wireshark.org/review/26121 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-28Fix StringCchPrintf() calls.Guy Harris1-3/+4
One was missing an argument; supply the necessary string. The other was assuming that an LPARAM was 32 bits when that's not the case on 64-bit Windows - the underlying value is 32-bit, so we just cast to int. Change-Id: Ie2a38e27f2ea211628d2c751a7807bb9ed396c64 Reviewed-on: https://code.wireshark.org/review/26190 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-28rtspstat: use integer cast in g_hash_table.Dario Lombardo1-16/+13
Change-Id: I5ebdbe5a94ed377c120411c46daca3903036fe42 Reviewed-on: https://code.wireshark.org/review/26140 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-02-27Qt/USB: Allow USB src/dst addresses to be selected for columnsPeter Wu1-5/+17
Make "Prepare a Filter" from the Source and Destination columns work for USB source and destination address, this value must be quoted as well. Change-Id: Ib7a772050c204e716781cc27f9eddbdb7971e547 Reviewed-on: https://code.wireshark.org/review/26096 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-27Allow hexadecimal and octal numbers for tshark Decode AsPeter Wu1-11/+35
tshark(1) documents "-d ethertype==0x0800" which suggests that hexadecimal values must be accepted. While at it, be a bit more stricter about the selector match (previously "1-2 junk" was accepted too, reject trailing spaces now). Change-Id: I85fbd2f55eaef51902ddaf2e559ab08ad59a5af7 Reviewed-on: https://code.wireshark.org/review/26089 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-27Qt: accept hexadecimal input in Decode As dialogPeter Wu2-6/+6
The usb.product dissector table displays vendor+product values as hexadecimal, ensure that these are not parsed as zero. While at it, clarify the meaning of the model contents. Ideally the model should store numeric selectors as integers rather than strings, but that requires more work. Change-Id: I3bb17ad0d0a03c8813ded4ea6890dbc2aedd738d Reviewed-on: https://code.wireshark.org/review/26087 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-25[Automatic update for 2018-02-25]Gerald Combs6-130/+14
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I543fa77cb9f26353fe3ea64f5e236d540d971a90 Reviewed-on: https://code.wireshark.org/review/26091 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-02-24Rename airpdcap to dot11decrypt.Gerald Combs3-42/+42
Our 802.11 decryption code isn't tied to any specific product. Change the file and API names to dot11decrypt. Change-Id: I14fd951be3ae9b656a4e1959067fc0bdcc681ee2 Reviewed-on: https://code.wireshark.org/review/26058 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-02-22Qt+Windows: Adjust our DBAR check logic.Gerald Combs1-1/+2
Don't bother fetching a file's version if its name doesn't match any of the DBAR DLL list entries. Otherwise we try to open a bunch of DLLs we don't care about. Change-Id: Icab11450839195c1259bb307ae88988f52917487 Reviewed-on: https://code.wireshark.org/review/25973 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-22Qt: Improve our capture filter completions.Gerald Combs1-18/+69
Use libpcap's pcap-filter.manmisc to create our capture filter completion list instead of scanner.l. Bug: 14430 Change-Id: I11f6eb5679dc93561dce62f28149e103ac9b4a2b Reviewed-on: https://code.wireshark.org/review/25971 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-21Squelch some cating-away-constness warnings.Guy Harris1-11/+11
Change-Id: I1ebe9b42957e0db5cc04f44e31f291cb40ba14e1 Reviewed-on: https://code.wireshark.org/review/25960 Reviewed-by: Guy Harris <guy@alum.mit.edu>