aboutsummaryrefslogtreecommitdiffstats
path: root/ui
AgeCommit message (Collapse)AuthorFilesLines
2015-04-15Set the extcap working directory on Windows.Gerald Combs1-13/+0
On Windows, prepend the main program directory to %Path% when spawning extcap processes. This lets us place androiddump in extcap while allowing it to locate its DLLs. Change-Id: I406c47ce71323266d5f14fb596931398464e452d Reviewed-on: https://code.wireshark.org/review/8057 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-04-14UI: Implementing menus for pluginsRoland Knall4-1/+329
Plugins may utilize the tap interface to provide special tools or analysis options, not otherwise available in Wireshark, or perhaps not allowed to be distributed freely. Up until now, those tools either had to start automatically, or could not be started at all, or had to be started separately. It should be possible, that those tools may be started using a menu entry directly from Wireshark. This interface tries to achieve exactly that. This interface uses a clean interface, which can be implemented in any plugin or dissector. Documentation for this has been added to README.plugins. Separators are only supported for now in the Qt interface, but URLs can now be added as a simple item, and the UI will use the same methods used for other URL calls to open them. Change-Id: I170107dafb66f6badaa864d05a9091e5cbbf52c2 Reviewed-on: https://code.wireshark.org/review/7865 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-13Qt: Add option to copy all visible item or selected tree items in Packet ↵Michal Labedzki4-1/+65
Details pane The idea is allow to copy data from GUI by user, what is currently case only for tshark. The first option copy every item from Packet Details that are expanded (visibled). The second option do the same but start on currently selected item/tree. (let think about protocols like BT SDP where there is a lot of recursive subtrees) Change-Id: I19c925d21293ceb8af2167c7d2c1b1b36507124e Reviewed-on: https://code.wireshark.org/review/8047 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-04-12Windows: fix generation of PortableApps.com installerPascal Quantin1-0/+15
Change-Id: I249268ce21ddfbdc7f149609a950736b4fe2ae07 Reviewed-on: https://code.wireshark.org/review/8036 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-04-12[Automatic update for 2015-04-12]Gerald Combs8-213/+255
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: Ide45514d6fd320962b642ed7c86bca959f2c58f7 Reviewed-on: https://code.wireshark.org/review/8029 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-04-07Qt: fix maximized state applyPascal Quantin1-1/+1
Preferences are not loaded yet when we call MainWindow::loadWindowGeometry() Anyway, prefs.gui_geometry_save_maximized should only be checked when saving preferences (MainWindow::saveWindowGeometry() method) like what we do in GTK UI Change-Id: I8eb01a5f4f7672fbf5846bc576584e28f72d5e31 Reviewed-on: https://code.wireshark.org/review/7978 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-04-07Byte view tab (Qt): Fix Dead Store (Dead assignement/Dead increment) warning ↵Alexis La Goutte1-22/+0
found by Clang Remove unused bmask variable Change-Id: I44613f1d949dbaf8e559b3bfb2196609d821c4f3 Reviewed-on: https://code.wireshark.org/review/7496 Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-04-06See if this squelches warnings when compiling without libpcap.Guy Harris1-1/+1
Change-Id: I29441ff47365e302b0ef6dfd54e94f4bf1def08a Reviewed-on: https://code.wireshark.org/review/7958 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-04-06Show a count in the status bar for all captures.Guy Harris5-0/+25
(I'd have said "for non-update-list-of-packets-in-real-time captures", but that's too long for the holy Git "first line of the commit message is a summary" rule.) For non-update-list-of-packets-in-real-time captures, show a packet count in the status bar. Change-Id: I31670770e3772e9f772f0c9a6438fc6d053560aa Reviewed-on: https://code.wireshark.org/review/7957 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-04-06Use zlib 1.2.8 on Windows.Gerald Combs1-1/+1
Change-Id: I3df88b1e891f43cd6b6ed089f6c3d20a942e68bc Reviewed-on: https://code.wireshark.org/review/7952 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-04-06Reset the captured-packet count when we start or restart a capture.Guy Harris1-0/+1
Bug: 6217 Change-Id: I916e9a6fdb0e114d5f8f123153c213af9273bbc3 Reviewed-on: https://code.wireshark.org/review/7954 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-04-06Keep a captured-packet count in a capture_session and use that.Guy Harris2-11/+3
Have the count in a cfile_t structure always reflect the actual number of packets that have been read from the file, rather than, when doing a non-update-list-of-packets-in-real-time capture, falsely increasing the count in the cfile_t to reflect the number of packets captured but not yet read. Have the status bar base its captured-packet count on the count in the capture_session structure, and base the "sorry, no packets were captured" message on the count in the capture_session structure, as we're no longer using the count in the cfile_t structure to count anything in the process of a non-update-list-of-packets-in-real-time capture. That way, we preserve the invariant that the "frames" member of a cfile_t will be non-null if the "count" member is non-zero, fixing bug 6217. It also means we can get rid of cf_set_packet_count(), as we only set the count in the capture-file-reading code. Bug: 6217 Change-Id: I72c0e2c07c30782bad777995370b7c19e1460cc2 Reviewed-on: https://code.wireshark.org/review/7950 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-04-06Show a list of interfaces on the welcome screen when capturing.Guy Harris2-21/+27
In a non-update-list-of-packets-in-real-time capture, once the capture starts, put up a message on the welcome screen indicating on what interfaces we're capturing, rather than leaving the "waiting for stuff to arrive from dumpcap" message up. Make some routines not used outside main_welcome.c static while we're at it. Change-Id: I461dd1333d3fa2b64f20310f7b77b45578f9b40d Reviewed-on: https://code.wireshark.org/review/7942 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-04-05Have a common routine for constructing strings listing interfaces.Guy Harris5-82/+73
We have a bunch of duplicated code to make those lists; make a common routine for that. (dumpcap currently doesn't use it, as the routine in question uses a routine in libui, which dumpcap doesn't use. We should probably fix that.) Change-Id: I9058bf3320d420b8713e90743618972da1d1c6ed Reviewed-on: https://code.wireshark.org/review/7934 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-04-05Pop the welcome screen message when we close a file.Guy Harris1-1/+8
That fixes a bug where the welcome screen gets stuck at "Waiting for capture input data..." if you do a non-update-list-of-packets-in-real- time capture, stop the capture, and close the capture. Change-Id: Ia77900707c6287e091a1acd2a6640462e0e4fb37 Reviewed-on: https://code.wireshark.org/review/7931 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-04-05Give the welcome screen its own set of callbacks.Guy Harris6-7/+157
Don't have the status bar code know about the welcome screen; instead, give the welcome screen its own callbacks, so that it can modify the welcome screen as appropriate. Change-Id: Id38d66edeaea085f114b47d6361312450435b58a Reviewed-on: https://code.wireshark.org/review/7927 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-04-05[Automatic update for 2015-04-05]Gerald Combs8-194/+194
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: If98edeab7a413c33e54fbd579e975da26993a380 Reviewed-on: https://code.wireshark.org/review/7922 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-04-05Remove epan member from PacketWinData and just use cfile.epan when ↵Michael Mann1-7/+5
redissecting a packet window. A pointer to cfile.epan was saved by the window when it's created, but any redissection will remove the epan_session used by cfile.epan underneath the window, so let's just use cfile.epan directly. Bug: 11043 Change-Id: Ie6b85708025f8ab7d5e5dc48ad99fee0931af472 Reviewed-on: https://code.wireshark.org/review/7915 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-04-04Fix another capture_dev_user_pmode_find() call.Guy Harris1-1/+1
Missed by the previous commit. Change-Id: I0882e2cf7a734f93e59dbfd1aab564a2fd65d316 Reviewed-on: https://code.wireshark.org/review/7917 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-04-04Let capture_dev_user_pmode_find() say "not found".Guy Harris6-14/+25
"Not found" is different from "found, and false". Have it return a boolean "did I find the property" indication and, if it did, supply the property value through a pointer. Change-Id: Iaa942ea346410b35e512ff1a3821cbf60c88dfd6 Reviewed-on: https://code.wireshark.org/review/7916 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-04-03TX: Update translations (Manual sync 2015-04-03)Alexis La Goutte11-814/+845
Change-Id: I8f7860707fea0bfb6b2ff36fb445cf4e91917e06 Reviewed-on: https://code.wireshark.org/review/7890 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-04-01Qt: Add Capture Restart featureMichal Labedzki2-0/+8
Change-Id: Ied33dd43bb16660aec7063ddf81982ee48226e9e Reviewed-on: https://code.wireshark.org/review/7737 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-03-29Extcap: fix USBPcap capture broken by g8204578Pascal Quantin1-2/+7
g8204578 was not the right way to do things: if_type is used to identify an extcap interface Change-Id: Iead6c5e63f6874012c27ed7c1bf7152a5891ad65 Reviewed-on: https://code.wireshark.org/review/7849 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-03-25Generate the filter using _ws.expert.message instead of expert.messageMichael Mann1-10/+10
Bug: 11073 Change-Id: Ie98d52561b7aebe6875392cf3efeb22adb2ac499 Reviewed-on: https://code.wireshark.org/review/7813 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-03-25Have a #define for whether the capture buffer size can be set.Guy Harris8-64/+56
It can be set if either 1) this is Windows (where we're assumed to be using WinPcap, which includes calls to set the buffer size) or 2) we have pcap_create() (in which case we also have pcap_set_buffer_size(), at least in a normal libpcap release). Use that rather than testing "defined(_WIN32) || defined(HAVE_PCAP_CREATE)"; that makes it a bit more obvious what's being tested. Change-Id: Id9f8455019d19206b04dd6820a748cb97ae5ad12 Reviewed-on: https://code.wireshark.org/review/7816 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-03-25OK, this appears to be what's intended.Guy Harris1-4/+29
Include a column to describe what's intended. If that's *not* what's intended, fix the comment and the twisty little maze of #defines. Change-Id: Ic5d120c401d8aba23a19e9d042b1460621b80e0b Reviewed-on: https://code.wireshark.org/review/7815 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-03-25Clean up handling of buffer size.Guy Harris1-40/+40
Instead of a twisty little maze of #if, #ifdefs, and #elifs, all different, define HAVE_BUFFER_SIZE upfront iff we can set the buffer size - i.e., if this is Win32, and thus we're using WinPcap, or if we have pcap_create() and thus pcap_set_buffer_size() - and use that to govern whether to have a buffer size setting or not. Always put the buffer size setting in the right vertical box. If that doesn't work well for some configurations of available interface knobs, feel free to change the checks, but please make it less opaque what's going on (include a comment if necessary). Change-Id: I384c601982b470ae08de271431eac06d6c925332 Reviewed-on: https://code.wireshark.org/review/7814 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-03-24Win32: Compilation error if winpcap remote capturing disabledRoland Knall1-1/+3
If HAVE_PCAP_REMOTE is not set, this code is not defined and therefore will not be compiled correctly. Change-Id: Ie08a6f99598d46cfa38e2448ea979a8a9aa7c7fc Reviewed-on: https://code.wireshark.org/review/7803 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-03-23Centralize the code to set the active_dlt value for a device.Guy Harris5-24/+66
We were doing it similarly, but not the same, in several places; make a common routine for it. Have that code check to make sure the DLT_ value in question is actually supported by the device; if not, pick the first supported DLT_ value, if any; this keeps it from, for example, picking a bad DLT_ value if your defaults were set based on monitor mode being on but monitor mode actually being off, or vice versa. Change-Id: I1722bfeaf60429bc5c6f665fdea3d466052b13bd Reviewed-on: https://code.wireshark.org/review/7795 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-03-21Rename update_interface_list() and remove local interface code from it.Guy Harris1-25/+15
It's only used to update the remote interface list, and never updates anything else (it sets iftype_id to CAPTURE_IFREMOTE and never changes it, so all tests for whether iftype_id is == or >= CAPTURE_IFREMOTE succeed); remove the code that would be executed if, somehow, iftype_id got stomped on, and rename it to update_remote_interface_list(). Change-Id: I3bd80fb19bb14ef5bdf2c1a77a10f1f32bb62aba Reviewed-on: https://code.wireshark.org/review/7773 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-03-19Try to fix interface property fetching.Gerald Combs1-11/+6
Use g_strdup instead of calculating string lengths manually. Return NULL for empty strings, otherwise lo0 shows up as ": lo0" instead of "Loopback: lo0" here. Change-Id: I143aa5e12c9512b7a9f4729b62b353c13ee3635a Reviewed-on: https://code.wireshark.org/review/7764 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-03-19Make the snapshot-length member of interface_t an int.Guy Harris1-2/+0
That matches what it is in other structures, and eliminates a compiler warning. While we're at it, remove an empty if statement revealed by that change. Change-Id: I5e8c8f92fdb3567e75800c729443737032a1bcc7 Reviewed-on: https://code.wireshark.org/review/7752 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-03-19Fix another call to capture_dev_user_snaplen_find().Guy Harris1-2/+3
Change-Id: I20064f782b7ad8ebffc70322a877d88501d6ef60 Reviewed-on: https://code.wireshark.org/review/7749 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-03-19Squelch a "no implicit conversions in C++" warning.Guy Harris1-1/+1
Change-Id: Ib2876e055e8bfb1d0de36bbf7bb3b1e52217f108 Reviewed-on: https://code.wireshark.org/review/7748 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-03-19Fix extracting of parameter.Guy Harris1-9/+9
We have to find the closing parenthesis before overwriting the opening parenthesis, otherwise the end of the string, from which strrchr() searches, is at the point where the opening parenthesis was. Fix incorrect arithmetic (-1 + -1 + 1 = -1, not 1). Change-Id: Ida47dd9670b36269eef28368aa845301a7185c3f Reviewed-on: https://code.wireshark.org/review/7747 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-03-19Fix a comment.Guy Harris1-1/+1
Change-Id: I6e85f4abdc41ac01296b276f6b394376e75abe47 Reviewed-on: https://code.wireshark.org/review/7746 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-03-19Patch some memory leaks.Guy Harris4-45/+73
capture_dev_user_descr_find() and capture_dev_user_cfilter_find() return g_malloc()ated strings; we don't need to g_strdup() them to get a g_malloc()ated string, and we *do* need to free them if we aren't going to use them any more. Document that while we're at it, and give more details for the functions returning integer user-specified interface parameters as well. Change-Id: Icf98a48992b1c4168ead54bdc4cc2847da89d665 Reviewed-on: https://code.wireshark.org/review/7745 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-03-19Unused parameters are done differently in C++.Guy Harris1-1/+1
Change-Id: If6324e7ee57156e067c2584b80df835620f94ac0 Reviewed-on: https://code.wireshark.org/review/7744 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-03-19Add a comment.Gerald Combs1-0/+3
Change-Id: I82d31ce4435f1c136e158a007c9d4507e47a73a6 Reviewed-on: https://code.wireshark.org/review/7743 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-03-18Fix space before tab.Guy Harris1-1/+1
Change-Id: I8e9de014bd1e69102edb0eb2ec65d8da12ab8311 Reviewed-on: https://code.wireshark.org/review/7742 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-03-18Fix parsing of interface properties strings.Guy Harris6-168/+161
The first entry in the list does not have a leading comma, so a strstr() for ",{ifname}(" will not work. Instead, use g_strsplit() with a comma for all of the preferences. Have common code for all the "uncomplicated" preferences. Have a specialized handler for the one "complicated" preference. Change-Id: I2144a98ab0cb70db56eaaba88175d6e03885de2a Reviewed-on: https://code.wireshark.org/review/7741 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-03-18Qt: Fix recent files threadsMichal Labedzki3-40/+24
Fix crash and memory leak. Please not that Recent File Status objects and threads still continously grow and shrink memory usage, but do not grow continuously. Bug: 10893 Change-Id: Icc8b7fefd6572b902ac81d22e5f7b16e304fcf16 Reviewed-on: https://code.wireshark.org/review/7699 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Reviewed-by: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-03-17Qt: Start address resolver timerMichal Labedzki1-1/+1
Change-Id: Ic3de3db089f25d9fdfd6100f916b3960e52046f0 Reviewed-on: https://code.wireshark.org/review/7715 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Reviewed-by: Anders Broman <a.broman58@gmail.com> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-03-17Fix "Save All" for Export Objects.Guy Harris1-16/+29
Fix the loop that goes through all the objects to be saved so that it looks at all the objects to be saved rather than repeatedly looking at the first object. When letting the user select a directory in which to save, restrict them to looking at directories. QDir doesn't do what we actually want here - QDir.setCurrent() might do a chdir() but it doesn't appear to set the QDir's path, so when we use it to construct pathnames it constructs them based on wsApp->lastOpenDir() rather than the directory the user selected. Use Boring Old GLib's g_build_filename(), as we do in the GTK+ version, for now. (It also does something we *don't* want, namely, at least as the documentation implies, a chdir().) Bug: 11062 Change-Id: I705292dc2713b9dba615b0d59a4cf8313f357d82 Reviewed-on: https://code.wireshark.org/review/7720 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-03-15Qt: Fix overloaded CPUMichal Labedzki1-2/+4
QTreeView also use timerEvent() to do something... so call its overloaded method and make CPU happy again. Bug: 11035 Change-Id: I405c8c2763ae0b96c0483aedcb314a5f259e76a1 Reviewed-on: https://code.wireshark.org/review/7696 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-03-15Qt: Sort names in DecodeAs dialogMichal Labedzki1-0/+1
This should increase user experience. Change-Id: Id2713e7c5af8ca0f0d87e3ae52542b4f189ace9a Reviewed-on: https://code.wireshark.org/review/7681 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-03-14TX: Update translations (Manual sync 2015-03-14)Alexis La Goutte11-1034/+1265
Change-Id: I1aca20f4fd091db5d835d1ee12123a5f7cafe08d Reviewed-on: https://code.wireshark.org/review/7680 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-03-14Qt: Fix DecodeAsMichal Labedzki2-9/+109
Previously DecodeAs neither save its changes nor changes dissector tables. Do that and redissect packets to refresh view. Bug: 10553 Change-Id: Icd8453c9650f0265852f6b6b58bc483b35570a15 Reviewed-on: https://code.wireshark.org/review/7676 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-03-12CMake: Add a top-level nsis_package target.Gerald Combs1-2/+2
Add packaging/nsis/CMakeLists.txt and use it to generate each NSIS include file. Add macros to generate packaging-related targets and invoke them from the top-level CMakeLists.txt. Add a top-level "plugins" target. Copy plugins to "plugins" in each of our staging directories instead of "plugins/$VERSION". Add missing files to the copy_data_files and copy_cli_dlls targets. Add all files in the NSIS package from the staging directory. Drop a bunch of no-longer-needed defines, e.g. MSVC_VARIANT. Change-Id: Ib1079260d164c65118050f1431af8e582cd577fa Reviewed-on: https://code.wireshark.org/review/6459 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-03-12One check mark for ACKs, two check marks for dup ACKs.Gerald Combs2-10/+48
Add FT_FRAMENUM_ACK and FT_FRAMENUM_DUP_ACK and set them for tcp.analysis.acks_frame and tcp.analysis.duplicate_ack_frame. Draw a single or double check mark in the packet list accordingly. These are probably specific to TCP, but as it happens there are a lot of TCP packets. Change-Id: I35416506419159a79ad8cc2e35f8a14485edfb7e Reviewed-on: https://code.wireshark.org/review/7568 Reviewed-by: Anders Broman <a.broman58@gmail.com>