aboutsummaryrefslogtreecommitdiffstats
path: root/ui
AgeCommit message (Collapse)AuthorFilesLines
2018-06-08Qt: Move wireshark-qt.cpp back to ui/qt/main.cpp.Gerald Combs5-5/+958
The Qt UI's main module started out as ui/qt/main.cpp but was moved to the top-level directory in order to appease Autotools. We don't need to do that any more, so move it back. Change-Id: Ic5bc0ed5b754e36cc2b9e682f2ca097781233dfd Reviewed-on: https://code.wireshark.org/review/28090 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-07Preincrement iterators for better performanceJaap Keuter2-4/+4
Change-Id: I26853080bd0294a9058db99a30d1c06d6aac8e16 Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-on: https://code.wireshark.org/review/28083 Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-06-07Qt: Set the ByteViewText field and protocol foreground.Gerald Combs1-0/+4
Set a foreground color when we add a field and protocol format range. On some systems the highlight background is darker or lighter than the normal background, and we need to adjust the foreground to match. Add a note about correctly handling our hover rect color. Change-Id: Ib6b50403dec889280eb3d27f3deb10150d22a599 Reviewed-on: https://code.wireshark.org/review/28076 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-06-04SCTP: Adjust minTSNruengeler1-0/+6
Change-Id: If2ccbd983a2a31441d1e882da65971860f5bec94 Reviewed-on: https://code.wireshark.org/review/28013 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Tüxen <tuexen@wireshark.org>
2018-06-03[Automatic update for 2018-06-03]Gerald Combs7-533/+1203
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ie1c560eb53d3791443f1798b32ba819816896523 Reviewed-on: https://code.wireshark.org/review/27977 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-06-01Qt: Rename MainWelcomeRoland Knall9-65/+65
Currently exist two main pages within Wireshark. The first being the main welcome page and the second the packet capture page. The first is called "main_welcome.?" and the second is actually the master_split_ object defined in main_window.h. The first being a QFrame, the second not. In preparation for future developments (dockable windows, multiple capture files), this is being corrected, with the main welcome being renamed as welcome_page as a first step Change-Id: I40703e6ed15ff6f6b62b2a3cf31f5636ac6da9ec Reviewed-on: https://code.wireshark.org/review/27949 Petri-Dish: Roland Knall <rknall@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-06-01Qt: Move Layout and clear master_split useRoland Knall5-185/+250
master_split_ must be moved to a more prominent widget, as it is in actuality the main widget of the application. Change-Id: Id45b60f5f57c982c1890318eec9fa87ab61a9e19 Reviewed-on: https://code.wireshark.org/review/27942 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-05-31sharkd: add support for io graph.Jakub Zawadzki3-146/+165
Change-Id: I8d23a2b55024e2ef8c644dcef9176c7e3050a703 Reviewed-on: https://code.wireshark.org/review/27376 Petri-Dish: Jakub Zawadzki <darkjames-ws@darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki <darkjames-ws@darkjames.pl> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-05-31Move make-taps and make-dissectors to tools/João Valverde2-156/+0
make-taps and make dissectors are build tools so that is the natural location for them. See also 99ec2b58eb68ab8530245dd13485612695ba064a and bug 14622. Change-Id: I754848ea1c614bfa7121c44d89136ac3cba8a734 Reviewed-on: https://code.wireshark.org/review/27928 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2018-05-30Qt:Fix ProtoTree CopyRoland Knall2-26/+35
There was an issue, where siblings where not copied correctly. Bug:14355 Change-Id: I31611a6731f3f4de6b204c7ee708e42f0b7b170c Reviewed-on: https://code.wireshark.org/review/27802 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Kenneth Soerensen <knnthsrnsn@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com>
2018-05-30Qt: use data() instead of constData() in pcap_compile().Dario Lombardo2-3/+3
In different versions of libpcap, pcap_compile() has a 3rd parameter with or without const. Using a non-const variable, allow the auto promotion to const possible, but not the vice-versa. Fixes compilation on OpenBSD. Change-Id: I72162a4ea419668b6222e84bf5525a6c48fddd52 Reviewed-on: https://code.wireshark.org/review/27896 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-05-30Qt: fix memleaks on opening a context menuPeter Wu3-13/+10
FrameInformation was never deallocated, leaking the whole pinfo scope. Fix a dealloc-alloc-mismatch (packet_data_ was g_memdup'd). Attach the DataPrinter menu actions to the action group instead of the singleton DataPrinter instance, this enables freeing the actions when the submenu is gone rather than clearing this at program exit. Reported by ASAN. Change-Id: If13af94a60b07b0e52973ccc5c437ef987bfb394 Fixes: v2.5.0rc0-1627-g8a6ea0e454 ("Qt: Further cleanup ByteView") Reviewed-on: https://code.wireshark.org/review/27844 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-30Qt: fix memleaks in protocol preferences menuPeter Wu1-12/+12
Reported by ASAN. Change-Id: I0e7578d6583dc11312d95108331b6a743d7d5514 Reviewed-on: https://code.wireshark.org/review/27832 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-30Qt: fix memleak in PacketList::contextMenuEventPeter Wu1-0/+1
Change-Id: I925d2e1529a70aaf403896a4d7df3f491265916d Fixes: v1.99.7rc0-225-g26dacfc8c3 ("Qt: Add protocol preferences menus.") Reviewed-on: https://code.wireshark.org/review/27831 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-30Qt: fix memleak from cf_get_display_namePeter Wu6-8/+10
Free the memory as documented. Change-Id: I8a8842160be676bb08f5b93e795b9ed8edef2ede Reviewed-on: https://code.wireshark.org/review/27829 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-28sctp-analysis: Use g_list_free_full() in a couple of places.Anders1-23/+14
Change-Id: Ifd9517c562660ddee59feac1a7c234b9cdbbdf98 Reviewed-on: https://code.wireshark.org/review/27867 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-28Qt: select a better default Decode As tablePeter Wu1-0/+25
USB has three possible tables, usb.device, usb.product and usb.protocol (shown in that order in the Decode As dialog). For single packets with no prior device descriptors, the last two tables have no valid selector (integer zero). In such cases it seems more reasonable to use tables for which a valid selector exists (for example, "usb.device"). Bug: 14717 Change-Id: I2319817fa11318a97519d8cfc912343b16224c12 Reviewed-on: https://code.wireshark.org/review/27820 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-28SCTPAllAssocsDialog: fix memleak of "sctp_assocs"Peter Wu1-1/+0
"fillTable()" overwrites "sctp_assocs" with an external address. Change-Id: I415d424f16a2306b1b79fde7b5f836458da14b16 Reviewed-on: https://code.wireshark.org/review/27833 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-27[Automatic update for 2018-05-27]Gerald Combs7-38/+200
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I6603cc4dd62ff1db23efa4374437ce9ebf7a81c8 Reviewed-on: https://code.wireshark.org/review/27840 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-05-26SCTP: plug the remaining memleaks in the tapPascal Quantin1-4/+4
Change-Id: I50da5f8c54c7be49ad8339d22639605daf2c5616 Reviewed-on: https://code.wireshark.org/review/27821 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-05-26SCTP: fix crash when filtering an associationPascal Quantin2-30/+52
Do not free a tsn_t element if it has already been inserted in a GList. The code structure is complex enough to add an explicit check before calling g_free(). Fixes a regression introduced in gb19ca06fcc. While we are at it, let's call the correct free function and plug some memory leaks. Bug: 14733 Change-Id: I071da96982da569083fd98b790e0d37ac0826ff1 Reviewed-on: https://code.wireshark.org/review/27808 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-05-25Qt: fix use-after-free on error while saving exported packetsPeter Wu8-18/+26
When an error occurs while saving packets using the Export Specified Packets dialog (e.g. try to overwrite the opened capture file), the dialog is displayed again. As PacketRangeGroupBox freed the packet selection range, a crash (use-after-free) occurs. Removes some unnecessary code in MainWindow::exportDissections as well. Change-Id: I63898427eff7e71799d89c8a22246db8f93a9ff6 Fixes: v2.5.0rc0-968-g38b40acb2d ("Qt: fix a memory leak when exporting packets") Reviewed-on: https://code.wireshark.org/review/27695 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-25Qt: Configure the selection color via the preferencesPaul Zander5-131/+478
The active selection color and inactive selection color can be configured via Edit / Preferences / Font and Colors There are 3 styles that can be used for the selection color: Default: legacy behavior Flat: Use background and foreground color with no gradient. Gradient: Use background and foreground color with a gradient. Bug: 14714 Change-Id: Ieca293bb9830d2c5702949d0459d1d6f679e41e4 Reviewed-on: https://code.wireshark.org/review/27701 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-05-24Qt: Support search without a selected packetStig Bjørlykke1-4/+4
Support doing Find Packet, search for next/previous marked packet and search for next/previous time reference without having a packet selected in the packet list. Change-Id: I648b26365385d98155e905cda270e9e785b9f1da Reviewed-on: https://code.wireshark.org/review/27752 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-23Qt: Update menus when mark/ignore/timeref packetStig Bjørlykke1-0/+8
Update menus when changing mark, ignore or time reference on a packet to enable/disable entries accordingly. Change-Id: Icb95b3371fe8183cdeea1b6b2c71d1d33f998dc0 Reviewed-on: https://code.wireshark.org/review/27737 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-23Qt: Default no selection in UAT dialogStig Bjørlykke1-0/+3
Do not start editing the first column for the first item in a UAT dialog. This is the same behaviour as in UAT frame. Change-Id: If8dd90c90301b4af9108cc5286d99f83f613a19e Reviewed-on: https://code.wireshark.org/review/27708 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-05-22Fix a typo.Gerald Combs1-1/+1
Change-Id: Ia4c267bf6e0971511417e25f6fbf8fa9abdc1034 Reviewed-on: https://code.wireshark.org/review/27712 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-05-22Qt: Set a minimum width for the main window.Gerald Combs3-3/+10
Set a minimum width for the main window so that we override the minimum size set by the display filter combo. Add a couple of comments and fixup a cast while we're here. Bug: 13516 Change-Id: I6e994a7d06f5a966bb9bf8d3f4c4fc343cd466c8 Reviewed-on: https://code.wireshark.org/review/27697 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-20[Automatic update for 2018-05-20]Gerald Combs7-26/+186
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ied42aaad58b11ec1796d6c14c4981b8d54258769 Reviewed-on: https://code.wireshark.org/review/27665 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-05-18cmake: remove dependency of i18n.qrc on .qm filesPeter Wu1-1/+0
The i18n.qrc file is generated at cmake time while the .qm files are also built as dependency of the AUTORCC process. The extraneous .qm dependency of i18n.qrc possibly causes duplicate wireshark_zh_CN.qm builds (see v2.9.0rc0-605-g644939ed9e), so remove it. Change-Id: I629e7b809486a65b27158f66a7e62cfcf61657d3 Reviewed-on: https://code.wireshark.org/review/27633 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-05-18CMake: cleanup ui/qt/CMakeLists.txtPeter Wu1-25/+11
Remove some unused variables, favor list(APPEND X Y) over set(X ${X} Y), use consistent capitalization and whitespace. Change-Id: I2a90b55d29899393019a1aee3394b87ab12dda5b Reviewed-on: https://code.wireshark.org/review/27625 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-18Qt: Make sure we destroy the Capture Information dialog.Gerald Combs2-8/+0
Change-Id: Id45da4247aa3214227a96b77cb70b06f2edf38bf Reviewed-on: https://code.wireshark.org/review/27623 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-17Win32: Add a missing check.Gerald Combs1-0/+1
...otherwise we'll crash on older versions of Windows. Change-Id: If9c1b653496930fbfad4e9e663a8340990f3f295 Reviewed-on: https://code.wireshark.org/review/27626 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-05-17CMake: try to fix duplicate qm builds on WindowsPeter Wu1-2/+1
The Windows buildbot showed that .qm files are generated twice. This resulted in rebuilding i18n.cpp, which resulted in rebuilding qtui, which finally resulted in Wireshark.exe being built twice for no reason. Assuming it is the same issue as commit v2.3.0rc0-3078-gaa9a0b3bf8, avoid having multiple targets depend on the same output (.qm files). This patch requires CMake 3.1 or newer. Change-Id: Iffd8946701553b89c09504278afa4b16d2a0b5b4 Fixes: v2.5.0rc0-1366-gdfa893b1cf ("cmake: set CMAKE_AUTOUIC and CMAKE_AUTORCC to avoid CMP0071 warning") Reviewed-on: https://code.wireshark.org/review/27620 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-05-17qt_ui_utils: fix issue found by PVS Studio (V519)Alexis La Goutte1-2/+2
The 'val_qstr' variable is assigned values twice successively Change-Id: I5cc80a3e68c08330ac3bbb7c8c45db105d7fb865 Reviewed-on: https://code.wireshark.org/review/27599 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-17Qt: fix issue found by PVS Studio (V519)Alexis La Goutte2-12/+6
The 'dp_ratio' variable is assigned values twice successively Change-Id: Iac3bcefe61c3fe2f628f046ee6f77377fe7dd775 Reviewed-on: https://code.wireshark.org/review/27598 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-16Eliminate some unneeded header checks.Guy Harris1-2/+0
sys/stat.h and sys/types.h date back to V7 UNIX, so they should be present on all UN*Xes, and we're assuming they're available on Windows, so, unless and until we ever support platforms that are neither UN*Xes nor Windows, we don't need to check for them. Remove the CMake checks for them, remove the HAVE_ values from cmakeconfig.h.in, and remove all tests for the HAVE_ values. Change-Id: I90bb2aab37958553673b03b52f4931d3b304b9d0 Reviewed-on: https://code.wireshark.org/review/27603 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-16Qt: Fix a memory leak.Gerald Combs1-0/+1
Make sure the Capture Information dialog deletes its UI data. Change-Id: I2613cfb6ca4b1a72e9fcfaad5a7792d95ab4764c Reviewed-on: https://code.wireshark.org/review/27588 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-05-16Qt: Save the Capture Information dialog geometry.Gerald Combs2-1/+2
Change-Id: I0acaa54ebbe0e16a9ea486fcdf74329b6cc1aea7 Reviewed-on: https://code.wireshark.org/review/27579 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-05-16Not GTK+-only any more.Guy Harris1-1/+1
Change-Id: Ic4290fbaca37dd1353d44d9ab1ce29750aa4f747 Reviewed-on: https://code.wireshark.org/review/27574 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-16Qt: Implement the capture info dialog.Gerald Combs6-17/+316
Add back the capture info dialog. Draw sparklines for each protocol. Update the User's Guide. Bug: 12004 Change-Id: I45be8a0df4752255831a8b139ee84bb34d675ba9 Reviewed-on: https://code.wireshark.org/review/27565 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-16Windows: Make sure more native dialogs handle HiDPI.Gerald Combs32-64/+199
Add a WiresharkFileDialog class, which is a thin wrapper around a few QFileDialog functions that sets per-monitor v2 DPI awareness before showing native dialogs and resets the awareness context afterward. Use it where we call QFileDialog::getXXX. Change-Id: Ib711a70aa94b693a2515804a729f666ea7fbd673 Reviewed-on: https://code.wireshark.org/review/27568 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-15CMake: require at least CMake 3.5Peter Wu1-23/+11
CMake 3.11 with the Ninja generator started complaining about CMP0058 related to ui/qt/CMakeFiles/qtui_autogen.dir/RCCstock_iconsInfo.cmake amd other files (AUTORCC). While the policy could be set explicitly, let's try to modernize the CMake configuration: - Drop CMP0042, if this gives issues with macOS, then it must be solved in a different way using non-deprecated methods. - Drop CMP0054 and ensure that all if("${foo}") and if(${foo}) are converted to if(foo). - Remove string comparison against "-NOTFOUND", it already evaluates to false in an if condition. - Use CXX_STANDARD/CXX_STANDARD_REQUIRED for Qt 5.7 and newer. - Assume that copy_if_different can accept multiple sources (CMake 3.5). - Consistency: Out of the 60 CMake 3.11 FindXxx.cmake files that use find_library, 34 contain "XXX_LIBRAR" while 16 contain "Xxx_LIBRAR". Let's assume uppercase variables (now custom MaxMindDB include dirs are correctly used). CMake 3.5 was chosen as the next version because of its wide support. Ubuntu 14.04 ships with cmake3 3.5.1, Debian jessie-backports has 3.6.2, EPEL for CentOS/RHEL6 includes cmake3 3.6.1 and SLES12 SP2 has 3.5. Change-Id: I2fa7b94bf8cc78411f414987d17bab3a33dfb360 Reviewed-on: https://code.wireshark.org/review/27444 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-14Qt: MainWindow::dropEvent fixes.Gerald Combs1-1/+8
Limit our dropped file count to 100. Make sure we always accept our proposed action and either accept or ignore the event. Blind attempt at fixing bug 14609. Change-Id: Id08b179b6eb63529aa15bce7284460fbd19f7fec Ping-Bug: 14609 Reviewed-on: https://code.wireshark.org/review/27462 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-05-14Free g_ptr_array_free-related memory leaksPeter Wu1-3/+2
g_ptr_array_free(a, FALSE) returns "a->pdata". Callers that do not handle this will leak memory (e.g. "tshark -G plugins"). Convert other users to use the return value instead of direct access to "a->pdata". Change-Id: I29835477d587f5f54bf0d94cdae9f375e3da3ce3 Reviewed-on: https://code.wireshark.org/review/27437 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-05-13Remove a question from a comment.Guy Harris1-3/+0
Given that we're not using GTK+, the answer to the question is "no". Change-Id: Ib0e512909993830b1462d1fe3eada9265d9b1cdf Reviewed-on: https://code.wireshark.org/review/27515 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-13Get rid of some GTK+-only stuff.Guy Harris2-5/+5
Change-Id: I85806476246a567f747e3911e3d15716e9cfe06b Reviewed-on: https://code.wireshark.org/review/27514 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-13Fix indentation.Guy Harris1-2/+2
Change-Id: I15ddf53938ea23fce655b8ec558855a5e2bedf0c Reviewed-on: https://code.wireshark.org/review/27513 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-13Get rid of some GTK+-only stuff.Guy Harris2-6/+6
Change-Id: I841a1cdb637f37673466e4d065474c0f7e2dfc56 Reviewed-on: https://code.wireshark.org/review/27512 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-13[Automatic update for 2018-05-13]Gerald Combs7-8/+70
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Icf753ad9d075f2dd0688f0f58ce73d5e283dc10c Reviewed-on: https://code.wireshark.org/review/27486 Reviewed-by: Gerald Combs <gerald@wireshark.org>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-07 22:23:23 +0000