aboutsummaryrefslogtreecommitdiffstats
path: root/ui
AgeCommit message (Collapse)AuthorFilesLines
2017-09-17Fix the trivial fix.Joerg Mayer1-2/+2
Change-Id: I95743eb53a3f30206a496163dea3b79f92a54b4e Reviewed-on: https://code.wireshark.org/review/23579 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2017-09-16_U_ is wrong in c++, as is Q_UNUSED (in most cases).Joerg Mayer1-6/+6
The correct way is to not name the variable. interface_tree_cache_model.cpp is one of the exceptions: Use Q_UNUSED in a conditional compile, instead of unconditionally. Change-Id: If561e632a3a60d2424f454202f233e9a63926e78 Reviewed-on: https://code.wireshark.org/review/23570 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2017-09-16Add support for dissector tables of type FT_NONE.Michael Mann4-25/+77
This is for dissectors that have "payloads" that don't have a unique identifier to determine a sub dissector. For the command line parameter -d, specifying a selector is no longer required for dissector tables of type FT_NONE. Change-Id: I3370d9e0dc147deeca4f26b842fe35dc3bda876e Reviewed-on: https://code.wireshark.org/review/22574 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-16Refactor Decode As dialog to use a model/delegateMichael Mann9-635/+1306
The model provides a lot more flexibility and abstracting the data from the view (dialog) Noticeable changes from user perspective: 1. Value column doesn't always have a combobox. If registered decode as structure doesn't support multiple values, a simple edit box is used. 2. Existing value will always be a choice (default) in the Value combobox. 3. Duplicate values in Value combobox have been removed (for things like UDP port where source port and dest. port are same) 4. When adding/copying a decode as item, only first column (table) is editable, not the whole column. 5. Separator always present in Current protocol column to distinguish "none" from rest of protocols. 6. "Current" protocol defaults to "default value" when first added to the list instead of "none". Noticeable changes from developer perspective: 1. Code is much more spread out, but most new additions (like DCE/RPC support) should be limited to the model class (maybe delegate). The dialog class probably won't change much anymore. 2. decode_as_dialog.ui is much less useful because information is provided through model and delegate. Change-Id: I70a667cab2c07d251ab370430bc51e5c1f4a3a02 Reviewed-on: https://code.wireshark.org/review/22625 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-15wireless-timeline: handle generators that report incorrect MCS for some framesSimon Barber1-2/+11
Macbook and QCA generators sometimes report the minimum MCS for subframes in an aggregate that have FCS errors. Change-Id: I77d1a81f5b3d0e3d0755adcb889f1237b0257814 Reviewed-on: https://code.wireshark.org/review/23521 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-15Qt: initialize srt_data_ in constructor (CID 1417727)Pascal Quantin1-0/+3
Change-Id: I4977ff102f1ffb11a5ea956537dde3230b4323f7 Reviewed-on: https://code.wireshark.org/review/23550 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-15Qt: Don't show text as invalid in disabled widgetsStig Bjørlykke1-1/+1
In Interface Toolbar the text widget should not be shown as invalid when the widget is disabled. Change-Id: I100a338216b34874064cb9f808a36703157811a4 Reviewed-on: https://code.wireshark.org/review/23549 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-09-14Fix builds without pcap.Guy Harris2-1/+3
Change-Id: I5e327a8147ccd02e4fc689b321718b1910344b33 Reviewed-on: https://code.wireshark.org/review/23527 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-12Fix: Segfault when "Update list of packets in real time" is uncheckedMichael Mann1-1/+4
capture_file structure is not populated with "fixed" captures. Qt menu presumes it has a populated capture_file structure. Just have menu items be disabled until capture file is reloaded for display. Bug: 13024 Change-Id: I9dfb5355c5d421f5344f97e1e9d5b4dd08b11c6e Reviewed-on: https://code.wireshark.org/review/23095 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-12Qt: fix a segmentation fault when opening a capture using the menu entryPascal Quantin1-1/+2
Regression introduced in g38b40acb2d Change-Id: I48377345730eb52b03a2016407afda4bc0ff8a79 Reviewed-on: https://code.wireshark.org/review/23509 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-09-11Qt: SequenceDialog no longer emits goToPacket.Gerald Combs1-2/+0
SequenceDialog no longer emits goToPacket as of g7fe45cc0ec. Don't try to connect it in MainWindow. Change-Id: I0f3e47a3cf7c1e29a64da7462c85179e29828c49 Reviewed-on: https://code.wireshark.org/review/23501 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-09-11wsutil: Initialize and store plugin personal dirJoão Valverde2-5/+2
Obviate allocation on every call to get_plugins_pers_dir(). Change-Id: I089ae499f93739d490d4552f59b5db5996f7d26f Reviewed-on: https://code.wireshark.org/review/23495 Petri-Dish: João Valverde <j@v6e.pt> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: João Valverde <j@v6e.pt>
2017-09-11Qt: free SRT table once the tree is filledPascal Quantin1-0/+1
Change-Id: Ic1c55852399190f3a3c5b5bf90cf6d90517b247f Reviewed-on: https://code.wireshark.org/review/23444 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-11Qt: fix Diameter SRT statistics displayPascal Quantin2-11/+21
Diameter dynamically create the SRT entries during runtime. Delay the SRT table addition to the end of dissection to properly handle this use case. Bug: 13442 Change-Id: Id498f8d9bb4a1d7c632c9a556239bf74d0530f2a Reviewed-on: https://code.wireshark.org/review/23443 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-11Qt: fix a memory leak when exporting packetsPascal Quantin1-0/+1
Change-Id: I3c99ca838b3def4437ba92794881630b8cdd8cbd Reviewed-on: https://code.wireshark.org/review/23472 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-07Qt: Construct QRegExp only onceStig Bjørlykke2-5/+4
In Interface Toolbar lineedit the QRegExp only needs to be constructed once, not for every validity check. Change-Id: I39e9ab9c57b4ac64a0b9b601fa72646d8c420274 Reviewed-on: https://code.wireshark.org/review/23425 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-09-07CMake: Try to fix build error with i18n.qrc dependency orderJoão Valverde1-16/+17
Change-Id: I7006b435508e72457413cd1b7c5bdf1b7b41ee5b Reviewed-on: https://code.wireshark.org/review/23424 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-06Qt: fix RTP/IAX2 reverse stream export to CSVPascal Quantin2-4/+4
Bug: 14040 Change-Id: Idadfbd3b60124b5f7ac4ace275db94b10daf010a Reviewed-on: https://code.wireshark.org/review/23409 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-09-06plugins: config.h must not be included by public headersJoão Valverde3-0/+4
For a sane plugin build environment. Include config.h as the first header in the .c file instead. Fix by moving required compiler attribute macros to a new "ws_attributes.h" API header. Change-Id: I34f58a927f68c1a0e59686c14d214825149749e1 Reviewed-on: https://code.wireshark.org/review/23400 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-09-05Fix unitialized variable warnings that popped up with -OgJoão Valverde1-1/+1
Using GCC version 7.1.1. Change-Id: I7447a48fc97efb1eb15a016a29165f69d37f40a6 Reviewed-on: https://code.wireshark.org/review/23399 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-09-03Qt: Interface Toolbar log dialog for each controlStig Bjørlykke2-24/+30
Have separate log dialogs for each control logger button. Bug: 14033 Change-Id: Iaabcbe38da196ebed1302f66b77864f880121856 Reviewed-on: https://code.wireshark.org/review/23364 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-09-02Have a single IPv6 tapJoão Valverde2-4/+4
Optimize code and open possibility for enriching IPv6 tap data. Change-Id: I5a204d7464cde32123d5bfe664cc9b6bcf08dbe1 Reviewed-on: https://code.wireshark.org/review/23340 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-08-31endpoint_dialog.cpp: remove a useless breakPascal Quantin1-1/+0
Change-Id: I0aafbe27b54969e77ba4df3106b9f35809d848a4 Reviewed-on: https://code.wireshark.org/review/23335 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-08-31Qt: Fix errors when compiling for Qt4.Jens Kilian7-4/+39
This allows Wireshark to be built on RedHat EL 7.2, with Qt 4.8.5. Bug: 13909 Change-Id: Ia39a288cc342afa2bd0217cb59dac84c3227086c Reviewed-on: https://code.wireshark.org/review/23322 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-08-31Fix MacOS buildJim Young1-1/+1
Commit 8d13f14f958b9ee00b59fd869bd1630f76e6fa65 introduced a preprocessor buglet affecting MacOS builds. Change #if to #ifdef. Change-Id: I3d76c83428658abcf382e18066be0e24309ecbba Reviewed-on: https://code.wireshark.org/review/23317 Petri-Dish: Jim Young <jim.young.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jim Young <jim.young.ws@gmail.com>
2017-08-31extcap: fix parameters save in preferences filePascal Quantin2-6/+1
Since g583150198b, extcap_arg structures holds a pointer to the current preference value. So let's not update its value outside of the prefs API otherwise the call to prefs_set_string_value() with pref_current done afterwards will never notify the change and the updated value will not be written in the preference file. Moreover update ExtcapArgument::resetValue() method to have an empty string instead of a NULL pointer. Otherwise prefs_set_string_value() will not notify the change and save the restored default value in the preference file either. Change-Id: Ie70e79d471c75e25705c7654e420a7706ebc4032 Reviewed-on: https://code.wireshark.org/review/23308 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-08-30Qt: Temporarily disable DP scaling on non-macOS systems.Gerald Combs1-0/+4
Enable device pixel scaling in QCustomPlot only on macOS. Blind attempt at diagnosing / fixing bug 14012. Change-Id: I95e38eaa072d69aef0fe1d642951603800c3a280 Ping-Bug: 14012 Reviewed-on: https://code.wireshark.org/review/23314 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-08-30Qt: check QVector size before accessing its content and not afterPascal Quantin1-1/+1
Bug: 14017 Change-Id: Ied38551c78b4593f60165d9e3b04bb3913d6b258 Reviewed-on: https://code.wireshark.org/review/23310 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-08-28extcap: Close control handles when doneStig Bjørlykke1-12/+8
Ensure the event handles are closed when done to avoid leakages. Also improved the control reader to use WaitForSingleObject(). Change-Id: I1679d9c09e247b28117ec05c3e1b0f3ba0e99674 Ping-Bug: 13833 Reviewed-on: https://code.wireshark.org/review/23263 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-08-28iface_lists: Remove locked fieldMikael Kanstrup7-77/+50
It seems the locked field of interface_t was used to avoid simultaneous updates of interface entries from either multiple threads or most likely the recursive UI update callbacks case later identified. Since 802362e ("Avoid recursive scan_local_interfaces operation") the recursive callback behavior is no longer happening. And as code does not have consistent checks the locked field can anyway hardly protect a multi-threaded case if such a case exists. Remove the unnecessary locked field. Ping-Bug: 13864 Change-Id: Idc393f702b82aa6014dd636572d00f0d67120bf3 Reviewed-on: https://code.wireshark.org/review/23262 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2017-08-28Fix leaks when active capture interface goes downMikael Kanstrup1-1/+1
If an interface goes down while packet capture is ongoing related interface_option element is not freed properly. Fix by using the appropriate free function that both remove the element and frees element members. Ping-Bug: 13864 Change-Id: I66a11d64615dc9648441b532e4ff658ea42a5acf Reviewed-on: https://code.wireshark.org/review/23205 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2017-08-28iface_lists: Access ifaces member by referenceMikael Kanstrup6-62/+60
Change access of ifaces elements from by val to by reference. With this change unnecessary copying of the whole struct is avoided but even more important is that elements no longer have to be removed and inserted whenever data is updated. This change aims to make it more clear that ifaces elements shall never directly be removed from the array. Instead use function capture_opts_del_iface NOTE: Code for GTK UI not updated Ping-Bug: 13864 Change-Id: I04b65d5ee36526b30d959b8e5a2a48a3c7c4f15b Reviewed-on: https://code.wireshark.org/review/23204 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-08-28Fix leak when removing interfaces from manage interfaces dialogMikael Kanstrup2-1/+4
When removing interfaces from the manage interfaces dialog the interface elements where not freed properly causing leaks. Free the interface element when removed from the array. Ping-Bug: 13864 Change-Id: I6beb222a5475278cfc6cb454a7c8b2c86f636f38 Reviewed-on: https://code.wireshark.org/review/23203 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-08-28iface_lists: Access all_ifaces member by referenceMikael Kanstrup14-221/+186
Change access of all_ifaces elements from by val to by reference. With this change unnecessary copying of the whole struct is avoided but even more important is that elements no longer have to be removed and inserted whenever data is updated. This change aims to make it more clear that all_ifaces elements shall never be removed from the array without freeing resources via the capture_opts_free_interface_t function. NOTE: Code for GTK UI not updated Ping-Bug: 13864 Change-Id: I36742cb1d5c8daa136c9d3732a044a7c8e5c7fe7 Reviewed-on: https://code.wireshark.org/review/23201 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-08-28Qt: Fix build without libpcapStig Bjørlykke1-2/+0
Change-Id: I9b9b5de1beb23486ccc000feda54c2b20a33f4ad Reviewed-on: https://code.wireshark.org/review/23251 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-08-28extcap: Interface Toolbar support on WindowsHåkon Øye Amundsen6-60/+161
Add support for extcap control pipes on Windows. Improved read loop in InterfaceToolbarReader. Delay opening control pipes until extcap has opened the fifo pipe. Make extcap_example.py work on Windows. Bug: 13833 Change-Id: I4b47d25452637759b8a3be53be48eee5365bc0e4 Reviewed-on: https://code.wireshark.org/review/23211 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-08-22commandline: fix compilation without pcap.Dario Lombardo1-1/+1
Change-Id: I37b9dd3f9515948a5ccf72cd2fd76fc1251c9294 Reviewed-on: https://code.wireshark.org/review/23161 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-08-22Fix requesting hardware timestamps without -kAhmad Fatoum3-0/+8
The interface_options struct passed to dumpcap is populated differently when running Wireshark with and without -k. Previously, only with -k was there a valid pointer in interface_opts.timestamp_type Fixes: aca55a2 ("Add hardware timestamping support") Signed-off-by: Ahmad Fatoum <ahmad.fatoum@siemens.com> Change-Id: Ic7ecc5a1190c28197d6a7271f1b353f74d43ca61 Reviewed-on: https://code.wireshark.org/review/23160 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-08-22Add hardware timestamping supportAhmad Fatoum3-11/+33
pcap provides a pcap_set_tstamp_type function, which can be used to request hardware timestamps from a supporting kernel. This patch adds support for aforementioned function as well as two new command line options to dumpcap, wireshark and tshark: --list-time-stamp-types List time stamp types supported for the interface --time-stamp-type <type> Change the interface's timestamp method Name choice mimics those used by tcpdump(1), which already supports this feature. However, unlike tcpdump, we provide both options unconditionally. If Wireshark was configured without pcap_set_tstamp_type being available, --list-time-stamp-types reports an empty list. Change-Id: I418a4b2b84cb01949cd262aad0ad8427f5ac0652 Signed-off-by: Ahmad Fatoum <ahmad.fatoum@siemens.com> Reviewed-on: https://code.wireshark.org/review/23113 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-08-21[skinny]: minor changes to xml fileDiederik de Groot1-7/+7
- Fix/syncronise spelling for similar field types - Fix cog.py script invocation Change-Id: Iab6d8ac6414c1ba9b97c49d7d0a4d2609eb1a55b Reviewed-on: https://code.wireshark.org/review/23153 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-08-20[Automatic update for 2017-08-20]Gerald Combs6-663/+9
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I676dc2814760f711a3d3b8b4979ef8a0077e26a1 Reviewed-on: https://code.wireshark.org/review/23141 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-08-15Qt: fix compilation without pcap.Dario Lombardo4-8/+13
Change-Id: Ib8d21d63730ea6e18032b89ba0042ee7521645a8 Reviewed-on: https://code.wireshark.org/review/23078 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-08-13[Automatic update for 2017-08-13]Gerald Combs7-902/+195
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ie0e554e42e96a8b8f8c8ce7f4a9ea615276b49fb Reviewed-on: https://code.wireshark.org/review/23056 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-08-09editor_file_dialog (qt/widgets): fix indent (use 4 spaces)Alexis La Goutte1-4/+4
Change-Id: I507737879c2e24cdca6d305b8e3775967071f1c3 Reviewed-on: https://code.wireshark.org/review/23028 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-08-08io_graph_dialog.cpp: Remove graph_enabled_vs.Michael Mann1-7/+0
No longer necessary with model Change-Id: If1516f264013fabe1211aa04fe054b15e235b36a Reviewed-on: https://code.wireshark.org/review/23007 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-08-07Use UAT model for I/O graphMichael Mann11-719/+601
Convert from using TreeWidgetItems to UAT model/delegate. More of the GUI is "just handled" within the table. Required to add support for "colors" and "protocol fields" to UAT types. Also needed to add some hacks for "custom" UAT field handlers for backwards compatibility with the existing UAT structure used. Because UAT functionality was switched completely to the model, some information in the table was "lost in translation" because the UATs themselves aren't translated to other languages. TODO: 2. Better "order of operations"? A bunch of NULL/size checks needed to be added to prevent crashing. Now with model/"view" should events/functions be reordered? Bug: 13585 Change-Id: I2bbba78182317c4fada07b927c05d0c6f4cdc0fe Reviewed-on: https://code.wireshark.org/review/22766 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-08-07Use proper tab order for "file types" in UAT "table".Michael Mann6-45/+189
Directory and File "UAT types" have been using a separately launched dialog, instead of an "editor", so it breaks "tab rules". Create and treat (File) dialog as an editor. Change-Id: I983728abefb0cdd79899468a800328f1b56e2910 Reviewed-on: https://code.wireshark.org/review/22886 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-08-06[Automatic update for 2017-08-06]Gerald Combs7-710/+265
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ie6f7676ccde9337cb479e448884b0240e3fd238c Reviewed-on: https://code.wireshark.org/review/22961 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-08-06simple_dialog.cpp: Fix missed Qt version wrapper.Michael Mann1-0/+2
check_box_ member was missing a #if (QT_VERSION > QT_VERSION_CHECK(5, 2, 0)) wrapper Change-Id: Ibdddbe523b8e15c0af31fddfd3f251c24114d11a Reviewed-on: https://code.wireshark.org/review/22959 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-08-05QT: Add shortcuts for "Follow XXX Stream"Uli Heilmeier1-0/+12
Add shortcut Ctrl+Alt+Shift+ T for "Follow TCP Stream" U for "Follow UDP Stream" H for "Follow HTTP Stream" S for "Follow SSL Stream" Bug: 13047 Change-Id: I0fdd5b4d20b976b56694821a9c11424eab40b2b3 Reviewed-on: https://code.wireshark.org/review/22930 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-30 13:59:25 +0000