aboutsummaryrefslogtreecommitdiffstats
path: root/ui
AgeCommit message (Collapse)AuthorFilesLines
2014-12-01qt: fix use-after-free patternPeter Wu7-25/+30
qstring.toUtf8() returns a QByteArray object and .constData() returns a pointer inside that object. It is not safe to store this pointer as it will become invalid after the statement. Store a const reference instead. (Due to scoping differences, some are copy-assigned though.) In the UAT dialog, strlen(bytes.constData()) has also been replaced by bytes.size() as an optimization. Caught by ASAN. Change-Id: Ie09f999a32d0ef1abaa1e658b9403b74bedffc37 Reviewed-on: https://code.wireshark.org/review/5528 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-12-01Add a Buffer to wtap_pkthdr to hold file-type-specific packet metadata.Guy Harris2-2/+4
For example, this can be used for pcap-ng options not mapped to file-type-independent metadata values. Change-Id: I398b324c62c1cc1cc61eb5e9631de00481b4aadc Reviewed-on: https://code.wireshark.org/review/5549 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-11-30win32: use target file format when checking if it supports commentsPascal Quantin1-1/+1
Bug: 10656 Change-Id: Ib74f213630d6d382118c09b3cbf998b28cbc045e Reviewed-on: https://code.wireshark.org/review/5544 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-11-28Endpoint dialog (Qt): Add missing text to translateAlexis La Goutte1-1/+1
Change-Id: I375b348b6d6e35c212f76fc73135990a93560a75 Reviewed-on: https://code.wireshark.org/review/5517 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-11-27Qt: Add long option for -R (--read-filter) and -Y (--display-filter)Alexis La Goutte1-0/+2
Change-Id: Id535c04493f6c6df88006d922ee43cff9f4b70a1 Reviewed-on: https://code.wireshark.org/review/5507 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-11-26Qt: support the -R option to set a read filter on the command lineMartin Kaiser2-24/+30
rename display_filter to read_filter in some places to make it clear what it's used for modify MainWindow::openCaptureFile() so that a read filter can be set when the file name is passed in cf_path, not only when it's chosen from a file selection dialogue don't display the read filter string in the filter toolbar Change-Id: Ie8dc94cbd1ff7e61ce1e2a55518a28297daa5d51 Reviewed-on: https://code.wireshark.org/review/5446 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-11-26Consolidate sequence analysis code.Gerald Combs5-58/+48
Move scattered code for seq_analysis_info_t creation and destruction to tap-sequence-analysis.[ch]. Change-Id: I87c14b1c83105a48d0ab149a3abba71e2a2fe21f Reviewed-on: https://code.wireshark.org/review/5479 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-11-25Remove unused ui_simple_dialog.h from qt Makefile.commonStephen Fisher1-1/+0
Change-Id: I366a52a037462cb059565365ea1eec5be228078f Reviewed-on: https://code.wireshark.org/review/5475 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-11-25Qt: support the -Y option to set an initial display filterMartin Kaiser1-1/+5
Change-Id: I7627265b876c6994b163df1c5b037f4dae2f6d42 Reviewed-on: https://code.wireshark.org/review/5445 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-11-25hostlist_table (GTK): Fix Dereference of null pointer found by Clang analyzerAlexis La Goutte1-0/+4
Change-Id: If74dc38b2a9724b9d924092796db5b6beb97043c Reviewed-on: https://code.wireshark.org/review/5400 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-11-24Allow html version of man pages to be found when running from buildStephen Fisher1-0/+2
directory (they're in doc/ of the build directory). Change-Id: I425fa847952cf9f74a948a89c0048077dfcf0ae2 Reviewed-on: https://code.wireshark.org/review/5478 Reviewed-by: Stephen Fisher <sfisher@sdf.org>
2014-11-24Revert "Allow "(g)make tags" to work again"Alexis La Goutte1-0/+1
This reverts commit 6b8fe87ef48abb95dd303871d0835c153cf8c891. Change-Id: Ie4f681186c1555e6ab966e7db687035f7fc5e60f Reviewed-on: https://code.wireshark.org/review/5472 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-11-24Allow "(g)make tags" to work againStephen Fisher1-1/+0
Change-Id: Idcff82aceedbf42652741564e06ca53984078361 Reviewed-on: https://code.wireshark.org/review/5413 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Stephen Fisher <sfisher@sdf.org>
2014-11-24Second attempt at putting a description in the preferences pageStephen Fisher1-0/+7
Change-Id: I6d196486e824c82d29f1c233ef3230ad8619715d Reviewed-on: https://code.wireshark.org/review/5434 Reviewed-by: Stephen Fisher <sfisher@sdf.org>
2014-11-23Presumably the intent is to dump *non*-dummy entries.Guy Harris1-2/+2
I.e., presumably the intent is to dump *resolved* hosts, rather than *unresolved* hosts where there's no known host name and the name field is a string form of the address (the premise being that looking the address up in the hash table repeatedly, and using the already-generated string, will be faster than generating the string repeatedly). Change-Id: Iad1beb1d5f9cd9ed92bad5386111cb659614ee4d Reviewed-on: https://code.wireshark.org/review/5455 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-11-23Newlines at the ends of lines, please.Guy Harris1-2/+2
Change-Id: I7b484e3ddac7cb1330c966819514a9468ea69066 Reviewed-on: https://code.wireshark.org/review/5454 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-11-22Fix problem where the profile bar moves further left every time Wireshark isJeff Morriss1-16/+46
run. For the saved/restored geometry to be consistently correct we need to always show the expert info and capture file comment icons. Disable them if no capture file is open. Bug: 10518 Change-Id: I6e254f66a17f8f54f28cfbafb4e0f92e02cff70c Reviewed-on: https://code.wireshark.org/review/5404 Reviewed-by: Evan Huus <eapache@gmail.com> Petri-Dish: Evan Huus <eapache@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-11-21VoIP Call (GTK): Fix Dereference of null pointer found by Clang analyzerAlexis La Goutte1-0/+3
Change-Id: I80029b6238c78dcab83a6a70eca0af5b66e1488d Reviewed-on: https://code.wireshark.org/review/5401 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-11-21Add minimize and maximize buttons to the SCTP analysis windows.Irene Ruengeler6-0/+29
As suggested by Jeff Morriss. Change-Id: Ibe2d30c31d51ab92377d64068527b424a92e8a64 Reviewed-on: https://code.wireshark.org/review/5361 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-11-21Remove some leftover debug printfs.Jeff Morriss1-8/+2
Change-Id: I9f4c7f71ae403059a2a236ba095b21753f7938fa Reviewed-on: https://code.wireshark.org/review/5417 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-11-19voip_calls: Fix tap callbacks.Gerald Combs3-147/+160
We don't need to call the VoIP tap reset and draw callbacks repeately. Do so only once from the RTP tap. Packet callbacks should return a gboolean. Clean up some function names and make some static. Change-Id: I5c934ce8ce7f279861e8cc73235bbfc27d7fe622 Reviewed-on: https://code.wireshark.org/review/5396 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-11-19[pedantic] Replace usage of 'long' and 'long long'Bill Meier1-1/+1
Change-Id: I78fc82c1a83eb04d78a11fc76710c92dfc916208 Reviewed-on: https://code.wireshark.org/review/5395 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-11-18voip_calls: Regression fixes.Gerald Combs6-43/+62
Fix struct initialization logic. Clear a GQueue instead of deleting it. Don't crash if we have no sequence diagram items. Make sure we show all flows and not just invites. Zero allocated memory in a couple of places. Change-Id: Ia5bb3ba57cf625de4b554b354e098aa0361dff28 Reviewed-on: https://code.wireshark.org/review/5390 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-11-18Fix indentation.Guy Harris1-1/+1
Change-Id: Icc474748f755c21d281620c3b0f5d4d90f09223b Reviewed-on: https://code.wireshark.org/review/5380 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-11-18voip_calls: Move to ui.Gerald Combs10-144/+164
Move voip_calls.[ch] to ui. Add callbacks to voip_calls_tapinfo_t. Remove unused function definitions. Change-Id: Ib12db7053d53afa81ef2a66dc0cfe681bc624dd2 Reviewed-on: https://code.wireshark.org/review/5379 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-11-17voip_calls: Get rid of global variables.Gerald Combs4-354/+366
Move the members of voip_rtp_tapinfo_t to voip_calls_tapinfo_t. Move a bunch of formerly static variables there as well. Note that we might want to make them private again at some point. Remove launch_count. It appeared to be unused. Wrap the individual registration routines in voip_calls_init_all_taps. Wrap the removal routines in voip_calls_remove_all_tap_listeners. Move voip_calls_get_info() to voip_calls_dlg.c. Make it static. Change-Id: I58f9d91f55cfb5e4b0c048a5a1d5d4b947f4641b Reviewed-on: https://code.wireshark.org/review/5372 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-11-17Remove some ununused/unmatched <resources/> tags.Jeff Morriss34-34/+0
Change-Id: I0f8e4381b27d1defeb5980692823d297d2f48bab Reviewed-on: https://code.wireshark.org/review/5349 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-11-16mcast_stream: fix indent (use 4 spaces)Alexis La Goutte2-327/+352
Add also modelines info Change-Id: Idea65bfa25ce8a379c590074ab89a06f935c6648 Reviewed-on: https://code.wireshark.org/review/5344 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-11-16rtp_stream: fix indent (use 4 spaces)Alexis La Goutte1-81/+94
Add also modelines info Change-Id: I4c4c6d7e292ba387aacb3f71afcac756b2875847 Reviewed-on: https://code.wireshark.org/review/5345 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-11-16Remove ipproto member of packet_info.Michael Mann1-4/+3
All situations can be handled with "shimmed" dissector functions. Change-Id: Ic85483b32d99d3270b193c9f6b29574d8fad46a8 Reviewed-on: https://code.wireshark.org/review/5327 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-11-15VoIP calls: Fixup whitespace.Gerald Combs2-3103/+3114
Set modelines and reindent to match the files in the top-level ui directory. Change-Id: I7ea221e76a4b0ad3b6bcf7a3c8b4645c16aecbba Reviewed-on: https://code.wireshark.org/review/5325 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-11-15VoIP calls: Start separating common and GTK+-dependent code.Gerald Combs3-70/+76
Remove more calls to voip_calls_get_info. Get rid of the global cfile. Lowercase more function names. Change-Id: Ieda779779cce9f05e07c54314bceab4a18bae22f Reviewed-on: https://code.wireshark.org/review/5324 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-11-15VoIP calls: Use our tap offsets.Gerald Combs1-103/+115
Add convenience functions to convert between tap IDs and tapinfo pointers. Use them to get rid of some calls to voip_calls_get_info(). Lowercase function names. Remove more exit()s. Change-Id: I187fdc505bc22cc05edafed9e97ede8279ea53f9 Reviewed-on: https://code.wireshark.org/review/5321 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-11-15Fix a pointer type.Gerald Combs1-4/+4
Change-Id: I5cc67fa320b3241d6793575d59e49160ef40b260 Reviewed-on: https://code.wireshark.org/review/5319 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-11-15VoIP calls: Clean up tap registration and removal.Gerald Combs3-609/+421
Start moving away from a global voip_calls_tapinfo_t. Pass the voip_calls_tapinfo_t struct address to each registration and removal routine. All of the tap registration and removal routines are called at the same time. Replace the individual registration tracking booleans with a central one. Calling exit() from the GUI is rude. Don't do that. Change-Id: I9535002e2905a45a8cfc9643590b5d2d360ffc24 Reviewed-on: https://code.wireshark.org/review/5318 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-11-15VoIP calls tap ID cleanup.Gerald Combs2-70/+70
Remove all of the public dummy members from voip_calls_tapinfo_t. Use pointer arithmetic to generate private, unique IDs instead. We weren't removing the SUA listener. Do so. Use the correct M3UA ID. Change-Id: I8e8cdb6addbc4868aebc004be20a2f57b4acf75b Reviewed-on: https://code.wireshark.org/review/5315 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-11-15Do the "-z help" processing separately, and do it for Wireshark as well.Guy Harris2-0/+10
Yes, Wireshark does a bunch of GUI stuff, and then takes the window down before printing the help, but the same is true for some command-line error messages as well. Change-Id: Id501468416c83308e4c0a9e7a66116d8d33a9d84 Reviewed-on: https://code.wireshark.org/review/5317 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-11-14Add a name field to tap_param, for use in error messages.Guy Harris23-24/+24
Change-Id: Ia4317b61ff30e269eba0ee2ea2c46f1668544b1b Reviewed-on: https://code.wireshark.org/review/5309 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-11-14The registered -z parameter string shouldn't end with a comma.Guy Harris14-14/+14
If it ends with a comma, then, if you don't provide any parameters, you get a "no such -z statistic" message followed by a list of available statistics. If it doesn't end with a comma, then, if you don't provide any parameters *and* a parameter is required, you get a usage message, which is more useful - and, in many of those cases, a parameter *isn't* required. Change-Id: I81275ea41ad4611d8210ca3cb07c09f0abde58f2 Reviewed-on: https://code.wireshark.org/review/5308 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-11-14Add an optional flag and a type for UUID parameters for stat taps.Guy Harris24-24/+26
For future use, with common code to parse the -z argument. Change-Id: Ib2a11bd5c91b5ac48ced2cd2d112b97c301ff72a Reviewed-on: https://code.wireshark.org/review/5307 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-11-14There's nothing GTK+ about TShark.Guy Harris4-14/+14
Remove gtk from routine names in CLI taps. Change-Id: I0846da9b1e8119ed966b441cb1ca0ce1820fd1c8 Reviewed-on: https://code.wireshark.org/review/5305 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-11-14Rename stat_cmd_args.[ch] to stat_tap_ui.[ch].Guy Harris61-61/+61
The intent is to handle more than just command-line arguments; reflect that. Change-Id: Ia10efda85a9d11c6579d1bec6f789cee30d9e825 Reviewed-on: https://code.wireshark.org/review/5304 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-11-14Allow SCTP graphs to resize with the window they're in.Irene Ruengeler3-279/+240
Bug: 10698 Change-Id: I3304bd36945619aeb405c74917f21de3faa3fcbb Reviewed-on: https://code.wireshark.org/review/5284 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2014-11-14tap_ui -> stat_tap_ui.Guy Harris54-130/+130
The old routine had stat_ in the name, as the expectation was that they were for statistics taps; that's still the expectation, so have stat_ in the data structure and routine names. Change-Id: Ic98d011012b8641173d41fa0ec4f4e625614370a Reviewed-on: https://code.wireshark.org/review/5303 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-11-14For tap UIs, register a list of parameters and some menu information.Guy Harris55-80/+687
The intent here is to centralize more UI information so that we can move more tap UI stuff to common code. This is a beginning. Change-Id: Ic35ac0c01bc7b942aab88177db4065847a5e6c30 Reviewed-on: https://code.wireshark.org/review/5301 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-11-14Translations: Update Polish translationMichal Labedzki2-599/+717
All messages are translated now. Tłumaczenie Wiresharka jest teraz kompletne. Zachęcam do testowania i wytykania błędów. Change-Id: Iaffb2e581c765b5b3dff7750f878e6391539ebd6 Reviewed-on: https://code.wireshark.org/review/5293 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2014-11-14Qt: Fix non-translate-able textMichal Labedzki1-1/+1
Change-Id: I8c2376117ca1ac92c341ba938929af2d13e23f72 Reviewed-on: https://code.wireshark.org/review/5291 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2014-11-14Qt: Fix typoMichal Labedzki1-1/+1
Change-Id: Idc2b945ac3bd5de961cc9c581398dc12f6831070 Reviewed-on: https://code.wireshark.org/review/5292 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2014-11-14Gtk Utils: fix unknown command tag name 'parm'; did you mean 'param'? ↵Alexis La Goutte2-2/+2
(-Wdocumentation) Change-Id: I89f242bf916d22e0a4a665696ec3fe5ee02b8a1f Reviewed-on: https://code.wireshark.org/review/5283 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-11-12Qt: Flatten group boxes.Gerald Combs6-20/+31
As discussed in change 5185, the "big 3" HIGs discourage the use of traditional group boxes. Flatten our existing ones. Change-Id: I68ef4aa9fd0f69a42750bf735df2250a468bfb2d Reviewed-on: https://code.wireshark.org/review/5263 Reviewed-by: Gerald Combs <gerald@wireshark.org>
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-05 13:12:08 +0000