Age | Commit message (Collapse) | Author | Files | Lines |
|
from makefiles (and thus from the buildbot).
The intention is to be able to tell when a human is running the tool so we
can provide more code-review guidance.
As a starter, enable the "too many proto_tree_add_text() calls" check when
a human is running the tool.
svn path=/trunk/; revision=41943
|
|
make Save-As/Displayed/All-Packets save not only the displayed packets but
also any other packets needed (e.g., for reassembly) to fully dissect the
displayed packets.
This works only for the "All packets" case; choosing only the Selected packet,
the Marked packets, or a range of packets would require actually storing which
packets depend on which (too much memory) or going through the packet list many
times (too slow). Also, this behavior is always the case: you can't save the
displayed packets without their dependencies (I don't see why this would be
desirable).
So far this is done for SCTP and things using the reassembly routines (TCP has
been tested).
The Win32 dialog was modified but hasn't been tested yet.
One confusing aspect of the UI is that the Displayed count in the Save-As
dialog does not match the number of displayed packets. (I tried renaming the
button "Displayed + Dependencies" but it looked too big.) The tooltip tries
to explain this and the fact that this works only in the All-Packets case;
suggestions for improvement are welcome.
Implementation details:
Dissectors (or the reassembly code) can list frames which were needed to
build the current frame's tree. If the current frame passes the display
filter then each listed frame is marked as "depended upon" (this takes up the
last free frame_data flag).
When performing a Save-As/Displayed/All-Packets then choose packets which
passed the dfilter _or_ are depended upon.
svn path=/trunk/; revision=41216
|
|
svn path=/trunk/; revision=41180
|
|
here.
svn path=/trunk/; revision=41062
|
|
types.
svn path=/trunk/; revision=40690
|
|
svn path=/trunk/; revision=40689
|
|
- we use it later, and we're freeing it later.
svn path=/trunk/; revision=40688
|
|
svn path=/trunk/; revision=40687
|
|
svn path=/trunk/; revision=40686
|
|
svn path=/trunk/; revision=40679
|
|
a field that gives the default extension for the file type,
*without* a leading "." (i.e., just the extension, not the "."
that separates it from the rest of the file name), which is NULL
if there are no known extensions;
a field that gives a semicolon-separated list of *other*
extensions, without "*." or ".", which is NULL if there are no
known extensions or there are no known extensions other than the
default.
Rename wtap_file_extension_default_string() to
wtap_default_file_extension() (matches the name of the field).
svn path=/trunk/; revision=40678
|
|
svn path=/trunk/; revision=40676
|
|
sense of "what follows the last . in the file name", i.e. not including
the ".".
svn path=/trunk/; revision=40674
|
|
all do); get rid of the test for a null return from
wtap_file_type_string().)
If wtap_get_file_extensions_list() returns NULL, include the file type
in the list of filters, and use "*.*" as the filter. That way the list
of filters will include all file types, even if you can't really ask
only for files of that type (actually, you can't really ask only for
files of *any* type unless you're running under a desktop environment
where file types are specified by, for example, looking for magic
numbers, as there's no guarantee that, for example, a pcap file will
have an extension at all, given that it might come from a command-line
tool that doesn't default to any extension).
svn path=/trunk/; revision=40650
|
|
svn path=/trunk/; revision=40643
|
|
show up in the UI, and they appear to show up in the UI in the Windows
apps I've seen, so I guess Windows apps put the list of patterns into
the description.
svn path=/trunk/; revision=40642
|
|
svn path=/trunk/; revision=40641
|
|
the list of patterns; see what happens.
svn path=/trunk/; revision=40640
|
|
patterns; add the "*.".
svn path=/trunk/; revision=40639
|
|
svn path=/trunk/; revision=40638
|
|
svn path=/trunk/; revision=40637
|
|
svn path=/trunk/; revision=40624
|
|
GSList of extensions for a file type, including extensions for the
compressed versions of those file types that we can read.
svn path=/trunk/; revision=40623
|
|
svn path=/trunk/; revision=40567
|
|
svn path=/trunk/; revision=40537
|
|
svn path=/trunk/; revision=40536
|
|
svn path=/trunk/; revision=40534
|
|
svn path=/trunk/; revision=40531
|