aboutsummaryrefslogtreecommitdiffstats
path: root/ui/recent.c
AgeCommit message (Collapse)AuthorFilesLines
2021-09-13Qt: ByteView make hover configurableRoland Knall1-0/+8
Allow the hover selection to be either configured via context menu or by pressing the Ctrl key while moving the mouse. The configuration is stored via profile
2021-04-20Remove unneeded modelines in ui.Gerald Combs1-13/+0
Remove the editor modeline blocks from the source files in ui that use 4 space indentation by running perl -i -p0e 's{ \n+ /[ *\n]+ editor \s+ modelines .* shiftwidth= .* \*/ \s+ } {\n}gsix' $( ag -l shiftwidth=4 $( ag -g '\.(c|cpp|h|m|mm)') ) This gives us one source of indentation truth for these files, and it *shouldn't* affect anyone since - These files match the default in our top-level .editorconfig. - The one notable editor that's likely to be used on these files and *doesn't* support EditorConfig (Qt Creator) defaults to 4 space indentation.
2020-12-22Detect and replace bad allocation patternsMoshe Kaplan1-4/+4
Adds a pre-commit hook for detecting and replacing occurrences of `g_malloc()` and `wmem_alloc()` with `g_new()` and `wmem_new()`, to improve the readability of Wireshark's code, and occurrences of `g_malloc(sizeof(struct myobj) * foo)` with `g_new(struct myobj, foo)` to prevent integer overflows Also fixes all existing occurrences across the codebase.
2020-10-28Qt: Add a recent item for packet diagram field values.Gerald Combs1-38/+45
Fixes #16957.
2020-08-10Qt: Add a packet diagram view.Gerald Combs1-0/+8
Add a new top-level view that shows each packet as a series of diagrams similar to what you'd find in a networking textook or an RFC. Add proto_item_set_bits_offset_len so that we can display some diagram fields correctly. Bugs / to do: - Make this a separate dialog instead of a main window view? - Handle bitfields / flags Change-Id: Iba4897a5bf1dcd73929dde6210d5483cf07f54df Reviewed-on: https://code.wireshark.org/review/37497 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-02-07Qt: Make it possible to hide welcome screen warnings.Gerald Combs1-7/+7
The "The NPF driver isn't running. You may have trouble" warning dialog is now redundant, so remove it along with the "privs.warn_if_no_npf" recent setting. Add a more general "sys.warn_if_no_capture" recent setting along with a getter for SimpleDialog's "Don't show this message again." string. Use them to add a "Don't show this..." link to the main welcome warning label. Change-Id: Idffb800761eebf04b75e4be3f6bf7727dd468949 Reviewed-on: https://code.wireshark.org/review/36042 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Tomasz Moń <desowin@gmail.com>
2019-12-16profiles: Try to better sync on disk config stateJim Young1-3/+4
Profile specific column settings are split across the `preferences' file and the `recent' file. At any given moment the GUI column settings held within the `preferences' file and the `recent' file may be inconsistent with one another and with the GUI itself. These inconsistencies occur because of when the GUI chooses to write config changes to disk. If Wireshark is not shutdown gracefully (for example when killed or should crash) the column preferences saved on disk may not be consistent between the current profile's `preferences` and `recent` files and the most recently used profile may not be recorded within the `recent_common' file. On restarting Wireshark these config file inconsistencies can lead to unexpected artifacts. Normally the column config state saved within the current profile's `preferences' and `recent` files are made consistent when a different profile is selected or when Wireshark is closed gracefully. This patch set attempts to improve the constancy of the on disk config state with the GUI state by invoking the functions to write the `recent' and `recent_common' files in a more timely manner. Fix a typo while here. Change-Id: I2af9d9eb2dcf9cc0d422e9840aa05f4f6b1aa086 Reviewed-on: https://code.wireshark.org/review/35407 Petri-Dish: Jim Young <jim.young.ws@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jim Young <jim.young.ws@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-06recent.c: cfield might be NULLJim Young1-2/+6
Avoid crash in GUI when using Edit Column widget. Bug: 16245 Change-Id: Ic98be3f98144dcfa9796fadd142180e3aaf84a9e Reviewed-on: https://code.wireshark.org/review/35301 Petri-Dish: Jim Young <jim.young.ws@gmail.com> Reviewed-by: Jim Young <jim.young.ws@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Craig Jackson <cejackson51@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-11-05Qt: Allow action buttons to be left-alignedRoland Knall1-0/+9
Buttons can be left-aligned in the display filter edit bar, by selecting the corresponding option from the context menu Bug: 14123 Change-Id: I18b48bb0ea43a598b2e309dcad9210463be06414 Reviewed-on: https://code.wireshark.org/review/34980 Reviewed-by: Roland Knall <rknall@gmail.com>
2019-09-13Qt: Store recently used find packet settingsStig Bjørlykke1-0/+44
Store the last used find packet settings in the global recent file, and load this settings on startup. Change-Id: I38081311cb06b4f398f4dfb66b659ae7d26ccac2 Reviewed-on: https://code.wireshark.org/review/34512 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-09-10Avoid warnings about a format string being a variable.Guy Harris1-2/+6
This also avoids issues if this isn't called in packet scope. Change-Id: I7dbf5b49c9f7c1b442a1104156b004b339076c26 Reviewed-on: https://code.wireshark.org/review/29527 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-06-18Remove an unused recent setting.Gerald Combs1-10/+0
Change-Id: I071f47e21b8e7b18bc7411967d96cad05749c47e Reviewed-on: https://code.wireshark.org/review/28332 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-04-17Remove some GTK+-only code.Gerald Combs1-19/+0
Change-Id: Ic2498c7acd6a1a522be45094148402ee34a6b4d1 Reviewed-on: https://code.wireshark.org/review/26958 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-16glib: Get rid of GLIB_CHECK_VERSION as we now require 2.32.0Anders1-1/+0
Change-Id: Ie95cf37f9cd283545693e290340a7489cc989c95 Reviewed-on: https://code.wireshark.org/review/26970 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-08replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later.Dario Lombardo1-1/+1
The first is deprecated, as per https://spdx.org/licenses/. Change-Id: I8e21e1d32d09b8b94b93a2dc9fbdde5ffeba6bed Reviewed-on: https://code.wireshark.org/review/25661 Petri-Dish: Anders Broman <a.broman58@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-05Qt: Byte view recent updates.Gerald Combs1-7/+26
Add a recent.gui_bytes_encoding preference and use it for the byte view encoding as requested in bug 14044. The recent.gui_bytes_view preference is an enum, so make it one. Bug: 14044 Change-Id: Ibc40721c29465aca1940467e41d71e9dd2485e71 Reviewed-on: https://code.wireshark.org/review/25147 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2017-12-29Populate Remote Interfaces with data from recent fileMichael Mann1-1/+6
Remote Interfaces have been saved in the recent_common file however they were never populated by the GUI. Bug: 8557 Change-Id: Ib68a75ce02f5b5e2c115b72d58c3e781a5122f9f Reviewed-on: https://code.wireshark.org/review/25039 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-12-28recent.c: Make some capture_remote_* APIs staticMichael Mann1-2/+13
capture_remote_combo_add_recent and capture_remote_combo_recent_write_all aren't used outside of ui/recent.c (and shouldn't be) Change-Id: Iaef374edfa0b2c7afa8e76cd6403d3f56dfc5539 Reviewed-on: https://code.wireshark.org/review/25038 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-30Reformat some top-level ui files.Gerald Combs1-1095/+1084
Make sure each ui/*.[ch] file uses identical (4-space) indentation. Remove ui/.editorconfig. Fix up other formatting where needed. SPDX-abbreviate the license blurb in the files we modify. Change-Id: I5faa1c1eae9a4b6220422ad8e4ba7a341c7deb1f Reviewed-on: https://code.wireshark.org/review/24632 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-15Remove superfluous null-checks before strdup/freeAhmad Fatoum1-13/+3
NULL checks were removed for following free functions: - g_free "If mem is NULL it simply returns" https://developer.gnome.org/glib/stable/glib-Memory-Allocation.html#g-free - g_slist_free(_full)? "NULL is considered to be the empty list" https://developer.gnome.org/glib/stable/glib-Singly-Linked-Lists.html - g_strfreev "If str_array is NULL, this function simply returns." https://developer.gnome.org/glib/stable/glib-String-Utility-Functions.html#g-strfreev - g_slice_free "If mem is NULL, this macro does nothing." https://developer.gnome.org/glib/stable/glib-Memory-Slices.html#g-slice-free - g_match_info_free "not NULL... otherwise does nothing" https://developer.gnome.org/glib/stable/glib-Perl-compatible-regular-expressions.html#g-match-info-free - dfilter_free defined in Wireshark code. Returns early when passed NULL epan/dfilter/dfilter.c They were also removed around calls to g_strdup where applicable: - g_strdup "If str is NULL it returns NULL." https://developer.gnome.org/glib/stable/glib-String-Utility-Functions.html#g-strdup Change-Id: Ie80c2db89bef531edc3aed7b7c9f654e1d654d04 Reviewed-on: https://code.wireshark.org/review/23406 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-09-20Fix leaks related to recent settingsMikael Kanstrup1-8/+27
Fix leaks related to recent settings reported by Valgrind simply after starting/stopping application. Bug: 14071 Change-Id: Ib4f205218945c8776724899c0dd99cc81b79a41d Reviewed-on: https://code.wireshark.org/review/23599 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-04-25Qt: Add interface toolbar supportStig Bjørlykke1-0/+14
An extcap utility can provide configuration for controls to use in a GUI interface toolbar. This controls are bidirectional and can be used to control the extcap utility while capturing. This is useful in scenarios where configuration can be done based on findings in the capture process, setting temporary values or give other inputs without restarting current capture. Todo: - Add support for Windows Change-Id: Ie15fa67f92eb27d8b73df6bb36f66b9a7d81932d Reviewed-on: https://code.wireshark.org/review/19982 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-03-19Fix various compile warnings turning error on Linux with gcc6 whenJoerg Mayer1-8/+8
compiling with HAVE_PCAP_REMOTE (and ENABLE_ECHLD) Change-Id: If5524f2d3dcacca9c82a46167480c8436dd8b1b2 Reviewed-on: https://code.wireshark.org/review/20615 Petri-Dish: Jörg Mayer <jmayer@loplof.de> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2017-03-02include <wsutil/glib-compat.h> to allow use of g_list_free_full() withAndersBroman1-0/+1
older glibs. Change-Id: I3eb7e178dcb844ddbac47f53f221a98e2d32f413 Reviewed-on: https://code.wireshark.org/review/20334 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-02-24PluginIF: AdditionalToolbarRoland Knall1-0/+14
Creates an interface for plugins and other parts of the code, to add a new toolbar to the system and have various widget types interact with this toolbar. All toolbars added via this interface, will be added to an additional submenu called "Additional Toolbars" within Wireshark. Also a demo plugin is being provided, demonstrating various features of the toolbar, including updating the gui elements. It also demonstrates how to update toolbar items. Change-Id: I8d0351224b3d7f4b90220d58970b51695551d7e3 Reviewed-on: https://code.wireshark.org/review/19803 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2017-02-21Have all the remote host list routines' names begin with recent_.Guy Harris1-2/+2
Some did, some didn't - make it consistent. Clean up some header comments while we're at it. Change-Id: I978c84167cce3c8f1c0280898aa4d0b60958325b Reviewed-on: https://code.wireshark.org/review/20218 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-02-21Have a routine to iterate over the remote host list.Guy Harris1-2/+4
Have a routine that iterates over the remote host list if it exists. Remove the routine to get the remote host list; all accesses should be through functions in ui/remote.c. Change-Id: Idddceba76b50ce85ef8557e132d7552191c2fddc Reviewed-on: https://code.wireshark.org/review/20217 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-02-20Calling g_hash_table_size with a NULL argument causes a GLib-CRITICAL.Joerg Mayer1-0/+4
This fixes the first issue appearing in the log of Bug: 13418 Change-Id: I2fe68a06dd4a19be8300ec34be65a8dc47d0f8b3 Reviewed-on: https://code.wireshark.org/review/20214 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-10-30Fix two warnings when compiling with rpcap support on macOS.Joerg Mayer1-1/+1
One is an unused variable warning turning error, the other is [ 71%] Building C object ui/CMakeFiles/ui.dir/recent.c.o /Users/jmayer/worktmp/wireshark/git/ui/recent.c:494:23: error: implicit conversion loses integer precision: 'glong' (aka 'long') to 'gint' (aka 'int') [-Werror,-Wshorten-64-to-32] rh->auth_type = auth_type; ~ ^~~~~~~~~ 1 error generated. Please review. Change-Id: If838f8fa1e8a76dc8c6cc78db495befdd527da92 Reviewed-on: https://code.wireshark.org/review/18544 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-06-08Use separate main geometry settings for Qt and GTK+.Gerald Combs1-0/+16
Qt and GTK+ can have wildly different notions about the top-left position of the main window, particularly in multiple-screen configurations. For example, on OS X with the following monitor arrangment: g .---------. | | | | q--------.| | | |`---------' | | `--------' GTK+ positions windows relative to 'g' and Qt positions windows relative to 'q'. As a result it's easy for one UI to clobber the settings of the other. Split the geometry_main_x and geometry_main_y recent settings into Qt and GTK+ versions. In the Qt UI, try moving the main window onscreen before falling back to the default geometry. This keeps us from losing our size settings. Add a link to a Qt geometry bug. Change-Id: If7ae0dcc1719e646299ee3bbf1c88743f655c9a0 Ping-Bug: 12389 Reviewed-on: https://code.wireshark.org/review/15775 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-11Remove the last remnants of U3 support.Gerald Combs1-10/+2
Change-Id: Ide4c177e67a77c5f9495b3b4c0f817f40e6dde30 Reviewed-on: https://code.wireshark.org/review/14425 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-12-20Qt: Add missing multi-field column validationMichal Labedzki1-4/+4
GTK already has it, but Qt forgot about it, so multi-field custom column works ok if previously saved in GTK-shark. Invalid validation prevent from modifying and saving multi-field custom column in Qt version. While at it, rename "custom field" to "custom fields" to ensure we think about multi-field custom column. Change-Id: I99588150ccb38be11b75f5dd5b0f6443e7055ebb Reviewed-on: https://code.wireshark.org/review/12685 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-18Qt: use recent.gui_bytes_view preference to remember bits / byte viewPascal Quantin1-2/+2
While we are at it, let's centralize bytes_view_type definition Bug: 11903 Change-Id: I606c779a8efaea668db1b440d3ae0336e6e3fc67 Reviewed-on: https://code.wireshark.org/review/12706 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2015-12-16Qt: save custom colors in recent_common filePascal Quantin1-0/+10
This allows to save colors across sessions for systems other than OSX that do not provide a system wide color picker While we are at it, let's stop reading the recent file twice at startup Bug: 11888 Change-Id: I69ff14d699d8111fe6a8bdac0157fcd115a60c2b Reviewed-on: https://code.wireshark.org/review/12659 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2015-12-13recent.c: fix declaration of ‘value_string’ shadows a global declarationPascal Quantin1-2/+2
Change-Id: I7dff01e534094c27839476f322f88c2774bd9e62 Reviewed-on: https://code.wireshark.org/review/12605 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-12-13Use common code for Boolean and enumerated recent values.Guy Harris1-157/+109
Cleans up the code a bit, and means the comment written out for enumerated values will contain the write list of value strings. Change-Id: Iad484e5da9349ab48e3c55e69f671b0a68b5cc6d Reviewed-on: https://code.wireshark.org/review/12604 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-13ui: Read and write correct recent timestamp formatStig Bjørlykke1-34/+40
Rewrite to use value_string to ensure correct value strings used, to add backward compatibility and to avoid global-buffer-overflow in possible future inconsistencies. This bug was introduced in 2a088c1d when adding new timestamp formats. Change-Id: I1bf4ac8427db92bfb56b4e5b90809fe08eebed20 Reviewed-on: https://code.wireshark.org/review/12584 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-10-04Fix various memleaksPeter Wu1-9/+12
Found by starting Wireshark within an empty profile, opening Preferences, search for Protocol "IEEE 802.11" (because it has radio buttons), then close everything again. Many fixes are trivial, but the various recent_read_* functions in recent.c were changed to return a boolean such that the result can always be checked even if errno==0. QButtonGroup leak was hinted by Clang Static Analyzer, all other memleaks were found using ASAN/LSan. Change-Id: Ia73f5d4c09d92f22e72377be59e23342f8ad7211 Reviewed-on: https://code.wireshark.org/review/10776 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-09-30Use a 'recent' setting to persist the checkbox controlling the source of ↵Martin Mathieson1-0/+13
PDUs to use in LTE RLC statistics Change-Id: I20234c3a3bf7761f70b0db5a6acbbf54ffbfcef5 Reviewed-on: https://code.wireshark.org/review/10699 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2015-06-19recent.c: accept an UTF-8 string in read_set_recent_pair_dynamic() functionPascal Quantin1-2/+1
Previous code was checking that the string was ASCII, which does not work when the recent capture files list contains non ASCII characters Change-Id: I1ea96035cca4b2aa2ea5061e7a4f98e78ac88f20 Reviewed-on: https://code.wireshark.org/review/8965 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-01Remove unneeded includes from ui folderMartin Mathieson1-5/+0
Change-Id: Ifd1eebff9080cd3867e44e4dcb2d2681370ed60a Reviewed-on: https://code.wireshark.org/review/6128 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-10-17Don't use <ctype.h> macros, and eliminate an include of <ctype.h>.Guy Harris1-2/+1
This avoids locale-dependent tests, and fixes cases where we passed signed char values to those macros (which is not safe with char being signed, as it is on most, but not all, platforms). Change-Id: Iea962cd7e4dfaf33c3c873ba43814cc6ed298d94 Reviewed-on: https://code.wireshark.org/review/4764 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-12Add editor modelines; Adjust whitespace as needed.Bill Meier1-208/+221
Change-Id: I4da7b335d905dbca10bbce03aa88e1cdeeb1f8ad Reviewed-on: https://code.wireshark.org/review/4626 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-05Qt: Refactor ConversationDialog for endpoints.Gerald Combs1-1/+10
Create a TrafficTableDialog (for lack of a better name) parent class from the general parts of ConversationDialog. Use it to create EndpointsDialog. Move the contents of conversation_tree_widget.{cpp,h} to conversation_dialog.{cpp,h} to match endpoint_dialog and traffic_table_dialog. Fill in GeoIP columns dynamically instead of using a hard-coded limit. Use "endp_" and "ENDP_" prefixes for a lot of endpoint variables and defines. Try to make geoip_db_lookup_ipv4 and geoip_db_lookup_ipv6 more robust. Clean up some includes. Fix a shadowed variable. Change-Id: I23054816ac7f8c6edb3b1f01c8536db37ba4122d Reviewed-on: https://code.wireshark.org/review/3462 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-07-21[WIP] Add a conversation dialog.Gerald Combs1-2/+13
Items are sorted by value. Move common conversation code to ui/conversation_hash.[ch]. Add a conversation_type_e enum along with convenience functions for fetching titles, tap names, etc. We have a single main dialog instead of a main dialog + individual protocol dialogs. It de-clutters the statistics menu and results in simpler code. Conversation type tabs can be added and removed within the dialog itself. The tab list is sticky and saved with the current profile when the dialog closes. Data can be copied as CSV or YAML. Add a FilterAction class and a corresponding filterAction slot to MainWindow. Use it for the Conversations context menu. Add an addressResolutionChanged signal and related plumbing. Get rid of the iterator members in the conversation item struct. Update the GTK+ code accordingly. Excercise for the reader: - Update TShark to use the common hash code. Ping-Bug: 9231 Ping-Bug: 8703 Ping-Bug: 6727 Change-Id: I8728d771fc5b1a85937bed9d898e53c3ecc3a544 Reviewed-on: https://code.wireshark.org/review/2987 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-07-11Try to fix the build.AndersBroman1-3/+3
Change-Id: I06e813db6af41d9fa4effcf2b23cf91d72c8c0ec Reviewed-on: https://code.wireshark.org/review/2998 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-07-11GTK Remote CapturingIrene Ruengeler1-0/+129
Move the GTK files necessary for managing the recnet remote host from capture_dlg.c to recent.c in order to use them in QT, too. Change-Id: I3f3fd31ce928162de08c6db7309ef2a9b1e97760 Reviewed-on: https://code.wireshark.org/review/2955 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-03When including <epan/prefs.h> don't force inclusion of <epan/uat.h>Jakub Zawadzki1-0/+1
svn path=/trunk/; revision=53769
2013-11-17Move the epan/filesystem.c routines to wsutil; they're not specific toGuy Harris1-1/+1
packet dissection, they're specific to the entire Wireshark suite of programs. svn path=/trunk/; revision=53377
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-27 02:10:16 +0000