aboutsummaryrefslogtreecommitdiffstats
path: root/ui/qt
AgeCommit message (Collapse)AuthorFilesLines
2017-11-15Qt: Update UAT clear button enablingStig Bjørlykke1-0/+1
Check for enabling the clear button when loading a UatFrame. Change-Id: Id9bbe4f99314d2798c4bccf10b57db99431a00fd Reviewed-on: https://code.wireshark.org/review/24412 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-11-13Qt: Really fix the packet list selectionRoland Knall3-5/+5
Really fix the selection of a row in the packet list Change-Id: I87ab36146bd9b2a130f443717ce73609a1c0b656 Reviewed-on: https://code.wireshark.org/review/24397 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Roland Knall <rknall@gmail.com> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-12Qt: ToolbarMimeData and displayRoland Knall3-17/+34
Implement the mime data for the toolbar in the same fashion as it has been done for the drag-drop of the field filter. Change-Id: I2b1ac7f82b637c999f458700c9ab24a9e4dcbcb8 Reviewed-on: https://code.wireshark.org/review/24378 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2017-11-12Qt: Show ByteView for first packetStig Bjørlykke1-1/+1
Change-Id: Ie5b09f0ac8db0adb999633f3367339b8f50eabe9 Reviewed-on: https://code.wireshark.org/review/24395 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-11-12Qt: Select correct packet from listStig Bjørlykke1-2/+1
Change-Id: Id29d74506f7f009b7f14a86d8fc7c299711c4c2c Reviewed-on: https://code.wireshark.org/review/24393 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-11-12Qt: Rename packetSelection to frameSelectedRoland Knall15-59/+81
In order to consolidate the interfaces between certain parts of the UI, the signal emitted after a frame change has occured, has to include the number of the frame. This led to two signals for frame change, and therefore packetSelection is to be removed. Change-Id: I24e0e0890291d2243935b0c48387beb66904bfa3 Reviewed-on: https://code.wireshark.org/review/24377 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2017-11-12Qt: Fix DragDrop on ProtoTreeRoland Knall1-0/+11
Fix two issues, first that you could not move the scrollbar as it would initiate a drag-drop operation. Second, if you start a drag-drop operation at the top of a field, it would select the field you move over as well. Change-Id: I553785b1b6c586919e025d3042a876701f36860d Reviewed-on: https://code.wireshark.org/review/24376 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2017-11-12Qt: Clear up the labelRoland Knall1-1/+1
The modifier key is a hidden option for now, with the label only showing the filter expression and the description Change-Id: I4c983ed0d4fadbd69f0836ecfc85ea8e1109478e Reviewed-on: https://code.wireshark.org/review/24379 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-11-12Qt: Add Modifier to drop only fieldRoland Knall4-11/+39
Add a modifier to the drag-drop operation, to only drop the field name as filter, instead of the complete filter expression Change-Id: I9da96906575397191e821e3494a42e0f10d51f45 Reviewed-on: https://code.wireshark.org/review/24375 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2017-11-12Qt: do not crash when selecting a field without tvbPeter Wu1-2/+2
If no tvb is attached to a field, crashing is not the expected result. Change-Id: Ica0e95326cfcfeb015016770d1b930a9f0447066 Fixes: v2.5.0rc0-1627-g8a6ea0e454 ("Qt: Further cleanup ByteView") Ping-Bug: 14205 Reviewed-on: https://code.wireshark.org/review/24370 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2017-11-12[Automatic update for 2017-11-12]Gerald Combs7-144/+177
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I18adb8aceae2a8962697284087d43e3b30d133f1 Reviewed-on: https://code.wireshark.org/review/24371 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-11-11Qt: Fix use-after-free crashes when changing packetsPeter Wu1-0/+2
QTabWidget::clear() is documented to remove all tabs without deleting them. As a result, findByteViewTextForTvb will still find ByteViewText children with freed tvbs. Fix this by deleting the tabs too. Change-Id: I5b4fdc7154a3804e3bd5f360749e95d178ffe580 Bug: 14199 Fixes: v2.5.0rc0-1532-g56a130a152 ("ByteViewText: Remove epan dependancy") Reviewed-on: https://code.wireshark.org/review/24339 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-11-11Qt: avoid undefined behavior in ProtoTree::eventFilterPeter Wu1-2/+4
UBSan complains about "ev" being a "QEvent" rather than a QMouseEvent. Change-Id: I9e59ffbe16df2ef20b7856e6dd2d9ef246632de6 Fixes: v2.5.0rc0-1608-g4d6454e180 ("Qt: Drag n Drop Filter expression from Packet Tree") Reviewed-on: https://code.wireshark.org/review/24338 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-11-10Add frame number to packet comment dialogMichael Mann3-4/+10
Bug: 14185 Change-Id: I9f52999339d3c34502d4e046e22f05a83fa773bb Reviewed-on: https://code.wireshark.org/review/24330 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-09qt: add constructor to proto_tree (CID: 1420705).Dario Lombardo1-1/+2
Change-Id: I60a07ef6c8006ad8f4b6a5f25c2b4f2b1cb32766 Reviewed-on: https://code.wireshark.org/review/24326 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-09autotools: Fix build for unknown Qt interfaceJoão Valverde2-2/+2
Change-Id: Ibba717da1fa6cf9b87fc1972e83b0e637e54fd80 Reviewed-on: https://code.wireshark.org/review/24324 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2017-11-09Qt: Give focus to preference value in PreferenceEditorFrameStig Bjørlykke2-0/+9
Select the preference value text and give focus when editing a single preference. Ping-Bug: 14191 Change-Id: I8d5f91c40118b9d74f1a65f5311aa92dfeb3e1b7 Reviewed-on: https://code.wireshark.org/review/24306 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-11-09Qt: Give focus to Title in ColumnEditorFrameStig Bjørlykke3-1/+10
Select the title text and give focus to the title when Edit Column. Bug: 14191 Change-Id: I04fc5f6bcc830a15ef43fa2d06a1a729df52e370 Reviewed-on: https://code.wireshark.org/review/24305 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-11-08iograph: Use default graph values if io_graphs UAT file doesn't pass validationPeter Wu1-1/+2
Change-Id: I70c8ca7b5b31d284a12220fc6ce2a764ea9fbe6b Fixes: v2.5.0rc0-631-g5b3e3ee587 ("Use UAT model for I/O graph") Reviewed-on: https://code.wireshark.org/review/23366 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-08Qt: Further cleanup ByteViewRoland Knall25-460/+1113
This further separates ByteView and the rest of the system. Using FieldInformation and DataPrinter, this is the final cleanup of the ByteViewTab Change-Id: If41521167527cf5664c2564cdd0d45fea0f3f612 Reviewed-on: https://code.wireshark.org/review/22783 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2017-11-08Qt: ReleaseNotes and reformatting of Drag n' DropRoland Knall1-3/+1
Added ReleaseNotes and changed the representation Change-Id: Ica927368ef6c5d912a29e06733ad0a95e1886077 Reviewed-on: https://code.wireshark.org/review/24291 Petri-Dish: Roland Knall <rknall@gmail.com> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-11-08Qt: Clean Drag-n-Drop Mimetype for toolbarRoland Knall3-10/+40
Cleans up the mime type to use a class instead of a mimetype string Change-Id: I122ba9b39de86d8e263f2204715911a2b0ac75cd Reviewed-on: https://code.wireshark.org/review/24286 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2017-11-08Qt: Drag n Drop Filter expression from Packet TreeRoland Knall15-4/+431
Drag and Drop a field from the packet tree to the displayfilteredit or the toolbar and drop it there to either apply the filter (or prepare it by holding down the Shift key) or create a new toolbar button Change-Id: I42645a02223c71315e91e0d58eb1b54ebab4fd58 Reviewed-on: https://code.wireshark.org/review/24280 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com>
2017-11-07Improvement to plugin_if_get_ws_info(...) functionalityPaul Offord3-12/+69
A plugin can register an initialisation function to be called each time Wireshark opens a new capture file. If plugin_if_get_ws_info(...) is called from within the initialisation function it does not return the name of the file being opened. This is because plugin_if_get_ws_info(...), through calls to a number of other functions, gets the file name details from a capture_file structure. At the time of the call to the plugins initialisation function, the capture_file structure in question has not yet been created. This change ensures that if plugin_if_get_ws_info(...) is called from a plugin's initialisation function, the name of the file to be open is correctly returned. The change also fixes a bug where plugin_if_ws_get(...) returns an incorrect file state if called from a plugin initialisation function. Bug: 14165 Change-Id: I28c85e480db96852e11bbaa14fb1f434b457ed52 Reviewed-on: https://code.wireshark.org/review/24251 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-07wireless_timeline: fix blank displaySimon Barber1-11/+2
Sometimes when a file opens the timeline does not display, also sometimes when zooming it disappears. Change-Id: I141eaef5f332a1de9af133abbeccede7c1cf5502 Reviewed-on: https://code.wireshark.org/review/24209 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2017-11-05Qt: Fix drag-n-drop in toolbarRoland Knall1-6/+16
Fixing two crashes in the toolbar, first one only appeared on mac, the second one happens every time the toolbar is removed or updated Change-Id: Ic3075a5af1b4a566e09bbce9712c968c053cc727 Reviewed-on: https://code.wireshark.org/review/24244 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2017-11-05[Automatic update for 2017-11-05]Gerald Combs7-24/+128
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I4abb96429b1ad8c6d78a129efd453f3019669f4f Reviewed-on: https://code.wireshark.org/review/24245 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-10-31Qt: ByteViewTab Fix tabs creationRoland Knall1-0/+2
Fix creation of tabs Change-Id: I11b22a3964f7c25c0c88b8ecd4eec1ad480fe800 Reviewed-on: https://code.wireshark.org/review/24202 Reviewed-by: Roland Knall <rknall@gmail.com>
2017-10-31ByteViewText: Remove epan dependancyRoland Knall10-344/+393
Remove all dependancy for the byte_view_text from the epan system, and therefore cleanly separate data and display for further separation of dissection and view Change-Id: Id1ee91b93da4511afa95f24da4cbbf39cbb89b1f Reviewed-on: https://code.wireshark.org/review/24050 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2017-10-29Use endpoint_type in conversation tables and hostlistsMichael Mann2-10/+10
Follow up to having conversions use endpoint_type instead of port_type. Change-Id: Ifd59a33bd8b9a013c242bce5fcceb09533f02c17 Reviewed-on: https://code.wireshark.org/review/24172 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-29[Automatic update for 2017-10-29]Gerald Combs7-9/+65
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ia316bd89a4a8d08237b0e5eb9f0036dc5a6bad61 Reviewed-on: https://code.wireshark.org/review/24157 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-10-28Privatize the conversation_key structureMichael Mann1-6/+4
The intention is to make it more transparent when making a switch to an "endpoint" over address/port combination. Change-Id: Ic424c32095ecb103bcb4f7f4079c549de2c8d9c4 Reviewed-on: https://code.wireshark.org/review/24148 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-28Convert to using find_conversation_pinfo where appropriateMichael Mann2-4/+2
This makes it easier to identify the simpler/common conversations Change-Id: I7094f23e49156ee27f5f72c8e130308470f3e462 Reviewed-on: https://code.wireshark.org/review/24145 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-28Always provide value for Decode As selector columnMichael Mann1-13/+9
Previous logic required multiple values from the decode as structure in order to provide an initial value. This was incorrect and led to values from protocol not selected showing in the selector column. Change-Id: If1ad5085f4a6eb8d79fc5dd72be968188051ec4e Reviewed-on: https://code.wireshark.org/review/24122 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-26Add a ws_in6_addr typedef for struct e_in6_addr.Guy Harris1-1/+1
That allows a parallel typedef of ws_in4_addr for guint32. Change-Id: I03b230247065e0e3840eb87635315a8e523ef562 Reviewed-on: https://code.wireshark.org/review/24073 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-10-23Improve http object export for URLs with long extensionsEldon Stegall1-1/+3
This allows the export of objects with extensions that may be longer than the allowed file name of an export (due to underlying filesystem, etc). The extension detection mechanism previously preserved everything in the file name after the final ".", but in some cases (especially with long query strings) this would exceed the allowed maximum file length, and simply refuse to export the object. Now, if the length of the extension and duplicate number is longer than the allowable file length, the extension is ignored, and the entire string is truncated to allow an acceptable export filename. Bug: 14130 Change-Id: I6fa0281519d031c07a9ac621002ac328f34f54cc Reviewed-on: https://code.wireshark.org/review/23960 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-22Add "Apply as filter" button to Coloring Rules DialogMichael Mann4-13/+36
Add a button to apply currently selected color as the display filter. Bug: 14100 Change-Id: Ife3edeb577075f1fe30b649a5655ef5887684d8a Reviewed-on: https://code.wireshark.org/review/24012 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-22[Automatic update for 2017-10-22]Gerald Combs1-2/+2
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I973703f2a82c96e47ec15512e223766404a6d3a1 Reviewed-on: https://code.wireshark.org/review/24021 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-10-22[Automatic update for 2017-10-22]Gerald Combs7-0/+56
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I2bc1e987630e05d2942e9405ab45e4c2f7452263 Reviewed-on: https://code.wireshark.org/review/24013 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-10-21Add button in Qt UAT dialog/frame to remove all UAT entries at once.Michael Mann8-0/+87
Change-Id: If5a172cd69beeb0b9a22eb7f6b9e7cb25f350b49 Reviewed-on: https://code.wireshark.org/review/23968 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-20Qt: fix crash after loading SRT dialogPeter Wu2-3/+13
TapParameterDialog::on_applyFilterButton_clicked first calls fillTree to populate the table and endRetapPackets to add the results to GUI. The table data must remain valid until closing the dialog since the user can still interact with the GUI. Change-Id: Ie3105be78d39c562af52f2b49081552063afcada Ping-Bug: 14141 Reviewed-on: https://code.wireshark.org/review/23994 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-20cmake: fix Qt build with CMake 3.0.0 and 3.0.1Peter Wu1-2/+2
AUTOUIC fails to generate some ui_*.h files because of a bug that was fixed in CMake 3.0.2: https://cmake.org/Bug/view.php?id=14981 Change-Id: I964d991c7edefcea55ae43b0768a7fd3503f94a9 Fixes: v2.5.0rc0-1366-gdfa893b1cf ("cmake: set CMAKE_AUTOUIC and CMAKE_AUTORCC to avoid CMP0071 warning") Reviewed-on: https://code.wireshark.org/review/23993 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2017-10-18cmake: set CMAKE_AUTOUIC and CMAKE_AUTORCC to avoid CMP0071 warningPeter Wu1-11/+27
CMake 3.10 adds CMP0071 which results in warnings about applying AUTOMOC and AUTOUIC on generated files. It somehow tries to do this for files generated by QT5_ADD_RESOURCES and QT5_WRAP_UI. As a workaround, just convert from the legacy macros to the new method. Autogenerated ui_*.h and moc_*.h will now also be shown in the "External Dependencies" tab in Visual Studio Change-Id: I36df2212bbf0f938fcd4560000031b6137db93ca Reviewed-on: https://code.wireshark.org/review/23917 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2017-10-17Bugfix Decode As dissector table selection.Michael Mann1-1/+1
Need to use UI name to select between different tables. Change-Id: I2f25435e6ac1a2f1a15e651cd3ef1bbc9e860d89 Reviewed-on: https://code.wireshark.org/review/23952 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-15autotools: make maintainer-clean should allow rerunning 'configure'João Valverde1-3/+1
Change-Id: Iedae94ffefe27b13b1967d69cacb757b5aa4576d Reviewed-on: https://code.wireshark.org/review/23928 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-10-15Remove superfluous null-checks before strdup/freeAhmad Fatoum3-8/+4
NULL checks were removed for following free functions: - g_free "If mem is NULL it simply returns" https://developer.gnome.org/glib/stable/glib-Memory-Allocation.html#g-free - g_slist_free(_full)? "NULL is considered to be the empty list" https://developer.gnome.org/glib/stable/glib-Singly-Linked-Lists.html - g_strfreev "If str_array is NULL, this function simply returns." https://developer.gnome.org/glib/stable/glib-String-Utility-Functions.html#g-strfreev - g_slice_free "If mem is NULL, this macro does nothing." https://developer.gnome.org/glib/stable/glib-Memory-Slices.html#g-slice-free - g_match_info_free "not NULL... otherwise does nothing" https://developer.gnome.org/glib/stable/glib-Perl-compatible-regular-expressions.html#g-match-info-free - dfilter_free defined in Wireshark code. Returns early when passed NULL epan/dfilter/dfilter.c They were also removed around calls to g_strdup where applicable: - g_strdup "If str is NULL it returns NULL." https://developer.gnome.org/glib/stable/glib-String-Utility-Functions.html#g-strdup Change-Id: Ie80c2db89bef531edc3aed7b7c9f654e1d654d04 Reviewed-on: https://code.wireshark.org/review/23406 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-10-15Rename ui_util.h -> ws_ui_util.hPeter Wu14-14/+14
In preparation for possibly using AUTOUIC in CMake which treats "ui_*.h" files specially, rename ui_util.h. No other changes. Change-Id: Id026572c000b713ff0e9388dc7fff8d81d4df73e Reviewed-on: https://code.wireshark.org/review/23916 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-13CMake: Allow user build flags to override default build flagsJoão Valverde1-3/+4
Autotools has the very useful feature by design of allowing the user to override the default build flags (you break it you keep it). Apparently CMake applies COMPILE_OPTIONS target property after CMAKE_{C,CXX}_FLAGS so that doesn't work here. Prepend our flags to those variables instead to make it work then. Specific target flag overrides can still be added with COMPILER_OPTIONS (e.g: generated files with -Wno-warning) but this is less effective and then we're back at the point where this overrides user flags. It's less of a concern though. Change-Id: I44761a79be4289238e02d4e781fef0099628817b Reviewed-on: https://code.wireshark.org/review/23675 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2017-10-05Qt: Free dynamic menu actions at shutdownMikael Kanstrup4-4/+13
Some menu actions registered at startup are not freed at shutdown making Valgrind complain. Fix by clearing the lists holding them and making sure all actions have a parent to free them. Bug: 14071 Change-Id: I8d99d062d394a7262b0f9b7ddea4ed71049636ac Reviewed-on: https://code.wireshark.org/review/23793 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-05qt: Fix leaked dialogsMikael Kanstrup8-7/+20
Some dialogs are allocated on heap but not freed when the dialog boxes are closed. This means one dialog instance is leaked each time opened/closed. Also dialogs being subclasses of GeometryStateDialog means they might lack a parent reference and are not automatically freed on application shutdown either. Fix these leaks by letting the dialogs automatically destroy themselves on close (via WA_DeleteOnClose). Capture filter, display filter and capture interfaces dialogs are also leaked on application shutdown. These dialogs are protected by a NULL check that at least prevent multiple instances. Though none of them are freed on application shutdown. Fix leaks by freeing when main window is destroyed. Bug: 14071 Change-Id: I8c5c5a75ad3c89abb5996941875ba5d616a22d9c Reviewed-on: https://code.wireshark.org/review/23747 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-21 03:33:22 +0000