aboutsummaryrefslogtreecommitdiffstats
path: root/ui/qt
AgeCommit message (Collapse)AuthorFilesLines
2018-02-07Move summary.[ch] to libui.Guy Harris3-4/+3
Change-Id: I49f1eeb4fc3a90e436da116577a7d0c5ba982eee Reviewed-on: https://code.wireshark.org/review/25657 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-07Generate HTTP Referer statisticsMoshe Kaplan3-0/+15
The main benefit of this feature is that it enables users to see the succession of HTTP requests that led to a specific request. A sample PCAP is available here: https://bugs.wireshark.org/bugzilla/attachment.cgi?id=16085 Change-Id: I7c521315b848fbce659fdc01e43f261d804a3a48 Reviewed-on: https://code.wireshark.org/review/25319 Reviewed-by: Moshe Kaplan <me@moshekaplan.com> Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-06about_dialog (qt): Fix Dead Store (Dead assignement/Dead increment) Warning ↵Alexis La Goutte1-2/+0
found by Clang Change-Id: Ib7c673980909551d9f817d60bbe2d77ed180b661 Reviewed-on: https://code.wireshark.org/review/25599 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-02-06Proto tree: Update left arrow navigation behavior.Gerald Combs2-0/+13
If the user presses the left arrow when a non-expaned proto tree item is selected, jump to its parent item as described in the "Main Window Navigation" section of the User's Guide.. Change-Id: Ie7478a2c292df9a225555f5539d7ba90ab5e132d Reviewed-on: https://code.wireshark.org/review/25623 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-02-06Don't assume all packets have time stamps.Guy Harris1-30/+43
We explicitly allow the not to, and, for example, Simple Packet Blocks in pcapng files don't have time stamps. Change-Id: I6c8921cf092de7831d0a3d6dab8467388f4e6286 Reviewed-on: https://code.wireshark.org/review/25625 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-05Qt: Update recent status via a non-blocking connection.Gerald Combs1-4/+3
Connect our recent file status signal using a Qt::QueuedConnection instead of a Qt::BlockingQueuedConnection. As described at https://woboq.com/blog/how-qt-signals-slots-work-part3-queuedconnection.html, QueuedConnection makes a copy of the argument list while BlockingQueuedConnection passess the list directly. This fixes what appears to be a false positive reported by ThreadSanitizer. Cross-thread signals are protected by a QMutex, but qmutex_mac.cpp in the Qt5 sources uses a Mach semaphore. The ThreadSanitizer manual says it supports pthread mutexes and compiler atomic operations but doesn't mention Mach semaphores. Change-Id: Icb8a63d7d0bdfe985ab8274757043ef45ae4bcde Reviewed-on: https://code.wireshark.org/review/25576 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-04[Automatic update for 2018-02-04]Gerald Combs7-481/+513
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I66df4a62ae7fb7c986130fec01359ebb7b00d71f Reviewed-on: https://code.wireshark.org/review/25590 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-02-03Make a deep copy of our filename in RecentFileStatus.Gerald Combs2-8/+5
QStrings are implictly shared as described at http://doc.qt.io/qt-5/implicit-sharing.html. This is normally useful, but RecentFileStatus is passed a QString before it does its work in a separate thread. Make a deep copy of the filename in order to ensure local ownership and to avoid having to fool around with a QMutex (which might not be recognized by ThreadSanitizer[1] or Helgrind[2]). Remove getFilename since it was unused. [1] https://github.com/google/sanitizers/issues/460 [2] http://valgrind.org/docs/manual/hg-manual.html Change-Id: I5b5c329505ed8c02d30043a2a6d1ded625924b9f Reviewed-on: https://code.wireshark.org/review/25572 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-02-02Qt: Keep auto-scroll when starting a new captureStig Bjørlykke2-4/+6
Avoid turning off actionGoAutoScroll when going to the first packet when starting a new capture. Bug: 14257 Change-Id: I676139696cf4917b779c5fd390d7a22fb373a6b5 Reviewed-on: https://code.wireshark.org/review/25568 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-02-02Qt: Avoid divide-by-zero if missing AUTHORS fileStig Bjørlykke1-1/+3
When debugging with at least Xcode the AUTHORS file is missing, so ensure we don't divide by zero when this happens. Change-Id: Idd7cdf8137998c872f80108662fbb8a133110af2 Reviewed-on: https://code.wireshark.org/review/25567 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-02-02Qt: use SPDX identifiers.Dario Lombardo296-4144/+296
Change-Id: I111945c08f99818c249a868c12d9a7b3a3df64b3 Reviewed-on: https://code.wireshark.org/review/25563 Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-02-02Qt: Add a missing HAVE_LUA guardStig Bjørlykke1-0/+2
Change-Id: I0ee67e769c2c9030da1844a6631dac9a494d0f06 Reviewed-on: https://code.wireshark.org/review/25556 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-02-02Qt: add initializers in PacketDialog() (CID: 1427679).Dario Lombardo1-0/+8
Change-Id: Id2f16d849b85275308101f49a5ea22fbddf66f3b Reviewed-on: https://code.wireshark.org/review/25411 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-02-02Qt: Always update splash screen on action changeStig Bjørlykke1-4/+7
On a "fast" computer this is needed to find any action which is taking long time during startup. Without this the splash screen may show a random action message happening before the slow action. Also optimize splashUpdate() when nothing to update. Change-Id: I0946353dbcf12e78323361f2cb4410c6c5605d76 Reviewed-on: https://code.wireshark.org/review/25552 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-02-01Qt: Show Lua scripts as links in the about box.Gerald Combs4-16/+49
Add UrlLinkDelegate::setColCheck, which lets you render strings as URLs or plain text according to a regex. Use it to show Lua scripts as URLs in the about box. Open links on double clicks and add column checks. Change-Id: Iaf5cd8a46a0b66a7d45079ba045ed2bbcb0ed005 Reviewed-on: https://code.wireshark.org/review/25542 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-02-01Qt: Always show the Plugins tab in the about box.Gerald Combs2-6/+18
Always show the Plugins tab. We probably have plugins via extcap even if Lua and dissector plugins are disabled. Tell the user if we don't find any plugins. Change-Id: I7ab1fb302298232a847193754b53688620855959 Reviewed-on: https://code.wireshark.org/review/25543 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-02-01Qt: More byte view and proto tree fixes.Gerald Combs3-46/+75
47e1798762 broke byte view highlighting when selecting a proto tree item. Switch back to emitting fieldSelected from selectionChanged. Force a new selection in selectedFieldChanged, which does what we were trying to do in 47e1798762. Clear our marked byte offset in the byte view when we mark a field. Emit byteSelected whenever we click the mouse. Don't highlight anything when a tree item is deselected. Deselect a tree item if we click on something that's not a byte in the byte view. Change-Id: Ibf419ccb005d69f733b2fe12ce674e1fe504bb96 Reviewed-on: https://code.wireshark.org/review/25541 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-01Qt: Avoid a potentially large memdup.Gerald Combs1-2/+4
Use QByteArray::fromRawData + tvb_get_ptr to create our ByteViewText data instead of tvb_memdup. If our tvb lifetime is shorter than our ByteViewText lifetime then that's a bug. Change-Id: Iede275578a1493b8658308e0778f7f0799d6c6cd Reviewed-on: https://code.wireshark.org/review/25534 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-01-31Qt: fix compilation when building without LuaPascal Quantin2-0/+6
Change-Id: Idb5d1016637c5d8968eae533d7688099edbeae3a Reviewed-on: https://code.wireshark.org/review/25525 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-01-31Qt: About dialog updates.Gerald Combs7-66/+80
Open lua scripts when double-clicked. Behavior depends on your system configuration. Add tooltips accordingly. Let Qt wrap the "Wireshark" tab information. Set column widths by eyeballing their contents. Elide the Folders and Plugins strings in the middle. Fixup placeholder text capitalization. Draw links using the palette link color. Change-Id: Ic141eae05541480ec1e254c55fd81728d04713d9 Reviewed-on: https://code.wireshark.org/review/25510 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-31Qt: Byte view and proto tree fixes.Gerald Combs2-45/+26
Select our byte field only when we enter marked / locked mode. Emit fieldSelected from autoScrollTo so that we always set the marked protocol. Don't clobber the current index in saveSelectedField. Change-Id: I967b20608f991a5f3e6a0979b1f702f874ce27b4 Reviewed-on: https://code.wireshark.org/review/25521 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-31Qt: Write recent before applying profile changesStig Bjørlykke3-2/+16
The selected profile may be renamed in apply_profile_changes() so write the recent file before renaming the directory to ensure that we reload the latest changes. Change-Id: I8988a00647926d93b0a1903090aadc8c61f1a34e Reviewed-on: https://code.wireshark.org/review/25516 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-31IO Graph: Add some vector checks.Gerald Combs1-3/+3
Use Qvector::value in a few places instead of an array index. Change-Id: I821ef4b16df919977739c12ccaa3b9c3d53f049c Ping-bug: 14357 Reviewed-on: https://code.wireshark.org/review/25511 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-30Qt: Fix crash when no plugins are configuredJaap Keuter2-3/+3
Configuring Wireshark with Cmake using -DENABLE_LUA:BOOL=OFF and -DENABLE_PLUGINS:BOOL=OFF causes all plugin support to be removed. The about Wireshark dialog wasn't made aware of that trying to manipulate the related mdoel anyway, causing a crash. Make the compilation of the offending code conditional. Change-Id: Ifa51f40fda7f019d09327dc5650e5a55da2daf2a Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-on: https://code.wireshark.org/review/25517 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-01-30Qt: Check for a valid capture file in the status bar.Gerald Combs1-49/+54
Rearrange the logic in showCaptureStatistics. Fixes a crash here when capturing from stdin. Change-Id: I7ec15a556579afe968a06a36d7914aa1631666df Reviewed-on: https://code.wireshark.org/review/25507 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-30Byte view: Mark bytes using an outline.Gerald Combs4-31/+11
Distinguish between hovered and marked bytes using a lighter and heavier outline. Remove the "mark" color definitions. Change-Id: Icf6363e920a634574b7a42a10ea77b538ce78290 Reviewed-on: https://code.wireshark.org/review/25513 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-28[Automatic update for 2018-01-28]Gerald Combs7-63/+715
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I0b47c83ca6e62a24043fb5d546141e3e9af1e7b8 Reviewed-on: https://code.wireshark.org/review/25493 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-01-27Qt: Translate some about box strings.Gerald Combs1-17/+17
Change-Id: I2f9d1be83a26129e1206f32133b5ba6705f4dd85 Reviewed-on: https://code.wireshark.org/review/25471 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-26Qt: Allow filter with deprecated syntax as buttonStig Bjørlykke1-2/+5
Also update widgets at startup. Bug: 14369 Change-Id: I2621b78289620a131bcad21d5ec23b048e4b218c Reviewed-on: https://code.wireshark.org/review/25475 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-01-26Qt: Remove unused label_foldersStig Bjørlykke1-20/+1
Change-Id: I42d7ba0eed9cf2ad50e02a5385c6929e9b31882b Reviewed-on: https://code.wireshark.org/review/25473 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-26Qt: Simplify files column in about dialogPeter Wu5-123/+3
HTMLTextDelegate fails to build in Qt 4.8, partially because QStyleOptionViewItem.text is introduced with Qt 5. Another issue with the current implementation is that the "Copy" action includes the HTML tags for italics. To fix these, just remove the italics formatting. Change-Id: I63aed7c3d0da3d9829d410d75fc18daa4049c0ca Fixes: v2.5.0rc0-1822-g73c01d6d05 ("Qt: Rewrite the About dialog to use models") Reviewed-on: https://code.wireshark.org/review/25470 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-25Qt 4.8 compatibility fixesPeter Wu11-22/+35
Add missing include headers, define Q_NULLPTR for all Qt objects (to avoid having to include an ugly compat header), use old signal/slot syntax (Q_SIGNALS are protected in Qt 4.8), disable Qt 5 log message handler, etc. Change-Id: I449beb0b74050fdfb0fc5828d8fb74eedb2b45bf Reviewed-on: https://code.wireshark.org/review/25469 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-01-25Qt: Adjust the about box layout.Gerald Combs1-7/+53
Make sure the compile and build information is centered. Change-Id: I2bfe502df4339c28d8c88553419b7d4d412a2be2 Reviewed-on: https://code.wireshark.org/review/25461 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-24byte_view_text (qt): Fix Dead Store (Dead assignement/Dead increment) ↵Alexis La Goutte1-1/+1
Warning found by Clang Change-Id: Ibfaac5e1d8cc30d6bb8917d0c0e10a79e059a53e Reviewed-on: https://code.wireshark.org/review/25452 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-01-21Qt: Translate files in subdirectories.Gerald Combs7-138/+3912
Make sure we pass ui/qt/*/*.{cpp,h} to lupdate. Make update-tx a bash script and make sure it passes ShellCheck. Add a -n flag, which disables pushing back to Transifex. Change-Id: Ia7d6564bbdbf69285f1f9b88cde09e37da4f916c Reviewed-on: https://code.wireshark.org/review/25382 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-21Qt: Proto tree fixesGerald Combs2-6/+5
Make sure ProtoTree::toString stops at the right place. Don't emit fieldSelected when we're processing a context menu event. It doesn't appear to be needed and it triggers unwanted automatic scrolling when prefs.gui_auto_scroll_on_expand is enabled. Change-Id: I351a6974d07aea6fdd3eb0b5c1975a1b8d8eb7da Reviewed-on: https://code.wireshark.org/review/25396 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-21Qt: Implement ProtoTreeModel::flags.Gerald Combs2-0/+10
QTreeView checks to see if Qt::ItemNeverHasChildren is set in various places, particularly when updating its set of expanded items. Implement ProtoTreeModel::flags and set Qt::ItemNeverHasChildren when needed so that QTreeView won't mark a leaf node expanded. Otherwise ProtoTree::isExpanded will return true when it shouldn't and break the iterator in ProtoTree::toString. Bug: 14355 Change-Id: Id89be9911aa14dbbb52725f7203ac26a747c42fc Reviewed-on: https://code.wireshark.org/review/25376 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-21Qt: Create byte views at the proper zoom level.Gerald Combs3-3/+12
Add a zoomed argument to WiresharkApplication::monospaceFont so that we can easily fetch the font at its current zoom level. Set the zoomed font when we create new ByteViewTexts. Change-Id: I1293f206e37bb798247b1ac4b314fdfe88d4c55c Reviewed-on: https://code.wireshark.org/review/25371 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-21Qt: Initialize a struct (found by Coverity)Gerald Combs1-0/+1
CID: 1427679 Change-Id: I2ed276f0da413b4853b7dc9ccde3530e655ad760 Reviewed-on: https://code.wireshark.org/review/25403 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-01-21[Automatic update for 2018-01-21]Gerald Combs6-58/+663
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I60c7bef36988fd487d9088880b1d27818723f0b7 Reviewed-on: https://code.wireshark.org/review/25404 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-01-19Qt: Force integer font metrics in the byte view.Gerald Combs1-12/+15
Force the layout engine to use integer arithmetic so that we don't run into wierd rounding artifacts. Include the leading when applying formats. Restrict the hover line width to either 0.5 or 1 logical pixels. Change-Id: Icc992e085e96e328ed4ed247271f75ddd69637bc Reviewed-on: https://code.wireshark.org/review/25381 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-01-19Qt: add sanity check in InterfaceTreeCacheModel (found by clang).Dario Lombardo1-3/+1
Change-Id: I8f73254d8ac4b560937431b592a81ad726ce43a9 Reviewed-on: https://code.wireshark.org/review/25370 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-01-19Qt: remove leak from PathChooserDelegate (found by clang).Dario Lombardo1-2/+3
Change-Id: I71d73c8464450f8cbc655f8f99f54bd34eddd344 Reviewed-on: https://code.wireshark.org/review/25374 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-01-18Qt: Fixup a cast.Gerald Combs1-1/+1
Change-Id: I25dbf6c91bd3ca1f16a01c937a3830010adcd197 Reviewed-on: https://code.wireshark.org/review/25373 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Jim Young <jim.young.ws@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-01-18Qt: return if cf_read_record() fails in PacketDialog (found by clang).Dario Lombardo1-1/+4
Change-Id: I5187b378db9bae092052ce50b337f266e08e4332 Reviewed-on: https://code.wireshark.org/review/25340 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-01-18Make apply_profile_changes() return a non-const pointer.Guy Harris1-2/+2
It returns a pointer to a g_mallocated string, which the caller has to free, so its return value shouldn't be a const pointer. Change-Id: I76f288379a5c1eff580c391bdc9019ab7fe8f336 Reviewed-on: https://code.wireshark.org/review/25364 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-01-18Qt: Fix bits highlighting in the byte view.Gerald Combs1-4/+5
When the byte view is set to "Show bytes as bits" make sure we highlight all eight bits instead of just two. Change-Id: I1ece65032fa32f7274f4e7383e538b92e8fa4f65 Reviewed-on: https://code.wireshark.org/review/25354 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-18Qt: I/O graph fixes.Gerald Combs4-40/+45
Use Qt::DecorationRole when setting and getting a color and Qt::CheckStateRole when setting and getting the check state of UatModel items. Add a default role for UatModel::data. Convert between value strings and their respective values where needed. Bug: 14317 Change-Id: Idd3eb773dc9944f982f6dbd7d49f73f4a60dd5a2 Reviewed-on: https://code.wireshark.org/review/25355 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Jim Young <jim.young.ws@gmail.com>
2018-01-17Qt: ByteViewText hover fixes & updates.Gerald Combs4-29/+77
Add back field highlighting during hover. Instead of marking hovered bytes using an underline+overline, draw a border rect. Change-Id: I574dd074cfa021ac0dec3cdea6c5f9b0b4da6d0e Reviewed-on: https://code.wireshark.org/review/25348 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-16Qt: add more sanity checks in utils (found by clang).Dario Lombardo1-1/+1
Ensure the pointer exist before dereference them. Change-Id: I7c2881c9c74b88517d01d9306507c14ff2a7b257 Reviewed-on: https://code.wireshark.org/review/25345 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-22 07:59:19 +0000