aboutsummaryrefslogtreecommitdiffstats
path: root/ui/qt/widgets
AgeCommit message (Collapse)AuthorFilesLines
2019-01-22Qt: Include current word in filter completion listStig Bjørlykke2-4/+2
Include the current word in the filter completion list to give the user a more complete picture of what constitutes a valid single-token protocol name. Bug: 15431 Change-Id: I77cfc78f19623d9aefd4441a67ed3ae72068034e Reviewed-on: https://code.wireshark.org/review/31654 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-16Qt: IO Graph correct color selectionRoland Knall2-145/+0
The correct method of selection of colors is just using the QColorDialog not a specialized object. Implementing it just that way, to correct bug on Linux Bug: 15399 Change-Id: I3c4785d352888ec34c34534667c3f7df182f9fd7 Reviewed-on: https://code.wireshark.org/review/31465 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-01-09Qt: Cleanup deletion of CopyFromProfileMenuStig Bjørlykke2-2/+3
Set the push button as parent to the profile list menu so it will be deleted when that parent is destroyed. Change-Id: Ide4a234e039a3e27d9ee4732a3800906c80be173 Reviewed-on: https://code.wireshark.org/review/31446 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-08Qt: Add syntax line edit feedback symbols.Gerald Combs5-8/+58
Draw a circle+backslash or a warning triangle in the far right of the line edit entry for invalid and deprecated filters respectively. This should provide an additional clue for color blind users. Bug: 15326 Change-Id: I55a1e214834a340ccda3bfe8880bba12c5e274e9 Reviewed-on: https://code.wireshark.org/review/30936 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-24Qt: Switch ui/qt/widgets/*.cpp to new-style signals and slots.Gerald Combs14-64/+66
Switch our remaining home-grown widgets (which excludes QCustomPlot) to new-style signals and slots. Change-Id: Icbe2d25d4ddad11b66f4c1369fa0da89c213ba72 Reviewed-on: https://code.wireshark.org/review/31190 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-22Qt: Switch line edits to new-style signals and slots.Gerald Combs4-31/+36
Switch SyntaxLineEdit, CaptureFilterEdit, DisplayFilterEdit, FieldFilterEdit, and RangeSyntaxLineEdit to compile time signals and slots. Change-Id: I2fb26c04324997929436c3d920baa1bdc6056e44 Reviewed-on: https://code.wireshark.org/review/31162 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-04Qt: Display filter toolbar updates.Gerald Combs1-1/+1
Don't set the display filter combo's minimum size. This lets us show more filter expression buttons. Clear the filter expression toolbar before redrawing it. This gets rid of a leftover artifact here on macOS. Change-Id: Iab944e8992caf554e024521df52d0089a4501674 Reviewed-on: https://code.wireshark.org/review/30902 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-22Add ability to disable autocomplete suggestions for filter controls.Michael Mann1-1/+1
Add a preference (enabled by default) that can enable/disable the ability for Wireshark to autocomplete display and capture filter controls. Bug: 14368 Change-Id: Ib2b688bb75c4465dab14a6a635a870d7e5c4fe80 Reviewed-on: https://code.wireshark.org/review/30320 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-11wsutil: Add config_file_exists_with_entries()Stig Bjørlykke1-1/+1
The purpose of this function is to check if a configuration file exists and has at least one entry which is not a comment. Use this when building the list of profiles where the user can copy configuration from, to avoid listing profiles with empty files or files with only comments. Change-Id: If45f52025959818fb1213ffac488cd59441e9fce Reviewed-on: https://code.wireshark.org/review/30113 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-10-08Qt: Refactor copy from profile widgetStig Bjørlykke3-60/+54
Refactor CopyFromProfile class from Button to Menu to make it usable for existing buttons, both QPushButton and QToolButton. Change-Id: I7d23b4225dbe45f961fb05e73dbb4dd51e6f8ea1 Reviewed-on: https://code.wireshark.org/review/30083 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-10-05Qt: Add copy from another profile for colorfiltersStig Bjørlykke2-0/+117
Add a new button to the Coloring Rules dialog to copy entries from another profile, or system defaults. The "copy from profile" button will also be used for other dialogs. Add a clear all button to easily remove all existing entries before importing or copying from another profile. Change-Id: Ia1e66444731018372b4354164c5a722fd73d403b Reviewed-on: https://code.wireshark.org/review/30008 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-09-10prefs,ui: properly migrate old filter expressionsPeter Wu1-11/+4
When legacy filter expressions preferences are present, be sure to (1) save the dfilter_buttons file when updating the preferences file and (2) save the preferences file after updating the dfilter_buttons file. Without doing (1), the old buttons will be lost. Without (2), restarting Wireshark will result in duplicate buttons. Only write the files if the user actually made other changes to avoid breaking profiles by just opening Wireshark. Bug: 15114 Bug: 15121 Change-Id: I5b9417c34146c4450526781a20308c9c98fb44a1 Reviewed-on: https://code.wireshark.org/review/29488 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-08-31Add support for protocol aliases. Switch BOOTP to DHCP.Gerald Combs1-1/+1
Add support for aliasing one protocol name to another and for filtering using aliased fields. Mark aliased fields as deprecated. Rename the BOOTP dissector to DHCP and alias "bootp" to "dhcp". This lets you use both "dhcp.type" and "bootp.type" as display filter fields without having to duplicate all 500+ DHCP/BOOTP fields. To do: - Add checks to proto.c:check_valid_filter_name_or_fail? - Transition SSL to TLS. - Rename packet-bootp.c to packet-dhcp.c? Change-Id: I29977859995e8347d80b8e83f1618db441b10279 Ping-Bug: 14922 Reviewed-on: https://code.wireshark.org/review/29327 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-17Qt: update to QCustomPlot 1.3.2Peter Wu2-422/+518
QCustomPlot 1.3.1 includes a fix for a crash ("Fixed potential crash in QCPGraph::pointDistance if getScatterPlotData returns empty list"). Full changelog: http://www.qcustomplot.com/release/1.3.2/changelog.txt The new files are based on QCustomPlot-source.tar.gz (1.3.2) with Alexis' typo and license header changes from v1.99.2rc0-479-gc411029a3c ("Update to QCustomPlot 1.3.0") applied. All successive Wireshark patches up to v2.5.0rc0-854-g6f28f1a59e ("Fix MacOS build") were applied. The Retina patches ("Fix QCustmPlot retina problems." and "QCP: Fix retina label calculations.") gave conflicts due contextual changes which I resolved by renaming newCachedLabel to cachedLabel (following the change in upstream commit baaad24706187f5be0a68011c780b51c4de11558). Bug: 14971 Change-Id: I5012cb5a867891b466cbf1898fe4c28cbd11ba20 Reviewed-on: https://code.wireshark.org/review/28732 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-26Qt: Fix crash when starting to drag on the wrong positionRoland Knall1-0/+3
When dragging on the wrong position in the toolbar, wireshark crashes Change-Id: I756e9caebc844d32e99e9fd3e338a872986b9e96 Reviewed-on: https://code.wireshark.org/review/28458 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-06-26Try to fix the macOS builder.Gerald Combs1-0/+1
Change-Id: I04cd70f43d86c6c8d59c7b5c843357f56490ef00 Reviewed-on: https://code.wireshark.org/review/28441 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-06-26Qt: Fix Filterexpression ToolbarRoland Knall1-2/+2
Fix the prepare possibility of applying a display filter button Change-Id: I85364b40272139f0d0c69a2735a876a3a5f5db7a Reviewed-on: https://code.wireshark.org/review/28440 Petri-Dish: Roland Knall <rknall@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com>
2018-06-25Qt: Move FilterToolBar to a separate classRoland Knall2-0/+365
Remove all filter toolbar related stuff into a separate class and away from MainWindow Change-Id: I36d937be6c2686b16a8d494213dc740d8d28efcb Reviewed-on: https://code.wireshark.org/review/28432 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-06-08Qt: Move wireshark-qt.cpp back to ui/qt/main.cpp.Gerald Combs1-2/+2
The Qt UI's main module started out as ui/qt/main.cpp but was moved to the top-level directory in order to appease Autotools. We don't need to do that any more, so move it back. Change-Id: Ic5bc0ed5b754e36cc2b9e682f2ca097781233dfd Reviewed-on: https://code.wireshark.org/review/28090 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-07Qt: Set the ByteViewText field and protocol foreground.Gerald Combs1-0/+4
Set a foreground color when we add a field and protocol format range. On some systems the highlight background is darker or lighter than the normal background, and we need to adjust the foreground to match. Add a note about correctly handling our hover rect color. Change-Id: Ib6b50403dec889280eb3d27f3deb10150d22a599 Reviewed-on: https://code.wireshark.org/review/28076 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-05-22Qt: Set a minimum width for the main window.Gerald Combs2-2/+4
Set a minimum width for the main window so that we override the minimum size set by the display filter combo. Add a couple of comments and fixup a cast while we're here. Bug: 13516 Change-Id: I6e994a7d06f5a966bb9bf8d3f4c4fc343cd466c8 Reviewed-on: https://code.wireshark.org/review/27697 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-17Qt: fix issue found by PVS Studio (V519)Alexis La Goutte1-8/+4
The 'dp_ratio' variable is assigned values twice successively Change-Id: Iac3bcefe61c3fe2f628f046ee6f77377fe7dd775 Reviewed-on: https://code.wireshark.org/review/27598 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-16Windows: Make sure more native dialogs handle HiDPI.Gerald Combs3-2/+118
Add a WiresharkFileDialog class, which is a thin wrapper around a few QFileDialog functions that sets per-monitor v2 DPI awareness before showing native dialogs and resets the awareness context afterward. Use it where we call QFileDialog::getXXX. Change-Id: Ib711a70aa94b693a2515804a729f666ea7fbd673 Reviewed-on: https://code.wireshark.org/review/27568 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-01Fix comment end after SPDX identifierStig Bjørlykke38-38/+76
Move */ to a separate line below the SPDX identifier. Change-Id: Id1032215449cfccae0933147b45e04b65e0b727f Reviewed-on: https://code.wireshark.org/review/27211 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-09QT: keep cursor visible after completerion selectMichail Koreshkov1-0/+1
Before it was like this (display filter line edit "lost" focus) After press Enter in completion pupup, line edit stop show cursor. I was confused every time because without cursor it look like focus lost. But in fact focus is not lost and only cursor was disappear. Now cursor is not disappear Change-Id: I56979a1a774b6fb0b8b8be8239c01f5034c42fc8 Reviewed-on: https://code.wireshark.org/review/26781 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-04-05Qt: Remove checks for version below 5.2Roland Knall5-23/+4
This stops the main source from being buildable by Qt 4.x Change-Id: I61edbae04ac2b3bf0ae8ee8e09d335083945c176 Reviewed-on: https://code.wireshark.org/review/26756 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-03-07Qt: Handle UAT editor dialogs explicitly.Michael Mann4-25/+172
QAbstractItemView assumes that editors are widgets, not windows. QAbstractItemView::edit calls QAbstractItemViewPrivate::openEditor, which simply calls show() and setFocus() on the editor widget. If that widget happens to be a native dialog, its event loop might not be processed. This is the case on macOS at least. Create widgets derived from QLineEdit that edit the value directly along with a button that can open the associated modal dialog. Install event filters so that we keep the correct tab behavior between fields of the UAT. Bug: 13958 Ping-Bug: 14031 Bug: 7761 Change-Id: Ie5f0a5cbde33bb9add8217029c2063a0bbfd804a Reviewed-on: https://code.wireshark.org/review/23015 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-02-22Qt: Improve our capture filter completions.Gerald Combs1-18/+69
Use libpcap's pcap-filter.manmisc to create our capture filter completion list instead of scanner.l. Bug: 14430 Change-Id: I11f6eb5679dc93561dce62f28149e103ac9b4a2b Reviewed-on: https://code.wireshark.org/review/25971 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-17Qt: Replace the toolbar extension icon.Gerald Combs2-2/+18
The QToolBar extension button icon is ugly, particularly on HiDPI displays. Replace it with a RIGHT-POINTING DOUBLE ANGLE QUOTATION MARK. Change-Id: I8822252ff5c328acd23aad345313e7cfafdffa47 Reviewed-on: https://code.wireshark.org/review/25821 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-08replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later.Dario Lombardo54-54/+54
The first is deprecated, as per https://spdx.org/licenses/. Change-Id: I8e21e1d32d09b8b94b93a2dc9fbdde5ffeba6bed Reviewed-on: https://code.wireshark.org/review/25661 Petri-Dish: Anders Broman <a.broman58@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-02Qt: use SPDX identifiers.Dario Lombardo38-532/+38
Change-Id: I111945c08f99818c249a868c12d9a7b3a3df64b3 Reviewed-on: https://code.wireshark.org/review/25563 Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-02-01Qt: More byte view and proto tree fixes.Gerald Combs1-6/+19
47e1798762 broke byte view highlighting when selecting a proto tree item. Switch back to emitting fieldSelected from selectionChanged. Force a new selection in selectedFieldChanged, which does what we were trying to do in 47e1798762. Clear our marked byte offset in the byte view when we mark a field. Emit byteSelected whenever we click the mouse. Don't highlight anything when a tree item is deselected. Deselect a tree item if we click on something that's not a byte in the byte view. Change-Id: Ibf419ccb005d69f733b2fe12ce674e1fe504bb96 Reviewed-on: https://code.wireshark.org/review/25541 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-31Qt: Byte view and proto tree fixes.Gerald Combs1-2/+4
Select our byte field only when we enter marked / locked mode. Emit fieldSelected from autoScrollTo so that we always set the marked protocol. Don't clobber the current index in saveSelectedField. Change-Id: I967b20608f991a5f3e6a0979b1f702f874ce27b4 Reviewed-on: https://code.wireshark.org/review/25521 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-30Byte view: Mark bytes using an outline.Gerald Combs2-20/+11
Distinguish between hovered and marked bytes using a lighter and heavier outline. Remove the "mark" color definitions. Change-Id: Icf6363e920a634574b7a42a10ea77b538ce78290 Reviewed-on: https://code.wireshark.org/review/25513 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-25Qt 4.8 compatibility fixesPeter Wu1-1/+0
Add missing include headers, define Q_NULLPTR for all Qt objects (to avoid having to include an ugly compat header), use old signal/slot syntax (Q_SIGNALS are protected in Qt 4.8), disable Qt 5 log message handler, etc. Change-Id: I449beb0b74050fdfb0fc5828d8fb74eedb2b45bf Reviewed-on: https://code.wireshark.org/review/25469 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-01-24byte_view_text (qt): Fix Dead Store (Dead assignement/Dead increment) ↵Alexis La Goutte1-1/+1
Warning found by Clang Change-Id: Ibfaac5e1d8cc30d6bb8917d0c0e10a79e059a53e Reviewed-on: https://code.wireshark.org/review/25452 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-01-19Qt: Force integer font metrics in the byte view.Gerald Combs1-12/+15
Force the layout engine to use integer arithmetic so that we don't run into wierd rounding artifacts. Include the leading when applying formats. Restrict the hover line width to either 0.5 or 1 logical pixels. Change-Id: Icc992e085e96e328ed4ed247271f75ddd69637bc Reviewed-on: https://code.wireshark.org/review/25381 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-01-18Qt: Fix bits highlighting in the byte view.Gerald Combs1-4/+5
When the byte view is set to "Show bytes as bits" make sure we highlight all eight bits instead of just two. Change-Id: I1ece65032fa32f7274f4e7383e538b92e8fa4f65 Reviewed-on: https://code.wireshark.org/review/25354 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-17Qt: ByteViewText hover fixes & updates.Gerald Combs2-19/+46
Add back field highlighting during hover. Instead of marking hovered bytes using an underline+overline, draw a border rect. Change-Id: I574dd074cfa021ac0dec3cdea6c5f9b0b4da6d0e Reviewed-on: https://code.wireshark.org/review/25348 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-15Qt: change obsolete qVariantFromValue into QVariant::fromValue.Dario Lombardo2-6/+6
Change-Id: I767b06c0e316347cdb28b769f1032e6d44cba45b Reviewed-on: https://code.wireshark.org/review/25321 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Roland Knall <rknall@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-08Bugfix the sort order of protocols in Preference dialog.Michael Mann2-32/+23
Sort properly by module title. Also consolidate some of the searching in PrefModuleTreeView. Change-Id: I5312581c63f8626de08bd9f03613219b34bf968a Reviewed-on: https://code.wireshark.org/review/25176 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-05Qt: Add manager for preference dialogMichael Mann2-0/+102
Abstract out the different types of preferences into a visitor and factory pattern to handle the preference dialog. Change-Id: Ia611ec192dcc1ad638a997182cec1ab5bdb7859c Reviewed-on: https://code.wireshark.org/review/25142 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-01-05Qt: Byte view recent updates.Gerald Combs1-24/+32
Add a recent.gui_bytes_encoding preference and use it for the byte view encoding as requested in bug 14044. The recent.gui_bytes_view preference is an enum, so make it one. Bug: 14044 Change-Id: Ibc40721c29465aca1940467e41d71e9dd2485e71 Reviewed-on: https://code.wireshark.org/review/25147 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-01-05Qt: Move sized toolbar images to stock_icons.Gerald Combs2-2/+2
The sized (WWxHH) icons in the toolbar directory aren't limited to toolbars. Create a "stock_icons" directory and move them and their related SVGs there. Change-Id: I2c1852499594aa738371c79542f24bd3351653bb Reviewed-on: https://code.wireshark.org/review/25133 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-01-04Convert preference dialog to use more models.Michael Mann4-29/+171
Convert Advanced view and Modules view to use a single base model, loading the preferences once and then filter and display what they need with QSortFilterProxyModel derived classes. Convert the PreferencePane "types" to just strings. This allows a more straightforward relationship between the "special" modules that need custom widgets for preference manipulation and it also removes dependency on preferences_dialog.h for many files. Change-Id: I091deb3061564aa4d1564e9ca1c792715961b083 Reviewed-on: https://code.wireshark.org/review/25134 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-01-04Qt: Redesign profile menu in status barRoland Knall2-26/+25
Remove global variables and move menu to where it is created. Additionally exchange LabelStack with ClickableLable, as it was overkill. Change-Id: I04528b707e9e491d0dd43063f5a47b08dfdb3471 Reviewed-on: https://code.wireshark.org/review/25140 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2017-12-28Qt: Fix moc interface issueRoland Knall2-2/+1
moc has an issue with interfaces defined in classes, where also other Qt objects are being defined. At least in some versions for Qt, this may lead to the interface declaration not being found Change-Id: Id143311322086abe23085d2482957ec330ae67c8 Reviewed-on: https://code.wireshark.org/review/25032 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2017-12-27Qt: Add "Copy as…" to the byte view.Gerald Combs2-30/+31
Make ByteViewText an IDataPrintable and add "Copy as…" context menu actions. Remove some unused functions. Bug: 14276 Change-Id: Ie48c7c9b016de19fd8978397d03d23e9a7fe247a Reviewed-on: https://code.wireshark.org/review/24933 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2017-12-27Convert Export Objects dialog to use a model.Michael Mann2-0/+81
Change-Id: I4be2c83755be95ab0deec15f066dd3e89b96a240 Reviewed-on: https://code.wireshark.org/review/25005 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-12-26Qt: remove unneeded check.Dario Lombardo1-4/+2
CID: 1402186. CID: 1402182. Change-Id: Icaae5e8b0459a4df751e08f45ce3f461a21499e8 Reviewed-on: https://code.wireshark.org/review/24993 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-06 15:25:47 +0000