aboutsummaryrefslogtreecommitdiffstats
path: root/ui/qt/tcp_stream_dialog.cpp
AgeCommit message (Collapse)AuthorFilesLines
2015-07-07Starting to get rid of Q_UNUSED declarations for unused function parameters.Joerg Mayer1-5/+2
The official C++ way is to leave out the variable name instead. This has the advantage to be reliable: In one case a variable declared unused was later used. Change-Id: I1c96636f7fa7a621d1594d1e9cacaec75c561faa Reviewed-on: https://code.wireshark.org/review/9532 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2015-06-26Commit d4aa1a1c24e984339806c4ddb000ea9f9b352659 added some Q_UNUSEDJoerg Mayer1-3/+1
statements to c++ files. The standard method to mark function parameters as unused in cpp is to just leave out the variable name. Change-Id: I4f07ad9f494ad16388eadb67e93ea7b26ae70eb5 Reviewed-on: https://code.wireshark.org/review/9152 Reviewed-by: Guy Harris <guy@alum.mit.edu> Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2015-06-25Qt: use <> for including the generated ui_*.h filesMartin Kaiser1-1/+1
this should make Visual Studio pick up the generated include files from the build directory instead of the source directory (which may contain lefovers from an in-tree build) Change-Id: Ie3de4cdd85a2865e203118a42ab10f443372f03b Reviewed-on: https://code.wireshark.org/review/9129 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-06-25Qt: mark unused parameters as suchPascal Quantin1-0/+2
Change-Id: Ib53d6da0d6660cf2c6a3283ff6123a2f18a8abda Reviewed-on: https://code.wireshark.org/review/9128 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-06-25Add minimize and maximize buttons to the TCP stream dialogs.Jeff Morriss1-1/+1
The first thing I generally do when I open a graph is to maximize it. Having a maximize button makes that a lot easier. Call QDialog(NULL, Qt::Window) similar to g80342e4. Call QDialog(NULL) in the about box. Change-Id: I4f229ab579d0912cb03ba8f8d0300d933d0ba914 Reviewed-on: https://code.wireshark.org/review/7072 Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-29Qt: Add address conversion convenience routinesGerald Combs1-6/+2
Add address_to_qstring and address_to_display_qstring, which wrap address_to_string and address_to_display respectively and return QStrings. Convert most of the instances in ui/qt to the new routines. Fix a some memory leaks in the process. Change-Id: Icda80bbfe0b2df723d54c8da84355255f819af89 Reviewed-on: https://code.wireshark.org/review/6848 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-01-06Replace ep_address_to_str with address_to_str.Michael Mann1-4/+9
Change-Id: I4f1078b20f41800f72a751612703ad0d4c2ae87b Reviewed-on: https://code.wireshark.org/review/6323 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-31Qt: Convert more dialog titles.Gerald Combs1-1/+1
Change-Id: I9c3e3471a92b7af9347a541bece3d9405d37dce0 Reviewed-on: https://code.wireshark.org/review/6193 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-10-15Typos in source code and in README.qtDario Lombardo1-1/+1
Change-Id: I5aef31ef7ad604352f6e108835f0e9c2d10cdf8a Reviewed-on: https://code.wireshark.org/review/4706 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-04-07Add a Qt I/O Graph dialog.Gerald Combs1-8/+9
For each graph you can set: - Its visibility - A name - A display filter - Color, from a fixed list - Plot style: Line, Impulse, Bar, Stacked Bar, Dot, Square, Diamond - Basic Y Axes (packets/s, bytes/s, bits/s) - Computed Y Axes (SUM, MIN, AVG, MAX) - Smoothing You can pan and zoom using the mouse and keyboard. Clicking on a graph selects the last packet for that interval. If all graphs have the same Y axis a single label is shown, otherwise a legend is shown. The time scale (X axis) can be toggled between relative seconds and the time of day. Graphs can be saved as PDF, PNG, BMP, and JPEG. Settings are "sticky" via the io_graphs UAT. To do: - Minimize graph drawing delays. - Figure out why smoothing differs from GTK+ - Everything else at the top of io_graph_dialog.cpp - Fix empty resets. A fair amount of code was copied from TCPStreamDialog. We might want to subclass QCustomPlot and place the shared code there. Move common syntax checking to SyntaxLineEdit. Move some common code from ui/gtk/io_stat.c to ui/io_graph_item.[ch] and use it in both GTK+ and Qt. Make the io_graph_item_t array allocation in io_stat.c static. The behavior should be identical and this gives us additional compile-time checks. Change-Id: I9a3d544469b7048f0761fdbf7bcf20f44ae76577 Reviewed-on: https://code.wireshark.org/review/435 Reviewed-by: Gerald Combs <gerald@wireshark.org> Tested-by: Gerald Combs <gerald@wireshark.org>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-01Fix some scan-build warnings.Gerald Combs1-0/+1
Fix a modeline while we're at it. Change-Id: Ief6d5edbe33456170059cfab4f436f0844de32a1 Reviewed-on: https://code.wireshark.org/review/440 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-02-24Fix Called C++ object pointer is null found by ClangAlexis La Goutte1-1/+1
Change-Id: I2263b4ac16945be6d87eaa8c963f7b03e437d724 Reviewed-on: https://code.wireshark.org/review/319 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2013-11-12Sequence / flow diagram updates.Gerald Combs1-9/+8
Add "Save As..." Add a context menu and keyboard shortcuts. Add a tooltip. svn path=/trunk/; revision=53263
2013-10-25More sequence dialog updates.Gerald Combs1-1/+0
Draw item labels and port numbers. Update the hint text. Make items selectable. Resize fonts similar to the GTK+ version. Add scrollbars. Update the cursor. Use pango_layout_set_ellipsize() in the GTK+ code. Fixup comments. svn path=/trunk/; revision=52855
2013-10-24Initial and woefully incomplete flow graph support.Gerald Combs1-2/+1
Copy common code from ui/gtk/flow_graph.c and ui/gtk/graph_analysis.[ch] to ui/tap-sequence-analysis.[ch]. Start using the name "sequence" in places. svn path=/trunk/; revision=52824
2013-09-16address_equal → addresses_equal. Switch from address macros to functionsGerald Combs1-5/+5
in the Qt code. svn path=/trunk/; revision=52108
2013-09-16Add stream information to the hint label. Update our hint more often.Gerald Combs1-11/+45
Add a "to do" list. svn path=/trunk/; revision=52102
2013-09-16Make sure we don't tap our packets twice. Give the graph has focus afterGerald Combs1-3/+5
we redraw it. svn path=/trunk/; revision=52095
2013-09-16Fix graph type selection.Gerald Combs1-13/+11
svn path=/trunk/; revision=52094
2013-09-16Another attempt at axis scaling. Tweak the appearance a little.Gerald Combs1-6/+18
svn path=/trunk/; revision=52093
2013-09-15When caclulating throughput, only subtract what we've added. Try to fixGerald Combs1-20/+15
axis scaling. svn path=/trunk/; revision=52092
2013-09-15Make sure the RTT behavior matches the GTK+ port. Make sure we properlyGerald Combs1-15/+29
select a graph type. svn path=/trunk/; revision=52083
2013-09-13Mis-use error bars to draw segments.Gerald Combs1-2/+21
svn path=/trunk/; revision=52029
2013-09-13More TCP stream graph updates.Gerald Combs1-129/+174
Scan our segment list (and the capture file) once per stream. Switch the stream selection control to a QSpinBox. Add graph type selection actions. The context menu + shortcuts should now be complete. Add the intitial tcptrace graph. Only ACKs and RWINs so far. A bunch of other updates and fixes. svn path=/trunk/; revision=52027
2013-09-12Add a context menu to the TCP stream graph which includes all of ourGerald Combs1-48/+172
keyboard shortcuts. svn path=/trunk/; revision=51996
2013-09-12== has higher precedence than &Jörg Mayer1-1/+1
http://en.wikipedia.org/wiki/Operators_in_C_and_C++ svn path=/trunk/; revision=51990
2013-09-12Add previous/next stream navigation to the TCP stream graph dialog.Gerald Combs1-8/+71
Add get_tcp_stream_count() to the TCP dissector and modify graph_segment_list_get() to allow matching based solely on a stream. Use text instead of icons for the mouse click behavior buttons. Remove their PNG resources since we aren't using them any more. Fix setting the cursor in the graph widget. svn path=/trunk/; revision=51989
2013-09-09Add the TCP window scaling graph. Add zoom selections.Gerald Combs1-71/+316
Rename some methods. Add the ability to toggle time and sequence number origins. Add more keyboard shortcuts. Comment out abs_secs abs_usecs in the segment struct since it looks like we aren't using them. Make sure we stay in the same TCP stream. svn path=/trunk/; revision=51856
2013-09-08Fix "seq_base could be used unitialized" warning. We should probably enableEvan Huus1-1/+1
-Werror for the qt code... svn path=/trunk/; revision=51839
2013-09-08Add the TCP RTT graph.Gerald Combs1-13/+102
Show the time values in ms instead of s. Add a button and keyboard shortcut to switch the connection direction. Move more code to tap-tcp-stream.c. Update our axis labels. svn path=/trunk/; revision=51832
2013-09-07Only add data points to the throughput graph if our time window hasGerald Combs1-3/+17
advanced. Add a reset button. svn path=/trunk/; revision=51811
2013-09-07Fix PacketList::goToPacket work correctly. Minor screen graphGerald Combs1-4/+4
improvements. svn path=/trunk/; revision=51808
2013-09-06Switch from a 20 segment moving average to a 1 second MA. Add a #defineGerald Combs1-5/+23
to allow switching back to the old behavior. Note that goToPacket can jump to the wrong packet if we have a display filter applied. svn path=/trunk/; revision=51801
2013-09-06Adjust titles and labels.Gerald Combs1-4/+9
svn path=/trunk/; revision=51797
2013-09-06Make graph movement pixel-based to match the GTK+ version.Gerald Combs1-4/+4
svn path=/trunk/; revision=51796
2013-09-06Throughput graph usability updates.Gerald Combs1-42/+62
Make the stream graph dialog modeless and let the user open multiple instances. The dangling dialog behaves similar to the GTK+ version. Add a setDissectedCaptureFile signal to MainWindow (currently unused). Properly transform yAxis2 and simplify resetAxes while we're at it. Other bug fixes. svn path=/trunk/; revision=51795
2013-09-04Throughput graph updates.Gerald Combs1-57/+228
GTK+: Fix what appears to be an off-by-one error in the MA period (21 segments instead of 20). Throw away our initial segment length instead of subtracting it from the moving sum, which skews the sum. Qt: Add the througput graph. Use bits/s for the throughput y axis. Let the user switch between graph types. The dialog hangs when doing this. I haven't been able to track down the cause. Remove some unused code. Both: Tell the user that we're using a 20 segment moving average. Move more routines to tap-tcp-stream.[ch]. svn path=/trunk/; revision=51759
2013-08-30Implement "Save As..." in the TCP stream graph dialog. We currentlyGerald Combs1-1/+48
support PDF, PNG, BMP, and JPEG. svn path=/trunk/; revision=51607
2013-08-30Add an item tracer to the TCP stream graph. Enable packet selection.Gerald Combs1-43/+155
QCustomPlot data sets are made up of keys (x axis by default) and values (y axis). It looks like we can have multiple values for a given key (i.e. we can show multiple sequence numbers for a given timestamp) but QCPItemTracers can only be positioned by a key and not a key+value pair. This makes our graph selection behavior a bit different compared to the GTK+ version. We can only select one segment for a give timestamp but our selection targets are much larger (the height of the graph). Add a map for segment data so we don't have to iterate to find them. Use UTF8_RIGHTWARDS_ARROW where appropriate. Set a window title. Tell the user what will happen if he or she clicks. Disable graph selection. svn path=/trunk/; revision=51604
2013-08-28Let the QCustomPlot widget have focus.Gerald Combs1-0/+2
svn path=/trunk/; revision=51555
2013-08-27Add initial mouse and keyboard controls. QCustomPlot uses differentGerald Combs1-6/+88
mouse interactions than the GTK+ version, but they seem to match modern UI conventions better. The keyboard shortcuts have been changed to match modern UI conventions as well, but I'll try to support the old shortcuts as much as possible. svn path=/trunk/; revision=51554
2013-08-27Add TCP sequence number (Stevens-style) graphs.Gerald Combs1-0/+102
Add the QCustomPlot widget. Thanks to Emanuel Eichhammer for granting a license change. Move some common code from ui/gtk/tcp_graph.c to ui/tap-tcp-stream.[ch]. Get rid of tcp_graph_selected_packet_enabled(). It was only used in the menu code and didn't match what we were doing elsewhere. Still quite a bit of work to do but it's a promising start. svn path=/trunk/; revision=51538
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-26 14:40:39 +0000