aboutsummaryrefslogtreecommitdiffstats
path: root/ui/qt/recent_file_status.h
AgeCommit message (Collapse)AuthorFilesLines
2018-02-08replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later.Dario Lombardo1-1/+1
The first is deprecated, as per https://spdx.org/licenses/. Change-Id: I8e21e1d32d09b8b94b93a2dc9fbdde5ffeba6bed Reviewed-on: https://code.wireshark.org/review/25661 Petri-Dish: Anders Broman <a.broman58@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-03Make a deep copy of our filename in RecentFileStatus.Gerald Combs1-3/+1
QStrings are implictly shared as described at http://doc.qt.io/qt-5/implicit-sharing.html. This is normally useful, but RecentFileStatus is passed a QString before it does its work in a separate thread. Make a deep copy of the filename in order to ensure local ownership and to avoid having to fool around with a QMutex (which might not be recognized by ThreadSanitizer[1] or Helgrind[2]). Remove getFilename since it was unused. [1] https://github.com/google/sanitizers/issues/460 [2] http://valgrind.org/docs/manual/hg-manual.html Change-Id: I5b5c329505ed8c02d30043a2a6d1ded625924b9f Reviewed-on: https://code.wireshark.org/review/25572 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-12-17Qt: Handle RecentFileStatus destruction manually.Gerald Combs1-1/+1
Restore the "deleteLater" behavior removed in 889aacae6e so that we don't trigger an assert in debug builds. Move the itemStatusFinished connection to RecentFileStatus while we're here. Bug: 14279 Change-Id: I79bc74d77fb3ad970c7c8a71037f680d55eac47c Reviewed-on: https://code.wireshark.org/review/24875 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-12-17Qt: Update our recent status sooner at startup.Gerald Combs1-18/+3
Update our recent file status as soon as we read recent_common. Run recent stats updates in the global thread pool. Revert 15a97b5986 since it's no longer needed. Change-Id: If1b08ea640dfcad26affab5d20c80c90fbf133f2 Reviewed-on: https://code.wireshark.org/review/24862 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-03-18Qt: Fix recent files threadsMichal Labedzki1-13/+12
Fix crash and memory leak. Please not that Recent File Status objects and threads still continously grow and shrink memory usage, but do not grow continuously. Bug: 10893 Change-Id: Icc8b7fefd6572b902ac81d22e5f7b16e304fcf16 Reviewed-on: https://code.wireshark.org/review/7699 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Reviewed-by: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-07-09Fix a "recent items" crash.Gerald Combs1-2/+2
Use a QMutableListIterator instead of a foreach loop so that we can safely remove items from a list. While we're here, make sure that RecentFileStatus threads use a Qt::QueuedConnection when emitting signals across threads and try to isolate the filename string. Change-Id: I3fbb65a1727133f4557026decab5084a3faec2d4 Reviewed-on: https://code.wireshark.org/review/2966 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-08-08Add initial capture filter support.Gerald Combs1-5/+6
Add CaptureFilterCombo and CaptureFilterEdit classes, similar to their display filter counterparts. Add a CaptureFilterSyntaxWorker class which runs a syntax check in a background thread similar to the threaded code in capture_dlg.c. Add a bunch of related signal and slot plumbing. Other minor fixups. svn path=/trunk/; revision=51200
2012-09-04Add modelines for Qtshark fileAlexis La Goutte1-0/+13
svn path=/trunk/; revision=44766
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-01-04Add initial support for Qt along with a "ui" subdirectory.Gerald Combs1-0/+52
svn path=/trunk/; revision=40378